Issue metadata
Sign in to add a comment
|
There are a few test failures when S13nSafeBrowsingParallelUrlCheck is turned on. |
||||||||||||||||||||||||
Issue descriptionPlease see the try result of: https://chromium-review.googlesource.com/c/chromium/src/+/646765
,
Sep 8 2017
,
Oct 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e68db72412c61f03cd33da42d89bf9abca1326b commit 2e68db72412c61f03cd33da42d89bf9abca1326b Author: Yuzhu Shen <yzshen@chromium.org> Date: Wed Oct 11 23:09:47 2017 SafeBrowsingBlockingPageTest: fix race condition of waiting for interstitial page to be ready. The previous code may get the interstitial page while it hasn't loaded the actual contents (i.e., it is still about:blank). Without this fix, the tests SecurityStateGoBackOnSubresourceInterstitial* become (more?) flaky when S13nSafeBrowsingParallelUrlCheck is enabled, since that feature changes timing of events. BUG= 761468 Change-Id: I0785bf5084b280f6185bc39cf1a4ac6331950f46 Reviewed-on: https://chromium-review.googlesource.com/713754 Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Reviewed-by: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#508159} [modify] https://crrev.com/2e68db72412c61f03cd33da42d89bf9abca1326b/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c92c9adbab2ce1dadb6b594ae86e7fa91e156863 commit c92c9adbab2ce1dadb6b594ae86e7fa91e156863 Author: Yuzhu Shen <yzshen@chromium.org> Date: Thu Oct 12 19:56:17 2017 Fix prefetch browser tests for SafeBrowsing. This CL fixes the following for the S13nSafeBrowsingParallelUrlCheck feature: - NoStatePrefetchBrowserTest/NoStatePrefetchBrowserTest.PrerenderSafeBrowsingSubresource/* - NoStatePrefetchBrowserTest/NoStatePrefetchBrowserTest.PrerenderSafeBrowsingTopLevel/* With the feature enabled, requests are started in parallel with SafeBrowsing checks, therefore it is unreliable to check that unsafe requests are not started (SafeBrowsing still guarantees to block the response). BUG= 761468 Change-Id: Ifa2f73879744fa9cf4c2400e11c64f1018007726 Reviewed-on: https://chromium-review.googlesource.com/711017 Reviewed-by: Egor Pasko <pasko@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#508402} [modify] https://crrev.com/c92c9adbab2ce1dadb6b594ae86e7fa91e156863/chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc
,
Oct 19 2017
,
Nov 7 2017
Apologies, applied the wrong component in bulk. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Sep 7 2017