As idle time spell checker is already launched, the deprecated non-idle-time spell checker should be removed.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0f428636cd44c3f6b3016b912fd5804d83c2d0c commit b0f428636cd44c3f6b3016b912fd5804d83c2d0c Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Mon Sep 04 06:22:00 2017 Remove non-idle-time spell checker code As idle time spell checker is already launched, this patch removes the old spellcheck code as cleanup. It not only removes code in SpellChecker.h/cpp, but also cleans up code in the callers if the caller does nothing but invoking the old spellchecker: - Editor::RespondToChangedSelection - HTMLInputElement::BeginEditing - HTMLTextAreaElement::HandleFocusEvent - All the shenanigans about Element flag AlreadySpellChecked This patch also removes checking of runtime flag idleTimeSpellChecking from layout tests. A follow up patch will remove the flags from Blink and Chrome. Bug: 761459 Change-Id: Id574cb45057a7c215e8195a268a5145b4fbbdcf1 Reviewed-on: https://chromium-review.googlesource.com/648326 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#499442} [modify] https://crrev.com/b0f428636cd44c3f6b3016b912fd5804d83c2d0c/third_party/WebKit/LayoutTests/accessibility/misspellings.html [modify] https://crrev.com/b0f428636cd44c3f6b3016b912fd5804d83c2d0c/third_party/WebKit/LayoutTests/editing/spelling/mark-empty-crash.html [modify] https://crrev.com/b0f428636cd44c3f6b3016b912fd5804d83c2d0c/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-async-mutation.html [modify] https://crrev.com/b0f428636cd44c3f6b3016b912fd5804d83c2d0c/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-async-remove-frame.html [modify] https://crrev.com/b0f428636cd44c3f6b3016b912fd5804d83c2d0c/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-mixed-editable-crash.html [modify] https://crrev.com/b0f428636cd44c3f6b3016b912fd5804d83c2d0c/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-mixed-editable-long-text-crash.html [modify] https://crrev.com/b0f428636cd44c3f6b3016b912fd5804d83c2d0c/third_party/WebKit/LayoutTests/editing/spelling/spellcheck_test.js [modify] https://crrev.com/b0f428636cd44c3f6b3016b912fd5804d83c2d0c/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/b0f428636cd44c3f6b3016b912fd5804d83c2d0c/third_party/WebKit/Source/core/dom/Element.h [modify] https://crrev.com/b0f428636cd44c3f6b3016b912fd5804d83c2d0c/third_party/WebKit/Source/core/editing/Editor.cpp [modify] https://crrev.com/b0f428636cd44c3f6b3016b912fd5804d83c2d0c/third_party/WebKit/Source/core/editing/Editor.h [modify] https://crrev.com/b0f428636cd44c3f6b3016b912fd5804d83c2d0c/third_party/WebKit/Source/core/editing/FrameSelection.cpp [modify] https://crrev.com/b0f428636cd44c3f6b3016b912fd5804d83c2d0c/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp [modify] https://crrev.com/b0f428636cd44c3f6b3016b912fd5804d83c2d0c/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp [modify] https://crrev.com/b0f428636cd44c3f6b3016b912fd5804d83c2d0c/third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.cpp [modify] https://crrev.com/b0f428636cd44c3f6b3016b912fd5804d83c2d0c/third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallbackTest.cpp [modify] https://crrev.com/b0f428636cd44c3f6b3016b912fd5804d83c2d0c/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp [modify] https://crrev.com/b0f428636cd44c3f6b3016b912fd5804d83c2d0c/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h [modify] https://crrev.com/b0f428636cd44c3f6b3016b912fd5804d83c2d0c/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerClientImpl.cpp [modify] https://crrev.com/b0f428636cd44c3f6b3016b912fd5804d83c2d0c/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp [modify] https://crrev.com/b0f428636cd44c3f6b3016b912fd5804d83c2d0c/third_party/WebKit/Source/core/exported/WebFrameTest.cpp [modify] https://crrev.com/b0f428636cd44c3f6b3016b912fd5804d83c2d0c/third_party/WebKit/Source/core/html/HTMLInputElement.cpp [modify] https://crrev.com/b0f428636cd44c3f6b3016b912fd5804d83c2d0c/third_party/WebKit/Source/core/html/HTMLInputElement.h [modify] https://crrev.com/b0f428636cd44c3f6b3016b912fd5804d83c2d0c/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp [modify] https://crrev.com/b0f428636cd44c3f6b3016b912fd5804d83c2d0c/third_party/WebKit/Source/core/html/HTMLTextAreaElement.h [modify] https://crrev.com/b0f428636cd44c3f6b3016b912fd5804d83c2d0c/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae75ef9accdc5653ddd8714b0170fe1db07b7104 commit ae75ef9accdc5653ddd8714b0170fe1db07b7104 Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Wed Sep 06 05:38:09 2017 Remove runtime flags for idle time spell checker Since idle time spell checker is already launched, and all old code paths that not using idle time spell checker have been removed, this patch removes the runtime flags as the final cleanup for this project. Bug: 761459 Change-Id: I9db06f150618ff49f58072a508362925489e5ca0 Reviewed-on: https://chromium-review.googlesource.com/648079 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#499887} [modify] https://crrev.com/ae75ef9accdc5653ddd8714b0170fe1db07b7104/chrome/browser/about_flags.cc [modify] https://crrev.com/ae75ef9accdc5653ddd8714b0170fe1db07b7104/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/ae75ef9accdc5653ddd8714b0170fe1db07b7104/chrome/browser/flag_descriptions.h [modify] https://crrev.com/ae75ef9accdc5653ddd8714b0170fe1db07b7104/content/child/runtime_features.cc [modify] https://crrev.com/ae75ef9accdc5653ddd8714b0170fe1db07b7104/content/public/common/content_features.cc [modify] https://crrev.com/ae75ef9accdc5653ddd8714b0170fe1db07b7104/content/public/common/content_features.h [modify] https://crrev.com/ae75ef9accdc5653ddd8714b0170fe1db07b7104/testing/variations/fieldtrial_testing_config.json [modify] https://crrev.com/ae75ef9accdc5653ddd8714b0170fe1db07b7104/third_party/WebKit/Source/core/testing/Internals.idl [modify] https://crrev.com/ae75ef9accdc5653ddd8714b0170fe1db07b7104/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5
Comment 1 by bugdroid1@chromium.org
, Sep 4 2017