Issue metadata
Sign in to add a comment
|
Show a toast when presenting WebVR from VR browser |
||||||||||||||||||||||||||
Issue descriptionThis is a regression caused by my CL: https://chromium-review.googlesource.com/c/chromium/src/+/575279 The toast is a security related requirement. We will want to merge back the fix to M62.
,
Sep 1 2017
,
Sep 1 2017
,
Sep 2 2017
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4969b1402ba05ff0bd686eefef4f0c8e12f39137 commit 4969b1402ba05ff0bd686eefef4f0c8e12f39137 Author: Biao She <bshe@chromium.org> Date: Tue Sep 05 19:43:50 2017 Fix WebVR toast regression When click presenting WebVR button from VR browser, a viewport aware toast which shows how to exit VR presentation should show up on top of WebVR frame. There is a regression introduced recently and this CL fixs it. TBR=bshe@chromium.org (cherry picked from commit daaa8e910912e1ae9b08f28f31e3df170269543f) Bug: 761402 Change-Id: I0f66e8b64f17f83394ae28f140dccb2c232071c5 Reviewed-on: https://chromium-review.googlesource.com/647832 Reviewed-by: Ian Vollick <vollick@chromium.org> Commit-Queue: Biao She <bshe@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499240} Reviewed-on: https://chromium-review.googlesource.com/651286 Reviewed-by: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#28} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/4969b1402ba05ff0bd686eefef4f0c8e12f39137/chrome/browser/vr/elements/ui_element.cc [modify] https://crrev.com/4969b1402ba05ff0bd686eefef4f0c8e12f39137/chrome/browser/vr/test/ui_scene_manager_test.cc [modify] https://crrev.com/4969b1402ba05ff0bd686eefef4f0c8e12f39137/chrome/browser/vr/ui_renderer.cc [modify] https://crrev.com/4969b1402ba05ff0bd686eefef4f0c8e12f39137/chrome/browser/vr/ui_scene_manager.cc
,
Sep 5 2017
,
Oct 4 2017
verified on 63.0.3223.7 Pixel XL |
|||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Sep 1 2017