New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 761402 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Show a toast when presenting WebVR from VR browser

Project Member Reported by bshe@chromium.org, Sep 1 2017

Issue description

This is a regression caused by my CL:
https://chromium-review.googlesource.com/c/chromium/src/+/575279

The toast is a security related requirement. We will want to merge back the fix to M62.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/daaa8e910912e1ae9b08f28f31e3df170269543f

commit daaa8e910912e1ae9b08f28f31e3df170269543f
Author: Biao She <bshe@chromium.org>
Date: Fri Sep 01 18:36:49 2017

Fix WebVR toast regression

When click presenting WebVR button from VR browser, a viewport aware toast
which shows how to exit VR presentation should show up on top of WebVR frame.
There is a regression introduced recently and this CL fixs it.

Bug:  761402 
Change-Id: I0f66e8b64f17f83394ae28f140dccb2c232071c5
Reviewed-on: https://chromium-review.googlesource.com/647832
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499240}
[modify] https://crrev.com/daaa8e910912e1ae9b08f28f31e3df170269543f/chrome/browser/vr/elements/ui_element.cc
[modify] https://crrev.com/daaa8e910912e1ae9b08f28f31e3df170269543f/chrome/browser/vr/test/ui_scene_manager_test.cc
[modify] https://crrev.com/daaa8e910912e1ae9b08f28f31e3df170269543f/chrome/browser/vr/ui_renderer.cc
[modify] https://crrev.com/daaa8e910912e1ae9b08f28f31e3df170269543f/chrome/browser/vr/ui_scene_manager.cc

Comment 2 by bshe@chromium.org, Sep 1 2017

Labels: Merge-Request-62
Labels: Type-Bug-Regression
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 2 2017

Labels: -Merge-Request-62 Hotlist-Merge-Approved Merge-Approved-62
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 5 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4969b1402ba05ff0bd686eefef4f0c8e12f39137

commit 4969b1402ba05ff0bd686eefef4f0c8e12f39137
Author: Biao She <bshe@chromium.org>
Date: Tue Sep 05 19:43:50 2017

Fix WebVR toast regression

When click presenting WebVR button from VR browser, a viewport aware toast
which shows how to exit VR presentation should show up on top of WebVR frame.
There is a regression introduced recently and this CL fixs it.

TBR=bshe@chromium.org

(cherry picked from commit daaa8e910912e1ae9b08f28f31e3df170269543f)

Bug:  761402 
Change-Id: I0f66e8b64f17f83394ae28f140dccb2c232071c5
Reviewed-on: https://chromium-review.googlesource.com/647832
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Biao She <bshe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499240}
Reviewed-on: https://chromium-review.googlesource.com/651286
Reviewed-by: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#28}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/4969b1402ba05ff0bd686eefef4f0c8e12f39137/chrome/browser/vr/elements/ui_element.cc
[modify] https://crrev.com/4969b1402ba05ff0bd686eefef4f0c8e12f39137/chrome/browser/vr/test/ui_scene_manager_test.cc
[modify] https://crrev.com/4969b1402ba05ff0bd686eefef4f0c8e12f39137/chrome/browser/vr/ui_renderer.cc
[modify] https://crrev.com/4969b1402ba05ff0bd686eefef4f0c8e12f39137/chrome/browser/vr/ui_scene_manager.cc

Comment 6 by bshe@chromium.org, Sep 5 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
verified on 63.0.3223.7 Pixel XL

Sign in to add a comment