New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 761391 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Various web platform tests reference testRunner

Project Member Reported by tdres...@chromium.org, Sep 1 2017

Issue description

Web platform tests don't have access to testRunner, but various tests reference it anyways.

https://cs.chromium.org/search/?q=testrunner+file:%5Esrc/third_party/WebKit/LayoutTests/external/wpt/+package:%5Echromium$&type=cs
 
Probably just a mistake in review (other than the results in "blink-contrib", which are just a vendor-specific archive I believe).  I suggest we just remove any of these blocks - they should be unnecessary.
Labels: Hotlist-GoodFirstBug
Owner: rob.b...@samsung.com
Status: Assigned (was: Available)

Comment 4 by cha...@chromium.org, Sep 14 2017

Components: -Blink>Infra>Predictability Blink>Infra>Ecosystem
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3213cf3bde76f6264d35e8686d396058a8748a3f

commit 3213cf3bde76f6264d35e8686d396058a8748a3f
Author: Rob Buis <rob.buis@samsung.com>
Date: Mon Oct 02 17:39:48 2017

Remove testRunner references in wpt tests

These references have no effect, so remove them.

Bug:  761391 
Change-Id: I85df5d4520f9d6b4719c86a903a22360df3ae421
Reviewed-on: https://chromium-review.googlesource.com/665338
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505666}
[modify] https://crrev.com/3213cf3bde76f6264d35e8686d396058a8748a3f/third_party/WebKit/LayoutTests/external/wpt/css-paint-api/valid-image-after-load.html
[modify] https://crrev.com/3213cf3bde76f6264d35e8686d396058a8748a3f/third_party/WebKit/LayoutTests/external/wpt/css-paint-api/valid-image-before-load.html
[modify] https://crrev.com/3213cf3bde76f6264d35e8686d396058a8748a3f/third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001.html
[modify] https://crrev.com/3213cf3bde76f6264d35e8686d396058a8748a3f/third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001a.html
[modify] https://crrev.com/3213cf3bde76f6264d35e8686d396058a8748a3f/third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001b.html
[modify] https://crrev.com/3213cf3bde76f6264d35e8686d396058a8748a3f/third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001c.html
[modify] https://crrev.com/3213cf3bde76f6264d35e8686d396058a8748a3f/third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001d.html
[modify] https://crrev.com/3213cf3bde76f6264d35e8686d396058a8748a3f/third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001e.html
[modify] https://crrev.com/3213cf3bde76f6264d35e8686d396058a8748a3f/third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001f.html
[modify] https://crrev.com/3213cf3bde76f6264d35e8686d396058a8748a3f/third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001g.html
[modify] https://crrev.com/3213cf3bde76f6264d35e8686d396058a8748a3f/third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001h.html
[modify] https://crrev.com/3213cf3bde76f6264d35e8686d396058a8748a3f/third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001i.html
[modify] https://crrev.com/3213cf3bde76f6264d35e8686d396058a8748a3f/third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001j.html
[modify] https://crrev.com/3213cf3bde76f6264d35e8686d396058a8748a3f/third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001k.html
[modify] https://crrev.com/3213cf3bde76f6264d35e8686d396058a8748a3f/third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001l.html
[modify] https://crrev.com/3213cf3bde76f6264d35e8686d396058a8748a3f/third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001m.html
[modify] https://crrev.com/3213cf3bde76f6264d35e8686d396058a8748a3f/third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001n.html
[modify] https://crrev.com/3213cf3bde76f6264d35e8686d396058a8748a3f/third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001o.html
[modify] https://crrev.com/3213cf3bde76f6264d35e8686d396058a8748a3f/third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001p.html
[modify] https://crrev.com/3213cf3bde76f6264d35e8686d396058a8748a3f/third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001q.html
[modify] https://crrev.com/3213cf3bde76f6264d35e8686d396058a8748a3f/third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001r.html
[modify] https://crrev.com/3213cf3bde76f6264d35e8686d396058a8748a3f/third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001s.html
[modify] https://crrev.com/3213cf3bde76f6264d35e8686d396058a8748a3f/third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001t.html
[modify] https://crrev.com/3213cf3bde76f6264d35e8686d396058a8748a3f/third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001u.html
[modify] https://crrev.com/3213cf3bde76f6264d35e8686d396058a8748a3f/third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001v.html
[modify] https://crrev.com/3213cf3bde76f6264d35e8686d396058a8748a3f/third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001w.html
[modify] https://crrev.com/3213cf3bde76f6264d35e8686d396058a8748a3f/third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001x.html
[modify] https://crrev.com/3213cf3bde76f6264d35e8686d396058a8748a3f/third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes-3/tools/generators/orthogonal-parent-shrink-to-fit.ejs
[modify] https://crrev.com/3213cf3bde76f6264d35e8686d396058a8748a3f/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-frame-resource.https.html

Status: Fixed (was: Assigned)
Should be fixed.

Sign in to add a comment