New issue
Advanced search Search tips

Issue 761385 link

Starred by 4 users
Status: Fixed
Owner:
csharrison@chromium.org
Closed: Feb 2018
Cc:
a...@chromium.org
shivanisha@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 756089



Sign in to add a comment

Refactor Abusive experience enforcement out of subresource_filter

Project Member Reported by csharrison@chromium.org, Sep 1 2017 
While this is still triggered by the subresource_filter component (and Safe Browsing checks), it would be best to keep this in blocked_content near other popup blocking code, to avoid coupling and bugs.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e489f4a2dcb194c53378971d8ec84c7cfbe6a96

commit 5e489f4a2dcb194c53378971d8ec84c7cfbe6a96
Author: Charles Harrison <csharrison@chromium.org>
Date: Fri Sep 08 20:52:39 2017

[subresource_filter] Introduce Observer::OnSafeBrowsingCheckComplete

This CL should not change any behavior. This introduces a new method
on SubresourceFilterObserver that is only exercised in tests.

Bug:  761385 
Change-Id: I8a63de2985caec181a15eb5b58f8dde855ff3b50
Reviewed-on: https://chromium-review.googlesource.com/647471
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500653}
[modify] https://crrev.com/5e489f4a2dcb194c53378971d8ec84c7cfbe6a96/chrome/browser/subresource_filter/subresource_filter_test_harness.h
[modify] https://crrev.com/5e489f4a2dcb194c53378971d8ec84c7cfbe6a96/chrome/browser/subresource_filter/subresource_filter_unittest.cc
[modify] https://crrev.com/5e489f4a2dcb194c53378971d8ec84c7cfbe6a96/components/subresource_filter/content/browser/BUILD.gn
[modify] https://crrev.com/5e489f4a2dcb194c53378971d8ec84c7cfbe6a96/components/subresource_filter/content/browser/subresource_filter_observer.h
[modify] https://crrev.com/5e489f4a2dcb194c53378971d8ec84c7cfbe6a96/components/subresource_filter/content/browser/subresource_filter_observer_manager.cc
[modify] https://crrev.com/5e489f4a2dcb194c53378971d8ec84c7cfbe6a96/components/subresource_filter/content/browser/subresource_filter_observer_manager.h
[modify] https://crrev.com/5e489f4a2dcb194c53378971d8ec84c7cfbe6a96/components/subresource_filter/content/browser/subresource_filter_observer_test_utils.cc
[modify] https://crrev.com/5e489f4a2dcb194c53378971d8ec84c7cfbe6a96/components/subresource_filter/content/browser/subresource_filter_observer_test_utils.h
[modify] https://crrev.com/5e489f4a2dcb194c53378971d8ec84c7cfbe6a96/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.cc
[modify] https://crrev.com/5e489f4a2dcb194c53378971d8ec84c7cfbe6a96/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.h

Comment 2 Deleted

Comment 3 by csharrison@chromium.org, Oct 6 2017

Cc: a...@chromium.org
cc avi as FYI, since we are planning on moving most of this logic into ui/blocked_content, to live alongside the traditional popup blocker.

I'll try to land this after M63 has its branch cut, so we have low risk of breaking anything with this refactor.

Comment 4 by csharrison@chromium.org, Oct 9 2017 

For more context, see the (internal only, sorry) doc about this refactor:
https://docs.google.com/document/d/1MIncjBQaWatfed6rGnR13MdHpL0kWhLxcNc2L__k8QQ/edit#heading=h.nuz2r9y19mhu
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60f7c65384d77a57793f78dbcc571548ff6b6d9f

commit 60f7c65384d77a57793f78dbcc571548ff6b6d9f
Author: Charles Harrison <csharrison@chromium.org>
Date: Thu Oct 12 20:04:08 2017

Introduce the SafeBrowsingTriggeredPopupBlocker

This CL changes no existing behavior. The new feature is only exercised
in unit tests.

This CL introduces a new form of popup blocker, one which applies a
stronger policy to sites marked via safe browsing. The new object is
designed to be owned by the popup_blocker_tab_helper.

Note: This feature is already more or less implemented in
components/subresource_filter, but we're trying to separate it from
that feature since they are only related in that they are both
triggered via safe browsing.

Bug:  761385 
Change-Id: I98762e213157453f2ceb97adcc22f1a4c86d1033
Reviewed-on: https://chromium-review.googlesource.com/706518
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508415}
[modify] https://crrev.com/60f7c65384d77a57793f78dbcc571548ff6b6d9f/chrome/browser/DEPS
[modify] https://crrev.com/60f7c65384d77a57793f78dbcc571548ff6b6d9f/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/60f7c65384d77a57793f78dbcc571548ff6b6d9f/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker.cc
[add] https://crrev.com/60f7c65384d77a57793f78dbcc571548ff6b6d9f/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker.h
[add] https://crrev.com/60f7c65384d77a57793f78dbcc571548ff6b6d9f/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker_unittest.cc
[modify] https://crrev.com/60f7c65384d77a57793f78dbcc571548ff6b6d9f/chrome/test/BUILD.gn
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba5ed0ca9dd37dcc90816418b2e0439741968136

commit ba5ed0ca9dd37dcc90816418b2e0439741968136
Author: Balazs Engedy <engedy@chromium.org>
Date: Fri Oct 13 09:08:31 2017

Revert "Add console unit tests to SafeBrowsingTriggeredPopupBlocker"

This reverts commit 61a96faf6af13d531446005ec766dead36b54241.

Reason for revert:

Depends on
https://chromium-review.googlesource.com/c/chromium/src/+/706518
which needs to be reverted.

Original change's description:
> Add console unit tests to SafeBrowsingTriggeredPopupBlocker
> 
> Bug:  761385 
> Change-Id: Ib364e578c3f4b3fc99cc2987e55c9331776ad67a
> Reviewed-on: https://chromium-review.googlesource.com/713615
> Commit-Queue: Charlie Harrison <csharrison@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#508522}

TBR=avi@chromium.org,csharrison@chromium.org

Change-Id: I624a701e8e318a74d574ad440bd08f592e4117dd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  761385 
Reviewed-on: https://chromium-review.googlesource.com/718416
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508650}
[modify] https://crrev.com/ba5ed0ca9dd37dcc90816418b2e0439741968136/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/8bec2ccaf446a1f98c0474b8b9516ab9447b5528/chrome/browser/ui/blocked_content/console_logger.cc
[delete] https://crrev.com/8bec2ccaf446a1f98c0474b8b9516ab9447b5528/chrome/browser/ui/blocked_content/console_logger.h
[modify] https://crrev.com/ba5ed0ca9dd37dcc90816418b2e0439741968136/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker.cc
[modify] https://crrev.com/ba5ed0ca9dd37dcc90816418b2e0439741968136/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker.h
[modify] https://crrev.com/ba5ed0ca9dd37dcc90816418b2e0439741968136/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker_unittest.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a556881f03278794e834dbf3ae195b4d896daca

commit 7a556881f03278794e834dbf3ae195b4d896daca
Author: Balazs Engedy <engedy@chromium.org>
Date: Fri Oct 13 09:10:39 2017

Revert "Strong Popup Blocker: Action histograms"

This reverts commit c545f4acae85aaf928d6cd59d18f2ca3a28b7d42.

Reason for revert:

Depends on 
https://chromium-review.googlesource.com/c/chromium/src/+/706518
which needs to be reverted.

Original change's description:
> Strong Popup Blocker: Action histograms
> 
> This CL adds a new enum histogram which logs at various
> key points during strong popup blocking (aka abusive experience
> enforcement).
> 
> Bug:  761385 
> Change-Id: I2c16c11f393802e7743a4951d25a04642afcb717
> Reviewed-on: https://chromium-review.googlesource.com/713475
> Commit-Queue: Charlie Harrison <csharrison@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Steven Holte <holte@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#508433}

TBR=avi@chromium.org,holte@chromium.org,csharrison@chromium.org

Change-Id: I6e490953fbad5ce59c4e6d1b13019563fb76d5dd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  761385 
Reviewed-on: https://chromium-review.googlesource.com/718376
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508651}
[modify] https://crrev.com/7a556881f03278794e834dbf3ae195b4d896daca/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker.cc
[modify] https://crrev.com/7a556881f03278794e834dbf3ae195b4d896daca/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker.h
[modify] https://crrev.com/7a556881f03278794e834dbf3ae195b4d896daca/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker_unittest.cc
[modify] https://crrev.com/7a556881f03278794e834dbf3ae195b4d896daca/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/7a556881f03278794e834dbf3ae195b4d896daca/tools/metrics/histograms/histograms.xml
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54cef0b8e45c23e90fa4cce0ec6b686a7c5fda98

commit 54cef0b8e45c23e90fa4cce0ec6b686a7c5fda98
Author: Balazs Engedy <engedy@chromium.org>
Date: Fri Oct 13 09:11:53 2017

Revert "Introduce the SafeBrowsingTriggeredPopupBlocker"

This reverts commit 60f7c65384d77a57793f78dbcc571548ff6b6d9f.

Reason for revert:

Segmentation fault in:

renderer_side_navigation_unit_tests 
SafeBrowsingTriggeredPopupBlockerTest.FailNavigation_MaintainsBlocking

Original change's description:
> Introduce the SafeBrowsingTriggeredPopupBlocker
> 
> This CL changes no existing behavior. The new feature is only exercised
> in unit tests.
> 
> This CL introduces a new form of popup blocker, one which applies a
> stronger policy to sites marked via safe browsing. The new object is
> designed to be owned by the popup_blocker_tab_helper.
> 
> Note: This feature is already more or less implemented in
> components/subresource_filter, but we're trying to separate it from
> that feature since they are only related in that they are both
> triggered via safe browsing.
> 
> Bug:  761385 
> Change-Id: I98762e213157453f2ceb97adcc22f1a4c86d1033
> Reviewed-on: https://chromium-review.googlesource.com/706518
> Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: Charlie Harrison <csharrison@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#508415}

TBR=avi@chromium.org,sky@chromium.org,csharrison@chromium.org,shivanisha@chromium.org

Change-Id: I9b80e88dd388ca1f902e840d8d0d859402a204e8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  761385 
Reviewed-on: https://chromium-review.googlesource.com/718396
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508652}
[modify] https://crrev.com/54cef0b8e45c23e90fa4cce0ec6b686a7c5fda98/chrome/browser/DEPS
[modify] https://crrev.com/54cef0b8e45c23e90fa4cce0ec6b686a7c5fda98/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/7a556881f03278794e834dbf3ae195b4d896daca/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker.cc
[delete] https://crrev.com/7a556881f03278794e834dbf3ae195b4d896daca/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker.h
[delete] https://crrev.com/7a556881f03278794e834dbf3ae195b4d896daca/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker_unittest.cc
[modify] https://crrev.com/54cef0b8e45c23e90fa4cce0ec6b686a7c5fda98/chrome/test/BUILD.gn
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c5247ff645640403c5467c93307512d2fb4a343

commit 8c5247ff645640403c5467c93307512d2fb4a343
Author: Charles Harrison <csharrison@chromium.org>
Date: Fri Oct 13 19:43:32 2017

Reland Strong Popup Blocker

This CL squashes three reverted CLs:
1. crrev.com/508415
2. crrev.com/508433
3. crrev.com/508522

These were all reverted due to  crbug.com/774367 , caused
by executing a posted task on a deleted object (the fake database
manager) with PlzNavigate disabled.

The initial upload is just the raw squash of the three CLs. The
subsequent patches apply the fix.

Verified by running
SafeBrowsingTriggeredPopupBlockerTest.FailNavigation_MaintainsBlocking
On a debug Linux build with --disable-browser-side-navigation.

TBR=sky@chromium.org,holte@chromium.org

Bug:  761385 , 774367 
Change-Id: Ibff1a7bea7d1ca9df03060ab71852d589815cd5d
Reviewed-on: https://chromium-review.googlesource.com/718744
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508783}
[modify] https://crrev.com/8c5247ff645640403c5467c93307512d2fb4a343/chrome/browser/DEPS
[modify] https://crrev.com/8c5247ff645640403c5467c93307512d2fb4a343/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/8c5247ff645640403c5467c93307512d2fb4a343/chrome/browser/ui/blocked_content/console_logger.cc
[add] https://crrev.com/8c5247ff645640403c5467c93307512d2fb4a343/chrome/browser/ui/blocked_content/console_logger.h
[add] https://crrev.com/8c5247ff645640403c5467c93307512d2fb4a343/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker.cc
[add] https://crrev.com/8c5247ff645640403c5467c93307512d2fb4a343/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker.h
[add] https://crrev.com/8c5247ff645640403c5467c93307512d2fb4a343/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker_unittest.cc
[modify] https://crrev.com/8c5247ff645640403c5467c93307512d2fb4a343/chrome/test/BUILD.gn
[modify] https://crrev.com/8c5247ff645640403c5467c93307512d2fb4a343/components/subresource_filter/content/browser/fake_safe_browsing_database_manager.cc
[modify] https://crrev.com/8c5247ff645640403c5467c93307512d2fb4a343/components/subresource_filter/content/browser/fake_safe_browsing_database_manager.h
[modify] https://crrev.com/8c5247ff645640403c5467c93307512d2fb4a343/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/8c5247ff645640403c5467c93307512d2fb4a343/tools/metrics/histograms/histograms.xml
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca9d1ce1a925a7dc9bdf69b7755a948d4606a1bd

commit ca9d1ce1a925a7dc9bdf69b7755a948d4606a1bd
Author: Charles Harrison <csharrison@chromium.org>
Date: Wed Oct 18 17:15:17 2017

Abusive Enforcement: wire up the safe browsing blocker

This CL adds the SafeBrowsingTriggeredPopupBlocker to the original
popup blocker, and adds a suite of browsertests testing the feature.

These browsertests were copied directly from
chrome/browser/subresource_filter/subresource_filter_popup_browsertest.cc
In the first patch set, and modified in subsequent ones.

Bug:  761385 
Change-Id: Iee379847b126cb41f477cb5c810a9b6b8d7beb73
Reviewed-on: https://chromium-review.googlesource.com/709835
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509798}
[modify] https://crrev.com/ca9d1ce1a925a7dc9bdf69b7755a948d4606a1bd/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc
[modify] https://crrev.com/ca9d1ce1a925a7dc9bdf69b7755a948d4606a1bd/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.h
[add] https://crrev.com/ca9d1ce1a925a7dc9bdf69b7755a948d4606a1bd/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker_browsertest.cc
[modify] https://crrev.com/ca9d1ce1a925a7dc9bdf69b7755a948d4606a1bd/chrome/browser/ui/tab_helpers.cc
[modify] https://crrev.com/ca9d1ce1a925a7dc9bdf69b7755a948d4606a1bd/chrome/test/BUILD.gn
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b649eeedf58da69610cf67d52825613adcab106

commit 9b649eeedf58da69610cf67d52825613adcab106
Author: Charles Harrison <csharrison@chromium.org>
Date: Fri Oct 20 03:19:47 2017

Strong Popup Blocker: Log metrics aggregated per page load

This patch does a few things:
1. Log histogram of the total # of popups blocked per page load. To
   do this cleanly, introduce a new struct scoped to a page / document.

2. Don't initialize the class at all if the feature isn't enabled. This
   fixes a small bug where WARN messages would be logged even if the
   feature is disabled. The CL adds a regression test for this.

   The original reason for *not* doing this was so we could log dryrun
   style metrics, but I don't think the bug surface is worth it.

Bug:  761385 
Change-Id: Ife50d24ed6b63b389875c8eef444828487135bc6
Reviewed-on: https://chromium-review.googlesource.com/726545
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510317}
[modify] https://crrev.com/9b649eeedf58da69610cf67d52825613adcab106/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc
[modify] https://crrev.com/9b649eeedf58da69610cf67d52825613adcab106/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker.cc
[modify] https://crrev.com/9b649eeedf58da69610cf67d52825613adcab106/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker.h
[modify] https://crrev.com/9b649eeedf58da69610cf67d52825613adcab106/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker_browsertest.cc
[modify] https://crrev.com/9b649eeedf58da69610cf67d52825613adcab106/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker_unittest.cc
[modify] https://crrev.com/9b649eeedf58da69610cf67d52825613adcab106/tools/metrics/histograms/histograms.xml
Project Member

Comment 14 by bugdroid1@chromium.org, Nov 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cf8d936c78428a5c7ce6cd0bda87f0e53bd879f

commit 3cf8d936c78428a5c7ce6cd0bda87f0e53bd879f
Author: Charles Harrison <csharrison@chromium.org>
Date: Thu Nov 16 00:49:41 2017

[subresource_filter] Remove popup blocking code

This functionality has been moved to the safe_browsing_triggered_popup_blocker.

Note that most of the browsertests (in the subresource_filter_popup_browsertests)
have been replaced with ones with the safe_browsing_triggered blocker in a
previous change.

Bug:  761385 
Change-Id: I669bac5f8429ed3ad535c23be8a8c8570650f83e
Reviewed-on: https://chromium-review.googlesource.com/764777
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516924}
[modify] https://crrev.com/3cf8d936c78428a5c7ce6cd0bda87f0e53bd879f/chrome/browser/subresource_filter/chrome_subresource_filter_client.h
[modify] https://crrev.com/3cf8d936c78428a5c7ce6cd0bda87f0e53bd879f/chrome/browser/subresource_filter/subresource_filter_browsertest.cc
[modify] https://crrev.com/3cf8d936c78428a5c7ce6cd0bda87f0e53bd879f/chrome/browser/subresource_filter/subresource_filter_popup_browsertest.cc
[modify] https://crrev.com/3cf8d936c78428a5c7ce6cd0bda87f0e53bd879f/chrome/browser/subresource_filter/subresource_filter_unittest.cc
[modify] https://crrev.com/3cf8d936c78428a5c7ce6cd0bda87f0e53bd879f/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc
[modify] https://crrev.com/3cf8d936c78428a5c7ce6cd0bda87f0e53bd879f/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc
[modify] https://crrev.com/3cf8d936c78428a5c7ce6cd0bda87f0e53bd879f/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h
[modify] https://crrev.com/3cf8d936c78428a5c7ce6cd0bda87f0e53bd879f/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc
[modify] https://crrev.com/3cf8d936c78428a5c7ce6cd0bda87f0e53bd879f/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.h
[modify] https://crrev.com/3cf8d936c78428a5c7ce6cd0bda87f0e53bd879f/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc
[modify] https://crrev.com/3cf8d936c78428a5c7ce6cd0bda87f0e53bd879f/components/subresource_filter/content/browser/page_load_statistics.cc
[modify] https://crrev.com/3cf8d936c78428a5c7ce6cd0bda87f0e53bd879f/components/subresource_filter/content/browser/page_load_statistics.h
[modify] https://crrev.com/3cf8d936c78428a5c7ce6cd0bda87f0e53bd879f/components/subresource_filter/core/browser/subresource_filter_constants.h
[modify] https://crrev.com/3cf8d936c78428a5c7ce6cd0bda87f0e53bd879f/components/subresource_filter/core/browser/subresource_filter_features.cc
[modify] https://crrev.com/3cf8d936c78428a5c7ce6cd0bda87f0e53bd879f/components/subresource_filter/core/browser/subresource_filter_features.h
[modify] https://crrev.com/3cf8d936c78428a5c7ce6cd0bda87f0e53bd879f/components/subresource_filter/core/browser/subresource_filter_features_unittest.cc

Comment 15 by csharrison@chromium.org, Feb 26 2018

Status: Fixed (was: Started)
►

Sign in to add a comment