New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 761383 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Incremental build crashes on launch

Project Member Reported by awdf@chromium.org, Sep 1 2017

Issue description

checked out origin/master this morning at 14ec8a9f814e

$ nice ninja -C out/AndroidDebug -j2000 -l20 chrome_public_apk_incremental && out/AndroidDebug/bin
/chrome_public_apk uninstall && out/AndroidDebug/bin/chrome_public_apk install --incremental

It uninstalls and installs fine but on launch it crashes with the following stack:

9-01 14:48:23.983 E/AndroidRuntime(27095): FATAL EXCEPTION: main
09-01 14:48:23.983 E/AndroidRuntime(27095): Process: org.chromium.chrome, PID: 27095
09-01 14:48:23.983 E/AndroidRuntime(27095): java.lang.RuntimeException: Unable to instantiate application org.chromium.incrementali
nstall.BootstrapApplication: java.lang.RuntimeException: Incremental install failed.
09-01 14:48:23.983 E/AndroidRuntime(27095):     at android.app.LoadedApk.makeApplication(LoadedApk.java:971)
09-01 14:48:23.983 E/AndroidRuntime(27095):     at android.app.ActivityThread.handleBindApplication(ActivityThread.java:5765)
09-01 14:48:23.983 E/AndroidRuntime(27095):     at android.app.ActivityThread.-wrap1(Unknown Source:0)
09-01 14:48:23.983 E/AndroidRuntime(27095):     at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1661)
09-01 14:48:23.983 E/AndroidRuntime(27095):     at android.os.Handler.dispatchMessage(Handler.java:105)
09-01 14:48:23.983 E/AndroidRuntime(27095):     at android.os.Looper.loop(Looper.java:164)
09-01 14:48:23.983 E/AndroidRuntime(27095):     at android.app.ActivityThread.main(ActivityThread.java:6541)
09-01 14:48:23.983 E/AndroidRuntime(27095):     at java.lang.reflect.Method.invoke(Native Method)
09-01 14:48:23.983 E/AndroidRuntime(27095):     at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
09-01 14:48:23.983 E/AndroidRuntime(27095):     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)
09-01 14:48:23.983 E/AndroidRuntime(27095): Caused by: java.lang.RuntimeException: Incremental install failed.
09-01 14:48:23.983 E/AndroidRuntime(27095):     at org.chromium.incrementalinstall.BootstrapApplication.attachBaseContext(Bootstrap
Application.java:149)
09-01 14:48:23.983 E/AndroidRuntime(27095):     at android.app.Application.attach(Application.java:189)
09-01 14:48:23.983 E/AndroidRuntime(27095):     at android.app.Instrumentation.newApplication(Instrumentation.java:1102)
09-01 14:48:23.983 E/AndroidRuntime(27095):     at android.app.Instrumentation.newApplication(Instrumentation.java:1086)
09-01 14:48:23.983 E/AndroidRuntime(27095):     at android.app.LoadedApk.makeApplication(LoadedApk.java:965)
09-01 14:48:23.983 E/AndroidRuntime(27095):     ... 9 more
09-01 14:48:23.983 E/AndroidRuntime(27095): Caused by: java.io.FileNotFoundException: Dex dir does not exist: /data/local/tmp/incre
mental-app-org.chromium.chrome/dex
09-01 14:48:23.983 E/AndroidRuntime(27095):     at org.chromium.incrementalinstall.ClassLoaderPatcher.loadDexFiles(ClassLoaderPatch
er.java:52)
09-01 14:48:23.983 E/AndroidRuntime(27095):     at org.chromium.incrementalinstall.BootstrapApplication.attachBaseContext(Bootstrap
Application.java:102)
09-01 14:48:23.983 E/AndroidRuntime(27095):     ... 13 more
 

Comment 1 by awdf@chromium.org, Sep 1 2017

(This was on it's 8.0.0 OPR1.170623.005)

Someone else just got it once:
"Peter Conn (peconn@google.com)
I just built and installed ToT incremental, I got a crash the first time it tried to start, but it was successful after that"


But I get the crash every time I try to launch.

Comment 2 by awdf@chromium.org, Sep 1 2017

$ adb shell ls /data/local/tmp/incremental-app-org.chromium.chrome/dex
ls: /data/local/tmp/incremental-app-org.chromium.chrome/dex: No such file or directory


Project Member

Comment 3 by bugdroid1@chromium.org, Sep 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d902dd4d1042ddbbb62e634e975574362950f90

commit 7d902dd4d1042ddbbb62e634e975574362950f90
Author: Andrew Grieve <agrieve@chromium.org>
Date: Fri Sep 01 19:36:28 2017

apk_operations.py: Fix uninstall not clearing files cache

This was causing subsequent installs to not push enough files.

NOTRY=true  # Bots don't use these scripts

Bug:  761383 
Change-Id: I8eb9b0996a3efa4c7ee7b76a1cdd62813d332cad
Reviewed-on: https://chromium-review.googlesource.com/647476
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499260}
[modify] https://crrev.com/7d902dd4d1042ddbbb62e634e975574362950f90/build/android/apk_operations.py
[modify] https://crrev.com/7d902dd4d1042ddbbb62e634e975574362950f90/build/android/incremental_install/installer.py

Status: Fixed (was: Untriaged)

Sign in to add a comment