Issue metadata
Sign in to add a comment
|
JavaScript/FramesExtensionBindingsApiTest.FramesBeforeNavigation/0 flaky on Linux and Mac builders |
||||||||||||||||||||||||
Issue descriptionb5fbc9b2-fade-4d22-aa5a-3b757e911017 Builders failed on: - Linux Tests: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests This has failed roughly every second time on the Linux builder (https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests) since build 61589 (https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/61589) and has failed at least once on a Mac builder: https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/44554 I don't see an obvious culprit in 61589, or in the dozen or so builds before that one, so marking the test as flaky. The actual failure is a DCHECK in render_view_impl.cc:2212, in OnSetFocus: CHECK(webview()->MainFrame()->IsWebLocalFrame()); Assigning to rdevlin.cronin, as the most recent committer to touch the tests
,
Sep 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5576cda8f2c3c01d2eaed7284f6d04a74d4cc75 commit d5576cda8f2c3c01d2eaed7284f6d04a74d4cc75 Author: Ian Clelland <iclelland@google.com> Date: Fri Sep 01 15:04:34 2017 Disable flaking test FramesBeforeNavigation JavaScript/FramesExtensionBindingsApiTest.FramesBeforeNavigation has been flaky on Linux and Mac builders; marking as flaky until the issue is resolved. Bug: 761368 Change-Id: I26f08b57a654a2578f24b3f3836787da3f13075b TBR: rdevlin.cronin@chromium.org TBR: alexmos@chromium.org Reviewed-on: https://chromium-review.googlesource.com/647467 Reviewed-by: Ian Clelland <iclelland@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#499197} [modify] https://crrev.com/d5576cda8f2c3c01d2eaed7284f6d04a74d4cc75/chrome/browser/extensions/extension_bindings_apitest.cc
,
Sep 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61ed7fbb7b8d3e03e3e10d101d83608bd5bbc280 commit 61ed7fbb7b8d3e03e3e10d101d83608bd5bbc280 Author: Dave Tapuska <dtapuska@chromium.org> Date: Tue Sep 05 21:42:08 2017 Revert "Disable flaking test FramesBeforeNavigation" This reverts commit d5576cda8f2c3c01d2eaed7284f6d04a74d4cc75. Reason for revert: Actual offending change was reverted here: https://chromium-review.googlesource.com/c/chromium/src/+/647907 Original change's description: > Disable flaking test FramesBeforeNavigation > > JavaScript/FramesExtensionBindingsApiTest.FramesBeforeNavigation has > been flaky on Linux and Mac builders; marking as flaky until the issue > is resolved. > > Bug: 761368 > Change-Id: I26f08b57a654a2578f24b3f3836787da3f13075b > TBR: rdevlin.cronin@chromium.org > TBR: alexmos@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/647467 > Reviewed-by: Ian Clelland <iclelland@chromium.org> > Commit-Queue: Ian Clelland <iclelland@chromium.org> > Cr-Commit-Position: refs/heads/master@{#499197} TBR=iclelland@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 761368 Change-Id: Iceea547386768ae3fc2f0f5fa759e083ecd9c4e8 Reviewed-on: https://chromium-review.googlesource.com/651467 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#499756} [modify] https://crrev.com/61ed7fbb7b8d3e03e3e10d101d83608bd5bbc280/chrome/browser/extensions/extension_bindings_apitest.cc |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by dtapu...@chromium.org
, Sep 1 2017Status: Duplicate (was: Assigned)