track metrics about notification opt-outs |
|||||
Issue descriptionWe only track auto-opt outs in the metrics but should also track opt-outs through settings.
,
Sep 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf340a2eb631728a4ce6cbb11c060e8a72e1ae34 commit cf340a2eb631728a4ce6cbb11c060e8a72e1ae34 Author: Chris Pickel <sfiera@chromium.org> Date: Fri Sep 08 10:47:24 2017 Record histogram on notifications opt-out This metric is used only pre-O. On O, we need to look for notifications being blocked at the system level instead. Bug: 761359 Change-Id: Ia7f18a5abfc1de5b3327b5521f6821f057f3e32d Reviewed-on: https://chromium-review.googlesource.com/649106 Commit-Queue: Chris Pickel <sfiera@chromium.org> Reviewed-by: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#500560} [modify] https://crrev.com/cf340a2eb631728a4ce6cbb11c060e8a72e1ae34/chrome/browser/android/ntp/content_suggestions_notifier_service.cc
,
Sep 11 2017
Requesting merge approval for M62. This 1-liner is a metrics-only change, in a code path which is Finch-controlled and disabled by default. There's no unit test, but I've verified the change on Canary.
,
Sep 12 2017
Maybe it needs to be marked Fixed for the merge request to be picked up? It is, but I was holding off on marking it as such until it hit M62.
,
Sep 12 2017
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a80705f7419bd4948193f25fc3ad5f53b9496819 commit a80705f7419bd4948193f25fc3ad5f53b9496819 Author: Chris Pickel <sfiera@chromium.org> Date: Wed Sep 13 09:07:18 2017 Record histogram on notifications opt-out This metric is used only pre-O. On O, we need to look for notifications being blocked at the system level instead. Bug: 761359 Change-Id: Ia7f18a5abfc1de5b3327b5521f6821f057f3e32d Reviewed-on: https://chromium-review.googlesource.com/649106 Commit-Queue: Chris Pickel <sfiera@chromium.org> Reviewed-by: Peter Conn <peconn@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#500560}(cherry picked from commit cf340a2eb631728a4ce6cbb11c060e8a72e1ae34) Reviewed-on: https://chromium-review.googlesource.com/663161 Reviewed-by: Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#195} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/a80705f7419bd4948193f25fc3ad5f53b9496819/chrome/browser/android/ntp/content_suggestions_notifier_service.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by fi...@chromium.org
, Sep 4 2017