New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 761349 link

Starred by 1 user
Status: Fixed
Owner:
█ martiw@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

testAutomaticSigninPromoDismiss fails on iOS9

Project Member Reported by jif@chromium.org, Sep 1 2017 
Bookmarks_new_generation_egtest's testAutomaticSigninPromoDismiss started failing after the "Roll Chromium to 2e893e6c6fd7eeec25d2cd15ae1e2f435e6b5fc4" CL.

Error is:

../../ios/chrome/browser/ui/bookmarks/bookmarks_new_generation_egtest.mm:374: error: -[BookmarksNewGenTestCase testAutomaticSigninPromoDismiss] : Exception: NoMatchingElementException

Exception Name: NoMatchingElementException
Exception Reason: Cannot find UI element.
Exception with Action: {
  "Action Name" : "Tap",
  "Element Matcher" : "(respondsToSelector(accessibilityIdentifier) && accessibilityID('bookmark_done_button'))",
  "Recovery Suggestion" : "Check if the element exists in the UI hierarchy printed below. If it exists, adjust the matcher so that it accurately matches element."
}

Full error saved at: https://paste.googleplex.com/5731386367410176

Comment 1 by martiw@google.com, Sep 1 2017 

Thanks Jean!
I just synced but I was unable to reproduce the breakage when running the egtests on my machine.
Do you know what is the device/iOS version simulated during the break?
thx.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/244e4e334a49aa2eded25151e24fa699c2cbc0fc

commit 244e4e334a49aa2eded25151e24fa699c2cbc0fc
Author: Jean-François Geyelin <jif@chromium.org>
Date: Fri Sep 01 13:54:19 2017

Disable Bookmarks_new_generation_egtest's testAutomaticSigninPromoDismiss.

Bug:  761349 
Change-Id: Ie0a40f71a4562173e86f16b36a0b09acc0752d1f
TBR: ramyasharma
Reviewed-on: https://chromium-review.googlesource.com/647711
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Commit-Queue: Jean-François Geyelin <jif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499185}
[modify] https://crrev.com/244e4e334a49aa2eded25151e24fa699c2cbc0fc/ios/chrome/browser/ui/bookmarks/bookmarks_new_generation_egtest.mm

Comment 3 by jif@chromium.org, Sep 1 2017 

I'm sorry, I should have mentioned that.
It exclusively fails on iOS9 (test passes on iOS10 and iOS11).

Out of curiosity, do you know about the Chrome iOS waterfall?
go/chrome-ios-waterfall

Comment 4 by jif@chromium.org, Sep 1 2017

Summary: testAutomaticSigninPromoDismiss fails on iOS9 (was: testAutomaticSigninPromoDismiss fails)

Comment 5 by martiw@chromium.org, Sep 3 2017 

Thanks for the waterfall link.  I will know where to look next time.

Root cause for this bug: navigationBar's button's accessibilityID is not visible on iOS9 (although it's visible on iOS 9.3, 10, 11).

Fix is on the way.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b4b22dec8b71abf30cd1a2560bc2a955662e25f

commit 9b4b22dec8b71abf30cd1a2560bc2a955662e25f
Author: Marti Wong <martiw@chromium.org>
Date: Mon Sep 04 05:11:56 2017

Fix egtest testAutomaticSigninPromoDismiss on iOS 9.

Bug:  761349 
Change-Id: I2c8527817a062313f3b4545838db168b3aead763
Reviewed-on: https://chromium-review.googlesource.com/648827
Reviewed-by: Ramya Sharma <ramyasharma@chromium.org>
Commit-Queue: Marti Wong <martiw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499438}
[modify] https://crrev.com/9b4b22dec8b71abf30cd1a2560bc2a955662e25f/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm
[modify] https://crrev.com/9b4b22dec8b71abf30cd1a2560bc2a955662e25f/ios/chrome/browser/ui/bookmarks/bookmarks_new_generation_egtest.mm

Comment 7 by martiw@chromium.org, Sep 19 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment