New issue
Advanced search Search tips

Issue 761309 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocking:
issue 761305



Sign in to add a comment

Media Controls Redesign: Overflow menu

Project Member Reported by beccahughes@chromium.org, Sep 1 2017

Issue description

Add the overflow menu for video
 
Status: Started (was: Assigned)
Screenshot from 2017-10-17 17:11:59.png
10.4 KB View Download
Blockedon: 775539
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf74e927ed3ec0dc13bd0d4429bfffb572b67454

commit bf74e927ed3ec0dc13bd0d4429bfffb572b67454
Author: Becca Hughes <beccahughes@chromium.org>
Date: Mon Oct 30 18:38:24 2017

Media Controls: Hide controls that don't fit

Hide controls that don't fit on the new media controls based on width
and height for <video> elements and width only for <audio> elements. If
the controls cannot be shown we should show them on the overflow menu.

BUG= 761309 

Change-Id: I0c9b12f4d37a9041c27983d4de2ee94acbd3cc6c
Reviewed-on: https://chromium-review.googlesource.com/727984
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512541}
[modify] https://crrev.com/bf74e927ed3ec0dc13bd0d4429bfffb572b67454/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/bf74e927ed3ec0dc13bd0d4429bfffb572b67454/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
[modify] https://crrev.com/bf74e927ed3ec0dc13bd0d4429bfffb572b67454/third_party/WebKit/Source/modules/media_controls/elements/MediaControlDivElement.cpp
[modify] https://crrev.com/bf74e927ed3ec0dc13bd0d4429bfffb572b67454/third_party/WebKit/Source/modules/media_controls/elements/MediaControlDivElement.h
[modify] https://crrev.com/bf74e927ed3ec0dc13bd0d4429bfffb572b67454/third_party/WebKit/Source/modules/media_controls/elements/MediaControlElementBase.h
[modify] https://crrev.com/bf74e927ed3ec0dc13bd0d4429bfffb572b67454/third_party/WebKit/Source/modules/media_controls/elements/MediaControlElementsHelper.cpp
[modify] https://crrev.com/bf74e927ed3ec0dc13bd0d4429bfffb572b67454/third_party/WebKit/Source/modules/media_controls/elements/MediaControlElementsHelper.h
[modify] https://crrev.com/bf74e927ed3ec0dc13bd0d4429bfffb572b67454/third_party/WebKit/Source/modules/media_controls/elements/MediaControlInputElement.cpp
[modify] https://crrev.com/bf74e927ed3ec0dc13bd0d4429bfffb572b67454/third_party/WebKit/Source/modules/media_controls/elements/MediaControlInputElement.h
[modify] https://crrev.com/bf74e927ed3ec0dc13bd0d4429bfffb572b67454/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.cpp
[modify] https://crrev.com/bf74e927ed3ec0dc13bd0d4429bfffb572b67454/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.h

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9251fdb160237dea8a897c28dbab9097aa0c3235

commit 9251fdb160237dea8a897c28dbab9097aa0c3235
Author: Becca Hughes <beccahughes@chromium.org>
Date: Mon Oct 30 19:28:13 2017

Media Controls: Fix overflow menu and text tracks

Fix the overflow menu by aligning it with the bottom right
of the overflow menu icon. Update the text tracks menu to
spec.

BUG= 761309 

Change-Id: If4351029bf318ce3fe5a14874dc25e21b7f36a6e
Reviewed-on: https://chromium-review.googlesource.com/723474
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512576}
[modify] https://crrev.com/9251fdb160237dea8a897c28dbab9097aa0c3235/content/app/strings/content_strings.grd
[modify] https://crrev.com/9251fdb160237dea8a897c28dbab9097aa0c3235/content/child/blink_platform_impl.cc
[modify] https://crrev.com/9251fdb160237dea8a897c28dbab9097aa0c3235/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/9251fdb160237dea8a897c28dbab9097aa0c3235/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTextTrackListElement.cpp
[modify] https://crrev.com/9251fdb160237dea8a897c28dbab9097aa0c3235/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTextTrackListElement.h
[add] https://crrev.com/9251fdb160237dea8a897c28dbab9097aa0c3235/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_arrow_back.png
[add] https://crrev.com/9251fdb160237dea8a897c28dbab9097aa0c3235/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_check_blue.png
[add] https://crrev.com/9251fdb160237dea8a897c28dbab9097aa0c3235/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_arrow_back.png
[add] https://crrev.com/9251fdb160237dea8a897c28dbab9097aa0c3235/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_check_blue.png
[modify] https://crrev.com/9251fdb160237dea8a897c28dbab9097aa0c3235/third_party/WebKit/Source/modules/media_controls/resources/modernMediaControls.css
[modify] https://crrev.com/9251fdb160237dea8a897c28dbab9097aa0c3235/third_party/WebKit/public/platform/WebLocalizedString.h

Blockedon: -775539
Status: Fixed (was: Started)

Sign in to add a comment