New issue
Advanced search Search tips

Issue 761308 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocking:
issue 761305


Participants' hotlists:
Modern-Media-Controls


Sign in to add a comment

Media Controls Redesign: Loading state

Project Member Reported by beccahughes@chromium.org, Sep 1 2017

Issue description

Add the spinning loading UI
Add the "no info loaded" state
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5154c40887f29cf8a15ad0ec83137b0d6cc0cae

commit a5154c40887f29cf8a15ad0ec83137b0d6cc0cae
Author: Becca Hughes <beccahughes@chromium.org>
Date: Wed Sep 20 11:51:33 2017

Media Controls: Track controls state and reflect this in CSS.

Track the state of the controls from the parent media element
and reflect this by adding a "phase-*" and a "state-*" CSS class.

BUG= 761308 

Change-Id: Iffac365a6a17f769553b196ba86bc98e162e9d4e
Reviewed-on: https://chromium-review.googlesource.com/664799
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503114}
[modify] https://crrev.com/a5154c40887f29cf8a15ad0ec83137b0d6cc0cae/third_party/WebKit/LayoutTests/compositing/squashing/dont-squash-into-videos-expected.txt
[add] https://crrev.com/a5154c40887f29cf8a15ad0ec83137b0d6cc0cae/third_party/WebKit/LayoutTests/http/tests/media/controls/toggle-class-with-state-source-buffer.html
[add] https://crrev.com/a5154c40887f29cf8a15ad0ec83137b0d6cc0cae/third_party/WebKit/LayoutTests/http/tests/media/controls/toggle-class-with-state-source.html
[add] https://crrev.com/a5154c40887f29cf8a15ad0ec83137b0d6cc0cae/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-source-error.html
[add] https://crrev.com/a5154c40887f29cf8a15ad0ec83137b0d6cc0cae/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-source-reset.html
[modify] https://crrev.com/a5154c40887f29cf8a15ad0ec83137b0d6cc0cae/third_party/WebKit/LayoutTests/media/media-controls.js
[modify] https://crrev.com/a5154c40887f29cf8a15ad0ec83137b0d6cc0cae/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/canvas-composite-repaint-by-all-imagesource-expected.txt
[modify] https://crrev.com/a5154c40887f29cf8a15ad0ec83137b0d6cc0cae/third_party/WebKit/LayoutTests/platform/mac/compositing/video/video-poster-expected.txt
[modify] https://crrev.com/a5154c40887f29cf8a15ad0ec83137b0d6cc0cae/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/canvas-composite-repaint-by-all-imagesource-expected.txt
[modify] https://crrev.com/a5154c40887f29cf8a15ad0ec83137b0d6cc0cae/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/video-mute-repaint-expected.txt
[modify] https://crrev.com/a5154c40887f29cf8a15ad0ec83137b0d6cc0cae/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/video-unmute-repaint-expected.txt
[modify] https://crrev.com/a5154c40887f29cf8a15ad0ec83137b0d6cc0cae/third_party/WebKit/LayoutTests/platform/win/compositing/video/video-poster-expected.txt
[modify] https://crrev.com/a5154c40887f29cf8a15ad0ec83137b0d6cc0cae/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/canvas-composite-repaint-by-all-imagesource-expected.txt
[modify] https://crrev.com/a5154c40887f29cf8a15ad0ec83137b0d6cc0cae/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/video-mute-repaint-expected.txt
[modify] https://crrev.com/a5154c40887f29cf8a15ad0ec83137b0d6cc0cae/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/video-paint-invalidation-expected.txt
[modify] https://crrev.com/a5154c40887f29cf8a15ad0ec83137b0d6cc0cae/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/video-unmute-repaint-expected.txt
[modify] https://crrev.com/a5154c40887f29cf8a15ad0ec83137b0d6cc0cae/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/a5154c40887f29cf8a15ad0ec83137b0d6cc0cae/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
[modify] https://crrev.com/a5154c40887f29cf8a15ad0ec83137b0d6cc0cae/third_party/WebKit/Source/modules/media_controls/MediaControlsMediaEventListener.cpp

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50eca49dbad5eda27b6f71e762c805879000b346

commit 50eca49dbad5eda27b6f71e762c805879000b346
Author: calamity <calamity@chromium.org>
Date: Thu Sep 21 03:25:50 2017

Revert "Media Controls: Track controls state and reflect this in CSS."

This reverts commit a5154c40887f29cf8a15ad0ec83137b0d6cc0cae.

Reason for revert: Causing failures in webkit_layout_tests:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/11151
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29

Original change's description:
> Media Controls: Track controls state and reflect this in CSS.
> 
> Track the state of the controls from the parent media element
> and reflect this by adding a "phase-*" and a "state-*" CSS class.
> 
> BUG= 761308 
> 
> Change-Id: Iffac365a6a17f769553b196ba86bc98e162e9d4e
> Reviewed-on: https://chromium-review.googlesource.com/664799
> Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#503114}

TBR=mlamouri@chromium.org,beccahughes@chromium.org

Change-Id: I3ab84ef17034714916b06b3944b710d93818793d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  761308 
Reviewed-on: https://chromium-review.googlesource.com/676783
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503344}
[modify] https://crrev.com/50eca49dbad5eda27b6f71e762c805879000b346/third_party/WebKit/LayoutTests/compositing/squashing/dont-squash-into-videos-expected.txt
[delete] https://crrev.com/42161623ec7697ced713dfe309d8db1c68be1b27/third_party/WebKit/LayoutTests/http/tests/media/controls/toggle-class-with-state-source-buffer.html
[delete] https://crrev.com/42161623ec7697ced713dfe309d8db1c68be1b27/third_party/WebKit/LayoutTests/http/tests/media/controls/toggle-class-with-state-source.html
[delete] https://crrev.com/42161623ec7697ced713dfe309d8db1c68be1b27/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-source-error.html
[delete] https://crrev.com/42161623ec7697ced713dfe309d8db1c68be1b27/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-source-reset.html
[modify] https://crrev.com/50eca49dbad5eda27b6f71e762c805879000b346/third_party/WebKit/LayoutTests/media/media-controls.js
[modify] https://crrev.com/50eca49dbad5eda27b6f71e762c805879000b346/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/canvas-composite-repaint-by-all-imagesource-expected.txt
[modify] https://crrev.com/50eca49dbad5eda27b6f71e762c805879000b346/third_party/WebKit/LayoutTests/platform/mac/compositing/video/video-poster-expected.txt
[modify] https://crrev.com/50eca49dbad5eda27b6f71e762c805879000b346/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/canvas-composite-repaint-by-all-imagesource-expected.txt
[modify] https://crrev.com/50eca49dbad5eda27b6f71e762c805879000b346/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/video-mute-repaint-expected.txt
[modify] https://crrev.com/50eca49dbad5eda27b6f71e762c805879000b346/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/video-unmute-repaint-expected.txt
[modify] https://crrev.com/50eca49dbad5eda27b6f71e762c805879000b346/third_party/WebKit/LayoutTests/platform/win/compositing/video/video-poster-expected.txt
[modify] https://crrev.com/50eca49dbad5eda27b6f71e762c805879000b346/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/canvas-composite-repaint-by-all-imagesource-expected.txt
[modify] https://crrev.com/50eca49dbad5eda27b6f71e762c805879000b346/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/video-mute-repaint-expected.txt
[modify] https://crrev.com/50eca49dbad5eda27b6f71e762c805879000b346/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/video-paint-invalidation-expected.txt
[modify] https://crrev.com/50eca49dbad5eda27b6f71e762c805879000b346/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/video-unmute-repaint-expected.txt
[modify] https://crrev.com/50eca49dbad5eda27b6f71e762c805879000b346/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/50eca49dbad5eda27b6f71e762c805879000b346/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
[modify] https://crrev.com/50eca49dbad5eda27b6f71e762c805879000b346/third_party/WebKit/Source/modules/media_controls/MediaControlsMediaEventListener.cpp

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9b071354e64f5f338de6893def6d9d5ae14c110

commit b9b071354e64f5f338de6893def6d9d5ae14c110
Author: Becca Hughes <beccahughes@chromium.org>
Date: Fri Sep 22 12:33:19 2017

[Resubmit] Media Controls: Track controls state and reflect this in CSS.

Track the state of the controls from the parent media element
and reflect this by adding a "phase-*" and a "state-*" CSS class.
This is a resubmit of crrev.com/c/664799.

BUG= 761308 

Change-Id: I134dc78301888be9ff8b314ca38371d69ab2c88c
Reviewed-on: https://chromium-review.googlesource.com/676850
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503720}
[modify] https://crrev.com/b9b071354e64f5f338de6893def6d9d5ae14c110/third_party/WebKit/LayoutTests/compositing/squashing/dont-squash-into-videos-expected.txt
[add] https://crrev.com/b9b071354e64f5f338de6893def6d9d5ae14c110/third_party/WebKit/LayoutTests/http/tests/media/controls/toggle-class-with-state-source-buffer.html
[add] https://crrev.com/b9b071354e64f5f338de6893def6d9d5ae14c110/third_party/WebKit/LayoutTests/http/tests/media/controls/toggle-class-with-state-source.html
[add] https://crrev.com/b9b071354e64f5f338de6893def6d9d5ae14c110/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-source-error.html
[add] https://crrev.com/b9b071354e64f5f338de6893def6d9d5ae14c110/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-source-reset.html
[modify] https://crrev.com/b9b071354e64f5f338de6893def6d9d5ae14c110/third_party/WebKit/LayoutTests/media/media-controls.js
[modify] https://crrev.com/b9b071354e64f5f338de6893def6d9d5ae14c110/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/canvas-composite-repaint-by-all-imagesource-expected.txt
[modify] https://crrev.com/b9b071354e64f5f338de6893def6d9d5ae14c110/third_party/WebKit/LayoutTests/platform/mac/compositing/video/video-poster-expected.txt
[modify] https://crrev.com/b9b071354e64f5f338de6893def6d9d5ae14c110/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/canvas-composite-repaint-by-all-imagesource-expected.txt
[modify] https://crrev.com/b9b071354e64f5f338de6893def6d9d5ae14c110/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/video-mute-repaint-expected.txt
[modify] https://crrev.com/b9b071354e64f5f338de6893def6d9d5ae14c110/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/video-unmute-repaint-expected.txt
[modify] https://crrev.com/b9b071354e64f5f338de6893def6d9d5ae14c110/third_party/WebKit/LayoutTests/platform/win/compositing/video/video-poster-expected.txt
[modify] https://crrev.com/b9b071354e64f5f338de6893def6d9d5ae14c110/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/canvas-composite-repaint-by-all-imagesource-expected.txt
[modify] https://crrev.com/b9b071354e64f5f338de6893def6d9d5ae14c110/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/video-mute-repaint-expected.txt
[modify] https://crrev.com/b9b071354e64f5f338de6893def6d9d5ae14c110/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/video-paint-invalidation-expected.txt
[modify] https://crrev.com/b9b071354e64f5f338de6893def6d9d5ae14c110/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/video-unmute-repaint-expected.txt
[modify] https://crrev.com/b9b071354e64f5f338de6893def6d9d5ae14c110/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/b9b071354e64f5f338de6893def6d9d5ae14c110/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
[modify] https://crrev.com/b9b071354e64f5f338de6893def6d9d5ae14c110/third_party/WebKit/Source/modules/media_controls/MediaControlsMediaEventListener.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb1914ca2fbcebbf801c854fd58a0b7651f7bc70

commit eb1914ca2fbcebbf801c854fd58a0b7651f7bc70
Author: Jesse Doherty <jwd@chromium.org>
Date: Fri Sep 22 16:10:23 2017

Revert "[Resubmit] Media Controls: Track controls state and reflect this in CSS."

This reverts commit b9b071354e64f5f338de6893def6d9d5ae14c110.

Reason for revert: Looks like it could still be causing a failure in virtual/gpu/fast/canvas/canvas-drawImage-live-video.html
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/11190

Original change's description:
> [Resubmit] Media Controls: Track controls state and reflect this in CSS.
> 
> Track the state of the controls from the parent media element
> and reflect this by adding a "phase-*" and a "state-*" CSS class.
> This is a resubmit of crrev.com/c/664799.
> 
> BUG= 761308 
> 
> Change-Id: I134dc78301888be9ff8b314ca38371d69ab2c88c
> Reviewed-on: https://chromium-review.googlesource.com/676850
> Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#503720}

TBR=mlamouri@chromium.org,beccahughes@chromium.org

Change-Id: Ibe354975122e85b2bec6871c3a38ad66c245460e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  761308 
Reviewed-on: https://chromium-review.googlesource.com/678123
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503756}
[modify] https://crrev.com/eb1914ca2fbcebbf801c854fd58a0b7651f7bc70/third_party/WebKit/LayoutTests/compositing/squashing/dont-squash-into-videos-expected.txt
[delete] https://crrev.com/40d02904f5ee153daa2d5cd666ccfdf2756687ce/third_party/WebKit/LayoutTests/http/tests/media/controls/toggle-class-with-state-source-buffer.html
[delete] https://crrev.com/40d02904f5ee153daa2d5cd666ccfdf2756687ce/third_party/WebKit/LayoutTests/http/tests/media/controls/toggle-class-with-state-source.html
[delete] https://crrev.com/40d02904f5ee153daa2d5cd666ccfdf2756687ce/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-source-error.html
[delete] https://crrev.com/40d02904f5ee153daa2d5cd666ccfdf2756687ce/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-source-reset.html
[modify] https://crrev.com/eb1914ca2fbcebbf801c854fd58a0b7651f7bc70/third_party/WebKit/LayoutTests/media/media-controls.js
[modify] https://crrev.com/eb1914ca2fbcebbf801c854fd58a0b7651f7bc70/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/canvas-composite-repaint-by-all-imagesource-expected.txt
[modify] https://crrev.com/eb1914ca2fbcebbf801c854fd58a0b7651f7bc70/third_party/WebKit/LayoutTests/platform/mac/compositing/video/video-poster-expected.txt
[modify] https://crrev.com/eb1914ca2fbcebbf801c854fd58a0b7651f7bc70/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/canvas-composite-repaint-by-all-imagesource-expected.txt
[modify] https://crrev.com/eb1914ca2fbcebbf801c854fd58a0b7651f7bc70/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/video-mute-repaint-expected.txt
[modify] https://crrev.com/eb1914ca2fbcebbf801c854fd58a0b7651f7bc70/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/video-unmute-repaint-expected.txt
[modify] https://crrev.com/eb1914ca2fbcebbf801c854fd58a0b7651f7bc70/third_party/WebKit/LayoutTests/platform/win/compositing/video/video-poster-expected.txt
[modify] https://crrev.com/eb1914ca2fbcebbf801c854fd58a0b7651f7bc70/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/canvas-composite-repaint-by-all-imagesource-expected.txt
[modify] https://crrev.com/eb1914ca2fbcebbf801c854fd58a0b7651f7bc70/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/video-mute-repaint-expected.txt
[modify] https://crrev.com/eb1914ca2fbcebbf801c854fd58a0b7651f7bc70/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/video-paint-invalidation-expected.txt
[modify] https://crrev.com/eb1914ca2fbcebbf801c854fd58a0b7651f7bc70/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/video-unmute-repaint-expected.txt
[modify] https://crrev.com/eb1914ca2fbcebbf801c854fd58a0b7651f7bc70/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/eb1914ca2fbcebbf801c854fd58a0b7651f7bc70/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
[modify] https://crrev.com/eb1914ca2fbcebbf801c854fd58a0b7651f7bc70/third_party/WebKit/Source/modules/media_controls/MediaControlsMediaEventListener.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c4dcf5f0cf317d83686ff2ee223a3ae2842c606

commit 0c4dcf5f0cf317d83686ff2ee223a3ae2842c606
Author: Becca Hughes <beccahughes@chromium.org>
Date: Sun Sep 24 10:18:03 2017

Reland "[Resubmit] Media Controls: Track controls state and reflect this in CSS."

This is a reland of b9b071354e64f5f338de6893def6d9d5ae14c110
Original change's description:
> [Resubmit] Media Controls: Track controls state and reflect this in CSS.
> 
> Track the state of the controls from the parent media element
> and reflect this by adding a "phase-*" and a "state-*" CSS class.
> This is a resubmit of crrev.com/c/664799.
> 
> BUG= 761308 
> 
> Change-Id: I134dc78301888be9ff8b314ca38371d69ab2c88c
> Reviewed-on: https://chromium-review.googlesource.com/676850
> Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#503720}

TBR=mlamouri

Bug:  761308 
Change-Id: I9eb5656829b4bc279d53d18e79284c67d7ed5447
Reviewed-on: https://chromium-review.googlesource.com/679354
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503955}
[modify] https://crrev.com/0c4dcf5f0cf317d83686ff2ee223a3ae2842c606/third_party/WebKit/LayoutTests/compositing/squashing/dont-squash-into-videos-expected.txt
[add] https://crrev.com/0c4dcf5f0cf317d83686ff2ee223a3ae2842c606/third_party/WebKit/LayoutTests/http/tests/media/controls/toggle-class-with-state-source-buffer.html
[add] https://crrev.com/0c4dcf5f0cf317d83686ff2ee223a3ae2842c606/third_party/WebKit/LayoutTests/http/tests/media/controls/toggle-class-with-state-source.html
[add] https://crrev.com/0c4dcf5f0cf317d83686ff2ee223a3ae2842c606/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-source-error.html
[add] https://crrev.com/0c4dcf5f0cf317d83686ff2ee223a3ae2842c606/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-source-reset.html
[modify] https://crrev.com/0c4dcf5f0cf317d83686ff2ee223a3ae2842c606/third_party/WebKit/LayoutTests/media/media-controls.js
[modify] https://crrev.com/0c4dcf5f0cf317d83686ff2ee223a3ae2842c606/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/canvas-composite-repaint-by-all-imagesource-expected.txt
[modify] https://crrev.com/0c4dcf5f0cf317d83686ff2ee223a3ae2842c606/third_party/WebKit/LayoutTests/platform/mac/compositing/video/video-poster-expected.txt
[modify] https://crrev.com/0c4dcf5f0cf317d83686ff2ee223a3ae2842c606/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/canvas-composite-repaint-by-all-imagesource-expected.txt
[modify] https://crrev.com/0c4dcf5f0cf317d83686ff2ee223a3ae2842c606/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/video-mute-repaint-expected.txt
[modify] https://crrev.com/0c4dcf5f0cf317d83686ff2ee223a3ae2842c606/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/video-unmute-repaint-expected.txt
[modify] https://crrev.com/0c4dcf5f0cf317d83686ff2ee223a3ae2842c606/third_party/WebKit/LayoutTests/platform/win/compositing/video/video-poster-expected.txt
[modify] https://crrev.com/0c4dcf5f0cf317d83686ff2ee223a3ae2842c606/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/canvas-composite-repaint-by-all-imagesource-expected.txt
[modify] https://crrev.com/0c4dcf5f0cf317d83686ff2ee223a3ae2842c606/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/video-mute-repaint-expected.txt
[modify] https://crrev.com/0c4dcf5f0cf317d83686ff2ee223a3ae2842c606/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/video-paint-invalidation-expected.txt
[modify] https://crrev.com/0c4dcf5f0cf317d83686ff2ee223a3ae2842c606/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/video-unmute-repaint-expected.txt
[modify] https://crrev.com/0c4dcf5f0cf317d83686ff2ee223a3ae2842c606/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/0c4dcf5f0cf317d83686ff2ee223a3ae2842c606/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
[modify] https://crrev.com/0c4dcf5f0cf317d83686ff2ee223a3ae2842c606/third_party/WebKit/Source/modules/media_controls/MediaControlsMediaEventListener.cpp

Status: Started (was: Assigned)
This is the "use-default-poster" state
Screenshot from 2017-10-23 13:40:20.png
6.6 KB View Download
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/862095d456a4ec829ec896ab1f69c56d05428894

commit 862095d456a4ec829ec896ab1f69c56d05428894
Author: Becca Hughes <beccahughes@chromium.org>
Date: Tue Oct 24 19:41:08 2017

Media Controls: Add dashed buffering animation.

Add a dashed buffering animation when the media is buffering. Also
adds a local <style> element to the timeline shadow DOM with it's
own stylesheet since animations are not supported in the UA
stylesheet.

BUG= 761308 

Change-Id: Ic1ff3d826d13f954ddf1d56164eb07e31698bb16
Reviewed-on: https://chromium-review.googlesource.com/730983
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511239}
[modify] https://crrev.com/862095d456a4ec829ec896ab1f69c56d05428894/third_party/WebKit/Source/modules/media_controls/MediaControlsResourceLoader.cpp
[modify] https://crrev.com/862095d456a4ec829ec896ab1f69c56d05428894/third_party/WebKit/Source/modules/media_controls/MediaControlsResourceLoader.h
[modify] https://crrev.com/862095d456a4ec829ec896ab1f69c56d05428894/third_party/WebKit/Source/modules/media_controls/elements/MediaControlSliderElement.cpp
[modify] https://crrev.com/862095d456a4ec829ec896ab1f69c56d05428894/third_party/WebKit/Source/modules/media_controls/elements/MediaControlSliderElement.h
[modify] https://crrev.com/862095d456a4ec829ec896ab1f69c56d05428894/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.cpp
[modify] https://crrev.com/862095d456a4ec829ec896ab1f69c56d05428894/third_party/WebKit/Source/modules/media_controls/resources/media_controls_resources.grd
[modify] https://crrev.com/862095d456a4ec829ec896ab1f69c56d05428894/third_party/WebKit/Source/modules/media_controls/resources/modernMediaControls.css
[add] https://crrev.com/862095d456a4ec829ec896ab1f69c56d05428894/third_party/WebKit/Source/modules/media_controls/resources/modernMediaControls_timeline.css

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/054e29c3b61c5d23272f2617af7d9516e47ef5d3

commit 054e29c3b61c5d23272f2617af7d9516e47ef5d3
Author: Becca Hughes <beccahughes@chromium.org>
Date: Tue Oct 31 18:34:46 2017

Media Controls: Add "use-default-poster" state

Add a "use-default-poster" CSS class and add it if the video
element does not have a video frame or poster to display. As
per the spec then hide the controls apart from the play button
and display a gradient background.

BUG= 761308 

Change-Id: I579a1be27ecdb375e770b2fbc841593f7ce2abc3
Reviewed-on: https://chromium-review.googlesource.com/733092
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512884}
[modify] https://crrev.com/054e29c3b61c5d23272f2617af7d9516e47ef5d3/third_party/WebKit/LayoutTests/compositing/squashing/dont-squash-into-videos-expected.txt
[modify] https://crrev.com/054e29c3b61c5d23272f2617af7d9516e47ef5d3/third_party/WebKit/LayoutTests/http/tests/media/controls/toggle-class-with-state-source-buffer.html
[modify] https://crrev.com/054e29c3b61c5d23272f2617af7d9516e47ef5d3/third_party/WebKit/LayoutTests/http/tests/media/controls/toggle-class-with-state-source.html
[add] https://crrev.com/054e29c3b61c5d23272f2617af7d9516e47ef5d3/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-poster-frame.html
[add] https://crrev.com/054e29c3b61c5d23272f2617af7d9516e47ef5d3/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-poster-image.html
[modify] https://crrev.com/054e29c3b61c5d23272f2617af7d9516e47ef5d3/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-source-error.html
[modify] https://crrev.com/054e29c3b61c5d23272f2617af7d9516e47ef5d3/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-source-reset.html
[add] https://crrev.com/054e29c3b61c5d23272f2617af7d9516e47ef5d3/third_party/WebKit/LayoutTests/media/controls/toggle-class-without-poster.html
[modify] https://crrev.com/054e29c3b61c5d23272f2617af7d9516e47ef5d3/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/054e29c3b61c5d23272f2617af7d9516e47ef5d3/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
[modify] https://crrev.com/054e29c3b61c5d23272f2617af7d9516e47ef5d3/third_party/WebKit/Source/modules/media_controls/MediaControlsMediaEventListener.cpp
[modify] https://crrev.com/054e29c3b61c5d23272f2617af7d9516e47ef5d3/third_party/WebKit/Source/modules/media_controls/resources/modernMediaControls.css

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bec0814edf747a09930741458d3b820426bd5037

commit bec0814edf747a09930741458d3b820426bd5037
Author: Becca Hughes <beccahughes@chromium.org>
Date: Mon Nov 06 17:58:46 2017

Media Controls: Add a spinning loading panel

Add a semi-transparent loading panel that uses mask effects to show a
loading spinner that has transparent.

BUG= 761308 

Change-Id: I74e84c5c71f4090ce25dae2e43b968603699a539
Reviewed-on: https://chromium-review.googlesource.com/749145
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514170}
[modify] https://crrev.com/bec0814edf747a09930741458d3b820426bd5037/third_party/WebKit/Source/core/html/media/HTMLMediaElement.h
[modify] https://crrev.com/bec0814edf747a09930741458d3b820426bd5037/third_party/WebKit/Source/modules/BUILD.gn
[modify] https://crrev.com/bec0814edf747a09930741458d3b820426bd5037/third_party/WebKit/Source/modules/media_controls/BUILD.gn
[modify] https://crrev.com/bec0814edf747a09930741458d3b820426bd5037/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/bec0814edf747a09930741458d3b820426bd5037/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
[modify] https://crrev.com/bec0814edf747a09930741458d3b820426bd5037/third_party/WebKit/Source/modules/media_controls/MediaControlsResourceLoader.cpp
[modify] https://crrev.com/bec0814edf747a09930741458d3b820426bd5037/third_party/WebKit/Source/modules/media_controls/MediaControlsResourceLoader.h
[modify] https://crrev.com/bec0814edf747a09930741458d3b820426bd5037/third_party/WebKit/Source/modules/media_controls/elements/MediaControlElementsHelper.cpp
[modify] https://crrev.com/bec0814edf747a09930741458d3b820426bd5037/third_party/WebKit/Source/modules/media_controls/elements/MediaControlElementsHelper.h
[add] https://crrev.com/bec0814edf747a09930741458d3b820426bd5037/third_party/WebKit/Source/modules/media_controls/elements/MediaControlLoadingPanelElement.cpp
[add] https://crrev.com/bec0814edf747a09930741458d3b820426bd5037/third_party/WebKit/Source/modules/media_controls/elements/MediaControlLoadingPanelElement.h
[add] https://crrev.com/bec0814edf747a09930741458d3b820426bd5037/third_party/WebKit/Source/modules/media_controls/elements/MediaControlLoadingPanelElementTest.cpp
[add] https://crrev.com/bec0814edf747a09930741458d3b820426bd5037/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/loading_mask_1.svg
[add] https://crrev.com/bec0814edf747a09930741458d3b820426bd5037/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/loading_mask_2.svg
[add] https://crrev.com/bec0814edf747a09930741458d3b820426bd5037/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/loading_mask_overlay.svg
[modify] https://crrev.com/bec0814edf747a09930741458d3b820426bd5037/third_party/WebKit/Source/modules/media_controls/resources/media_controls_resources.grd
[modify] https://crrev.com/bec0814edf747a09930741458d3b820426bd5037/third_party/WebKit/Source/modules/media_controls/resources/modernMediaControls.css
[add] https://crrev.com/bec0814edf747a09930741458d3b820426bd5037/third_party/WebKit/Source/modules/media_controls/resources/modernMediaControls_loading.css

Status: Fixed (was: Started)

Sign in to add a comment