New issue
Advanced search Search tips

Issue 761306 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocking:
issue 761305



Sign in to add a comment

Media Controls Redesign: Move HTML elements around

Project Member Reported by beccahughes@chromium.org, Sep 1 2017

Issue description

Move HTML elements around based on new design
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29ffeaf8e23c35e0ae2f1a265a394e20f3c7ceb1

commit 29ffeaf8e23c35e0ae2f1a265a394e20f3c7ceb1
Author: Becca Hughes <beccahughes@chromium.org>
Date: Mon Oct 02 15:50:48 2017

Media Controls: Adjust HTML layout and add background.

As per the design for the new media controls, adjust the HTML
layout to move the timeline to below and hide the play button.
Moves over and tweaks some CSS rules for basic layout
(still very rough!) and add the gradient background. Disable
overflow for the time being too.

BUG= 761306 

Change-Id: I08db3ab2bdbb0681945bec27dcc8c558754e36e7
Reviewed-on: https://chromium-review.googlesource.com/647852
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505625}
[modify] https://crrev.com/29ffeaf8e23c35e0ae2f1a265a394e20f3c7ceb1/third_party/WebKit/LayoutTests/paint/invalidation/video-mute-repaint-expected.txt
[modify] https://crrev.com/29ffeaf8e23c35e0ae2f1a265a394e20f3c7ceb1/third_party/WebKit/LayoutTests/paint/invalidation/video-unmute-repaint-expected.txt
[modify] https://crrev.com/29ffeaf8e23c35e0ae2f1a265a394e20f3c7ceb1/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/29ffeaf8e23c35e0ae2f1a265a394e20f3c7ceb1/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
[modify] https://crrev.com/29ffeaf8e23c35e0ae2f1a265a394e20f3c7ceb1/third_party/WebKit/Source/modules/media_controls/elements/MediaControlSliderElement.cpp
[modify] https://crrev.com/29ffeaf8e23c35e0ae2f1a265a394e20f3c7ceb1/third_party/WebKit/Source/modules/media_controls/resources/legacyMediaControls.css
[modify] https://crrev.com/29ffeaf8e23c35e0ae2f1a265a394e20f3c7ceb1/third_party/WebKit/Source/modules/media_controls/resources/modernMediaControls.css

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bd45e835cb1512fdb3b24699c878ec5d3695f13

commit 9bd45e835cb1512fdb3b24699c878ec5d3695f13
Author: Becca Hughes <beccahughes@chromium.org>
Date: Tue Oct 24 15:26:31 2017

Media Controls: Add new elements for modern controls.

Add a button panel element to hold the buttons, a modern play button
element and a button spacer element (to take up spare horizontal space
if the video element is quite big).

BUG= 761306 

Change-Id: Ie613efd0f52f1de165cec78ba56165e71d97b533
Reviewed-on: https://chromium-review.googlesource.com/727898
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511156}
[modify] https://crrev.com/9bd45e835cb1512fdb3b24699c878ec5d3695f13/third_party/WebKit/Source/modules/media_controls/BUILD.gn
[modify] https://crrev.com/9bd45e835cb1512fdb3b24699c878ec5d3695f13/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/9bd45e835cb1512fdb3b24699c878ec5d3695f13/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
[add] https://crrev.com/9bd45e835cb1512fdb3b24699c878ec5d3695f13/third_party/WebKit/Source/modules/media_controls/elements/MediaControlButtonPanelElement.cpp
[add] https://crrev.com/9bd45e835cb1512fdb3b24699c878ec5d3695f13/third_party/WebKit/Source/modules/media_controls/elements/MediaControlButtonPanelElement.h
[modify] https://crrev.com/9bd45e835cb1512fdb3b24699c878ec5d3695f13/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.cpp
[modify] https://crrev.com/9bd45e835cb1512fdb3b24699c878ec5d3695f13/tools/metrics/actions/actions.xml

Status: Fixed (was: Started)

Sign in to add a comment