Redesign the media controls parent task.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30b2c8985a331f19c2ceb9142cff37489aa60e7d commit 30b2c8985a331f19c2ceb9142cff37489aa60e7d Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Oct 19 18:02:24 2017 Media Controls: Refactor div creation Creation of <div>'s is a repeated part of the media controls so this refactors it into a single function (there are more uses of the function coming). BUG= 761305 Change-Id: If3530a416fd6f169100072899fbe3fcfb159155a Reviewed-on: https://chromium-review.googlesource.com/727897 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#510137} [modify] https://crrev.com/30b2c8985a331f19c2ceb9142cff37489aa60e7d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlElementsHelper.cpp [modify] https://crrev.com/30b2c8985a331f19c2ceb9142cff37489aa60e7d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlElementsHelper.h [modify] https://crrev.com/30b2c8985a331f19c2ceb9142cff37489aa60e7d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlSliderElement.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25597e7f2ed7695885641079f49efbbdf9440934 commit 25597e7f2ed7695885641079f49efbbdf9440934 Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Oct 26 12:33:22 2017 Media Controls: Remove duplicate IsModern Remove duplicate IsModern functions. BUG= 761305 Change-Id: I86b21262797c1ea0d049c7afb66a32835052f8cd Reviewed-on: https://chromium-review.googlesource.com/738201 Reviewed-by: Daniel Bratell <bratell@opera.com> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#511794} [modify] https://crrev.com/25597e7f2ed7695885641079f49efbbdf9440934/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp [modify] https://crrev.com/25597e7f2ed7695885641079f49efbbdf9440934/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h [modify] https://crrev.com/25597e7f2ed7695885641079f49efbbdf9440934/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.cpp [modify] https://crrev.com/25597e7f2ed7695885641079f49efbbdf9440934/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59c05b432b0def6dc11cb2865eb60721f1d94768 commit 59c05b432b0def6dc11cb2865eb60721f1d94768 Author: Becca Hughes <beccahughes@chromium.org> Date: Fri Nov 03 13:11:58 2017 Media Controls: Add the feature flag to chrome://flags Add the UseModernMediaControls feature flag to chrome://flags. BUG= 761305 Change-Id: I2f6bf9abf05d1256b9dab5fd444d1a8c7ccbbcd8 Reviewed-on: https://chromium-review.googlesource.com/698064 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#513756} [modify] https://crrev.com/59c05b432b0def6dc11cb2865eb60721f1d94768/chrome/browser/about_flags.cc [modify] https://crrev.com/59c05b432b0def6dc11cb2865eb60721f1d94768/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/59c05b432b0def6dc11cb2865eb60721f1d94768/chrome/browser/flag_descriptions.h [modify] https://crrev.com/59c05b432b0def6dc11cb2865eb60721f1d94768/tools/metrics/histograms/enums.xml
Comment 1 by beccahughes@chromium.org
, Sep 1 2017