Issue metadata
Sign in to add a comment
|
If the user enters into full screen mode, then there is no option found to close the window. Instead a grey patch is displayed. |
||||||||||||||||||||||
Issue descriptionChrome Version: 62.0.3202.0 OS: Mac 10.12.6 What steps will reproduce the problem? (1) Launch Chrome. (2) Open New Tab Page. (3) Pull the tab out of window, to create a new window. (4) Open the window in full screen mode. (5) Try to come out of full screen mode. (Attached screencast for reference) What is the expected result? Minimize, Close and exit full screen mode buttons should be displayed. What happens instead? A grey patch is displayed and user is not able to close the window. Note: 1. User Can close newly opened window by performing keyboard action Command+w. 2. Issue is not reproduced on Windows and Linux. Using the per-revision bisect providing the bisect results, Good build: 62.0.3186.0 (494273) Bad build: 62.0.3187.0 (494644) You are probably looking for a change made after 494276 (known good), but no later than 494277 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/b19e47c1f362bd042d2d2985a39d906683d36f33..ec48b797b4081fac96bc33a4f0bfd281bfb3c682 From the CL above, assigning the issue to the concern owner @sdy: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Review-URL: https://chromium-review.googlesource.com/c/chromium/src/+/614087
,
Sep 5 2017
Can we get an update on this issue as this is marked as Dev blocker for next M-62 Dev release.
,
Sep 5 2017
Investigating.
,
Sep 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3376db51b6694589524ee6ab7787c532ee327d31 commit 3376db51b6694589524ee6ab7787c532ee327d31 Author: Sidney San Martín <sdy@chromium.org> Date: Tue Sep 05 17:25:46 2017 Fix view order in windows created by dragging out a tab. This fixes crbug/761294 (missing tab strip when fullscreening a window that was just dragged out of another window). The view order is now actually the same before and after a drag, but this code is still somewhat brittle and it would be great to simplify at some point. Bug: 761294 Change-Id: Ibe9e86a858a4cf16f542e70c52c0080c32bda7c7 Reviewed-on: https://chromium-review.googlesource.com/650646 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#499661} [modify] https://crrev.com/3376db51b6694589524ee6ab7787c532ee327d31/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm
,
Sep 5 2017
,
Sep 6 2017
Tested the issue on Mac 10.12.6 using Chrome version M62 - 63.0.3207.0 as per the issue mentioned in original comment. Observed that issue is working as intended (Grey patch is not displayed on the header and user is able to come out of fullscreen mode if user opens a new tab in fullscreen). Hence adding TE-Verified label. Attached the screencast for reference. Thank you!
,
Oct 18 2017
Not sure, why we didn't merge this fix to M62 branch though it's clearly regressed there? Now it exists on M62 stable chrome#62.0.3202.62.
,
Oct 18 2017
Issue 775774 has been merged into this issue.
,
Oct 18 2017
,
Oct 18 2017
This a bad regression and thanks for the fix. We'll look into why this wasn't merged in to M62 and why Merge TBD labels didn't apply. Can you please raise a merge request for M62? I think this is a critical enough regression which requires a respin.
,
Oct 18 2017
,
Oct 18 2017
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 18 2017
Approving merge to M62. Can you please merge it to branch 3202?
,
Oct 19 2017
Issue 775357 has been merged into this issue.
,
Oct 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d91f8f1881c2c7716853de929fa9445d809dfcbb commit d91f8f1881c2c7716853de929fa9445d809dfcbb Author: Sidney San Martín <sdy@chromium.org> Date: Thu Oct 19 18:30:31 2017 Fix view order in windows created by dragging out a tab. This fixes crbug/761294 (missing tab strip when fullscreening a window that was just dragged out of another window). The view order is now actually the same before and after a drag, but this code is still somewhat brittle and it would be great to simplify at some point. TBR=sdy@chromium.org (cherry picked from commit 3376db51b6694589524ee6ab7787c532ee327d31) Bug: 761294 Change-Id: Ibe9e86a858a4cf16f542e70c52c0080c32bda7c7 Reviewed-on: https://chromium-review.googlesource.com/650646 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499661} Reviewed-on: https://chromium-review.googlesource.com/728819 Reviewed-by: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#717} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/d91f8f1881c2c7716853de929fa9445d809dfcbb/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm
,
Oct 19 2017
So it is the case that this regression in M62 Stable happened because we missed a cherry-pick? Also, sdy@ are you the right person to write the post mortem?
,
Oct 19 2017
I'm genuinely not sure, this is new territory for me. I think that, in the past, bugs like this automatically got flagged for a merge (which I think abdulsyed@ was referring to in #10), so I wasn't paying attention — but I probably *should* have been paying attention. abdulsyed@, what do you think?
,
Oct 19 2017
Thanks sdy@ for merge and agree that this was a process issue. I can write a mini-postmortem for this. Shrike@ crbug/776162 with more info. We have a process script that we rely on to catch all fixes for a milestone that have landed after branch date, and mark those bugs with a 'Merge-TBD' label. It's an old script (4+ years), and for some reason, it was excluding bugs that are marked as RB-Dev. I've fixed the script. However, I think it'd be great to think of more ways to ensure no missed merges.
,
Oct 19 2017
OK, thanks for the explanation abdulsyed@. It seems like the underlying process issue is understood and has been address.
,
Oct 20 2017
,
Oct 20 2017
Issue 776654 has been merged into this issue.
,
Oct 21 2017
Issue 777082 has been merged into this issue.
,
Oct 21 2017
Issue 777099 has been merged into this issue.
,
Oct 25 2017
Issue 778210 has been merged into this issue.
,
Oct 25 2017
Issue 778346 has been merged into this issue.
,
Oct 25 2017
So, when actual fix will be deployed to end users? Is there any ETA? I am still experiencing that issue (which is very annoying).
,
Oct 25 2017
We are aiming for an M62 respin this week with this fix included, which will resolve this issue.
,
Oct 26 2017
Great, thanks.
,
Oct 26 2017
Tested this issue on Mac 10.12.6 on Chrome#62.0.3202.75 as per the original comment and observed that user is able to restore window after opening the new tab in fullscreen mode. Hence adding TE-Verified labels. Please find the attached screencast for reference. Thanks..!
,
Oct 26 2017
Issue 778151 has been merged into this issue.
,
Oct 26 2017
,
Oct 27 2017
Issue 779082 has been merged into this issue.
,
Nov 2 2017
> OK, thanks for the explanation abdulsyed@. It seems like the underlying process issue is understood and has been address. I was agreeing here with not needing to write a PM but I think we should put on together anyway. abdulsyed@, would you be the right person to write it or should it be sdy@?
,
Nov 3 2017
go/chromepostmortem546 - I've started this. Please take a look and add any other relevant details.
,
Nov 5 2017
Issue 781556 has been merged into this issue.
,
Nov 8 2017
Assigning the PM to sdy@.
,
Jan 15 2018
I'm still having this problem with Chrome Version 63.0.3239.132 (official Build) (64-Bit) & OSX 10.11.6
,
Jan 15 2018
BTW: My original Issue (https://bugs.chromium.org/p/chromium/issues/detail?id=778151#c6) was merges with this one - but I'm not sure if these Issues are the same. I however am having problems after having eg. some youtube-video fullscreen. After that my url-bar is half grayed-out (see screenshot attached to 778151 for details.)
,
Apr 30 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by gov...@chromium.org
, Sep 1 2017