Non-Regression : 'No search results found' message is seen missing in Printers page |
|||||
Issue descriptionChrome Version: 62.0.3201.0/9900.0.0 dev-channel Peppy,Reks & Candy OS: Chrome What steps will reproduce the problem? (1)Sign into User -> Go to chrome://settings page-> At 'Printing' click on 'Printers (2)Now at 'Search Printers' type abcd and observe for 'No search results found' message (Please refer Video) Expected: 'No search results found' message should be seen if there are no search Results Actual: Instead No Message is seen This is Non-Regression Issue seen as 'Printers' option is introduced from M-59 @stevenjb : Please confirm the Issue
,
Jan 19 2018
Weifang, please take a look at the attached file to see if the "No search results found" font/color/position looks good.
,
Jan 19 2018
+shibasheikh@ - LGTM. Does this match the material specs?
,
Jan 22 2018
Is the text Roboto/Medium 26pt? Otherwise LGTM
,
Jan 22 2018
The font is Roboto (by default), Medium 16px.
,
Jan 25 2018
I think we are ok with the current default approach. Let's proceed with this update for M65.
,
Jan 25 2018
M66?
,
Jan 25 2018
I think xdai@ might have submitted the CLs before the branch? But if not, M66 works.
,
Jan 25 2018
Not yet. If the current UI looks good, will land it today.
,
Jan 26 2018
Yes, let's land the current UI for M66. Thanks!!
,
Jan 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01689329050370714b6a9397e3f35b82eb11901f commit 01689329050370714b6a9397e3f35b82eb11901f Author: xdai <xdai@chromium.org> Date: Mon Jan 29 19:29:31 2018 CUPS: Add the "No Search Results Found" message. Bug: 761288 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0630b778aa8b758c7742af15541e83162f13d431 Reviewed-on: https://chromium-review.googlesource.com/875165 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#532541} [modify] https://crrev.com/01689329050370714b6a9397e3f35b82eb11901f/chrome/browser/resources/settings/printing_page/cups_printers.html [modify] https://crrev.com/01689329050370714b6a9397e3f35b82eb11901f/chrome/browser/resources/settings/printing_page/cups_printers.js [modify] https://crrev.com/01689329050370714b6a9397e3f35b82eb11901f/chrome/browser/resources/settings/settings.html [modify] https://crrev.com/01689329050370714b6a9397e3f35b82eb11901f/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Jan 29 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by steve...@chromium.org
, Sep 1 2017Owner: x...@chromium.org