New issue
Advanced search Search tips

Issue 761284 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Consider dropping build-time configuration from the release image

Project Member Reported by sjg@chromium.org, Sep 1 2017

Issue description

At present the master configuration is written wholesale to the final image on the device. This has no ill effects and is a small amount of data(e.g. 5KB) but some of this configuration will never be read.

We should consider filtering the master configuration to drop build-time configuration items

 

Comment 1 by sjg@chromium.org, Nov 4 2017

Labels: Unibuild

Comment 2 by sjg@chromium.org, Nov 7 2017

Cc: jclinton@chromium.org
Related to this, should we expand phandles in the run-time config?
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/e3a7e233b216c046a0eb5dbcf7b64a61ee51835b

commit e3a7e233b216c046a0eb5dbcf7b64a61ee51835b
Author: Simon Glass <sjg@chromium.org>
Date: Fri Nov 10 00:43:55 2017

chromeos-config: Support looking up audio config

The feature which allowed some audio config to move to the family
triggered a need to access the family in cros_config. Add support for this
while we resolve the underlying issue.

BUG= chromium:773898 ,  chromium:761284 , b:68953759
TEST=FEATURES=test sudo -E emerge --nodeps -q chromeos-config-tools
Note: NOT tested on a device yet
Change-Id: I005bdbd588b7bbd9beb507be716fad102534d89c
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/757257
Reviewed-by: Lann Martin <lannm@chromium.org>
Reviewed-by: Patrick Berny <pberny@chromium.org>

[modify] https://crrev.com/e3a7e233b216c046a0eb5dbcf7b64a61ee51835b/chromeos-config/libcros_config/cros_config_unittest.cc
[modify] https://crrev.com/e3a7e233b216c046a0eb5dbcf7b64a61ee51835b/chromeos-config/libcros_config/cros_config.cc
[modify] https://crrev.com/e3a7e233b216c046a0eb5dbcf7b64a61ee51835b/chromeos-config/libcros_config/cros_config.h

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/378eb3d986ae84a56316f33b0bf2e0247dd3933c

commit 378eb3d986ae84a56316f33b0bf2e0247dd3933c
Author: Simon Glass <sjg@chromium.org>
Date: Wed Feb 28 18:12:10 2018

chromeos-config: Drop the hard-coded phandle properties

These come from the schema now, so read them from there.

BUG= chromium:796983 ,  chromium:761284 
TEST=FEATURES=test sudo -E emerge  --nodeps chromeos-config-host \
	chromeos-config-tools

Change-Id: Icb7ba43b44b67a2024e9631e7eb0337b0a91c280
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/937386
Reviewed-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: C Shapiro <shapiroc@google.com>

[modify] https://crrev.com/378eb3d986ae84a56316f33b0bf2e0247dd3933c/chromeos-config/libcros_config/cros_config.cc
[modify] https://crrev.com/378eb3d986ae84a56316f33b0bf2e0247dd3933c/chromeos-config/libcros_config/cros_config.h
[modify] https://crrev.com/378eb3d986ae84a56316f33b0bf2e0247dd3933c/chromeos-config/libcros_config/target_dirs.dtsi

Comment 5 by sjg@chromium.org, Mar 26 2018

Status: Fixed (was: Untriaged)
This is done as much as possible for the device-tree master config format. All information is in the schema and the hard-coded run-time things are dropped. I'm calling this fixed, since future work can be done with the yaml config format.

Sign in to add a comment