Clicking on source code line in DevTools and it will sets breakpoint on wrong line when using sourcemap
Reported by
mar...@carlberg.org,
Sep 1 2017
|
||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/603.3.8 (KHTML, like Gecko) Version/10.1.2 Safari/603.3.8 Steps to reproduce the problem: 1. Open http://mini.carlberg.org/dev/SourceMapTestApp in Chrome 2. Open DevTools 3. Create breakpoint by clicking on line before whitespace line in SourceMapTest.j file 4. Breakpoint will be set on wrong row What is the expected behavior? Breakpoint should be set on correct line What went wrong? Breakpoint was set on wrong row Did this work before? N/A Chrome version: Version 62.0.3201.0 Channel: canary OS Version: OS X 10.12.6 Flash Version: Shockwave Flash 26.0 r0 SourceMap visualization can be checked at http://mini.carlberg.org/source-map-visualization/#objective-j This is working in Safari and Firefox Please watch attached screencast of the problem. http://mini.carlberg.org/dev/SourceMapTest.mov http://mini.carlberg.org/dev/SourceMapTest.j http://mini.carlberg.org/dev/SourceMapTest.js http://mini.carlberg.org/dev/SourceMapTest.map
,
Sep 6 2017
Just want to add that this does not work on any version of Chrome that I have tested, stable or canary.
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b215935dccf392557df907d8eb68f06edc1a227 commit 4b215935dccf392557df907d8eb68f06edc1a227 Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Thu Oct 12 06:26:32 2017 [DevTools] use end line position to request possible breakpoints Currently we use first char in next line, it regressed breakpoints in files from source map. TBR=lushnikov@chromium.org Bug: chromium:676388 , chromium:760229 , chromium:761263 Change-Id: I10e83ff96fcda6aae77515003ae1d0cdf993ee84 Reviewed-on: https://chromium-review.googlesource.com/714436 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#508267} [add] https://crrev.com/4b215935dccf392557df907d8eb68f06edc1a227/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-with-sourcemap-expected.txt [add] https://crrev.com/4b215935dccf392557df907d8eb68f06edc1a227/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-with-sourcemap.js [modify] https://crrev.com/4b215935dccf392557df907d8eb68f06edc1a227/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
,
Oct 12 2017
,
Oct 16 2017
I have tested this with Chrome 64.0.3241.0 and it is fixed. Thanks! |
||
►
Sign in to add a comment |
||
Comment 1 by pfeldman@chromium.org
, Sep 2 2017Status: Assigned (was: Unconfirmed)