Regression : URL doesn't change according to page navigation in chrome://md-settings/ page.
Reported by
rp...@etouch.net,
Sep 1 2017
|
|||||||
Issue descriptionVersion: 62.0.3202.0 fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} OS: Windows (7,8,8.1,10),Linux (14.04 LTS,Mac OS X(10.11.6,10.12.3) What steps will reproduce the problem? 1. Launch chrome, navigate to chrome://md-settings/ and then navigate to 'About chrome' or any other page and observe URL in omnibox Actual: URL doesn't change according to page navigation in chrome://md-settings/ Expected: URL should change according to page navigation in chrome://md-settings/ This is regression issue, broken in ‘M 62’ and will soon update other info : Good build:62.0.3168.0 Bad build: 62.0.3169.0
,
Sep 1 2017
Using the per-revision bisect providing the bisect results, Good build:62.0.3168.0 (489803) Bad build: 62.0.3169.0 (490187) You are probably looking for a change made after 490163 (known good), but no later than 490164 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/2ae783af6398cb95a5bd45c2f70754f5c9bbf85c..e8db841a94bfea7e6ffd5d1f1579ec101ebf974a From the CL above, assigning the issue to the owner concerned. rdevlin.cronin: Assigning this issue to you as Dan Beam is out of Chrome. Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Review-URL: https://chromium-review.googlesource.com/588079 Note :Able to reproduce the issue in Win 10.0, Ubuntu 14.04 & Mac 10.126 and able to reproduce in latest Canary #62.0.3202.0
,
Sep 1 2017
MD settings -> dpapad@, +some other webui folks. Note that chrome://md-settings is deprecated, and chrome://settings seems to work correctly. So I think the action item here is really "remove chrome://md-settings". :)
,
Sep 15 2017
fyi: md-settings is already removed as of e8db841a94bfea7e6ffd5d1f1579ec101ebf974a
,
Sep 15 2017
md-settings as a host seems to still exist on ToT (see screencast). Specifically I am observing the following behavior: 1) On a tab that is already at chrome://settings, modify the URL to chrome://md-settings. It forwards to chrome://settings immediately. 2) On a new tab navigate to chrome://md-settings. No redirection happens, the settings page loads while "md-settings" is displayed in the omnibox. I believe that 1 is intentional, but 2 is not.
,
Sep 15 2017
FYI, at https://chromium-review.googlesource.com/c/chromium/src/+/669668 I am proposing completely removing chrome://md-settings/ as a valid URL, which fixes the problem. It seems reasonable to me to stop supporting a temporary, developer-only URL, that has no good reason to exist since four milestones have passed from M59, when it became the default URL.
,
Sep 16 2017
dpapad@ and I both had the same idea here (and both essentially wrote the same CL). one of us will land a removal the [debug-only] md-settings host removal. i still think there's some underlying bug or difference in how the about rewriting code is working here.
,
Sep 16 2017
one of us will land a removal of the [debug-only] md-settings host.**
,
Sep 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0390e2d1bac9aae3c433a4bf5a93ebef20488579 commit 0390e2d1bac9aae3c433a4bf5a93ebef20488579 Author: Dan Beam <dbeam@chromium.org> Date: Tue Sep 19 01:06:40 2017 Remove lingering use of deprecated md-settings hostname from tests R=dpapad@chromium.org BUG= 749296 , 761258 Change-Id: I214b60157dc8eb7bcda1d214b8433f003aad8bb6 Reviewed-on: https://chromium-review.googlesource.com/669683 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#502745} [modify] https://crrev.com/0390e2d1bac9aae3c433a4bf5a93ebef20488579/chrome/test/data/webui/settings/a11y/settings_accessibility_test.js [modify] https://crrev.com/0390e2d1bac9aae3c433a4bf5a93ebef20488579/chrome/test/data/webui/settings/cr_settings_browsertest.js
,
Sep 19 2017
,
Sep 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1faa2513edcd16d4c60861bfa34a48c58e69502 commit a1faa2513edcd16d4c60861bfa34a48c58e69502 Author: Dan Beam <dbeam@chromium.org> Date: Tue Sep 19 23:03:18 2017 Remove chrome://md-settings -> settings redirect Material Design Settings became the default in Chrome 59. This redirect is no longer needed and is just confusing folks. R=thestig@chromium.org BUG= 761258 Change-Id: I1bf0c2f2293098a85d66d1e35abc97fd1777eafc Reviewed-on: https://chromium-review.googlesource.com/669893 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Dan Beam (no longer on Chrome) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#502980} [modify] https://crrev.com/a1faa2513edcd16d4c60861bfa34a48c58e69502/chrome/browser/browser_about_handler.cc
,
Sep 20 2017
chrome://md-settings is no longer a valid hostname |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by rp...@etouch.net
, Sep 1 2017