New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 761250 link

Starred by 1 user
Status: Fixed
Owner:
tetsui@chromium.org
Closed: Sep 2017
Cc:
█ yoshiki@chromium.org
malaykeshav@chromium.org
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

HaTS User survey notification does not have theme color

Project Member Reported by tetsui@chromium.org, Sep 1 2017 
User survey notification does not have theme color when MD notification is enabled.
The context title "Hats", which was not shown to the users in old style, is not clear.

Also, according to the MD notification spec, the icon on the right side 
 |icon| should be shown on the top left |small_image|.
Survey_Expanded.png
92.7 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79770ff3fb7646ad50e044cfcb8652f23580ece7

commit 79770ff3fb7646ad50e044cfcb8652f23580ece7
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Wed Sep 06 05:52:33 2017

Add theme color and context title to HaTS user survey notification.

- In MD notification, system notifcations should have |accent_color|.
  This does not have effect when MD notification is disabled.
- The context title "Hats" is not clear from the user viewpoint.
  This was previously not user facing string, so it was OK, but in
  MD notification, it is used as the context title, so This is changed
  to "Survey".

Screenshot before this CL: https://screenshot.googleplex.com/Jm2KKCvEux5
Screenshot after this CL: https://screenshot.googleplex.com/14v8K0KjBuy

TEST=manual
BUG= 761250 

Change-Id: I1c377a5ce00516d7c62549447f9c68d4fb9e0d5e
Reviewed-on: https://chromium-review.googlesource.com/646413
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499889}
[modify] https://crrev.com/79770ff3fb7646ad50e044cfcb8652f23580ece7/chrome/browser/chromeos/hats/hats_notification_controller.cc
[modify] https://crrev.com/79770ff3fb7646ad50e044cfcb8652f23580ece7/ui/strings/ui_strings.grd

Comment 2 by tetsui@chromium.org, Sep 7 2017

Status: Fixed (was: Started)
►

Sign in to add a comment