New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 761246 link

Starred by 1 user
Status: Fixed
Owner:
█ ortuno@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 740783



Sign in to add a comment

desktop-pwas: Navigating to an in-scope URL shouldn't open a new app window if already in the app's website

Project Member Reported by ortuno@chromium.org, Sep 1 2017 
What steps will reproduce the problem?
(1) Install Desktop PWA at https://g-ortuno.github.io/pwa-sandbox/
(2) Type https://g-ortuno.github.io/pwa-sandbox/
(3) Click the first link

What is the expected result?
The tab should navigate to the new website


What happens instead?
A new app window is opened
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39fb7edf3172e4b30555709c9a03177e1aca734d

commit 39fb7edf3172e4b30555709c9a03177e1aca734d
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Mon Sep 11 23:02:44 2017

desktop-pwas: Don't override navigations with the same origin

Stops overriding navigations if the source and the target have the same
origin.

Also removes code that checked if the navigation is in an app because
it's no longer relevant. It was used to catch two cases:

1. Opening a new app window, which would result in navigation
2. Navigations inside the app to in-scope URLs

(1) results in a AUTO_BOOKMARK transition type, which is caught by an
if statement earlier and (2) will be caught by the origin if statement
in this patch.

Bug:  761246 
Change-Id: Ic9c2a909e98da370a884a1d9f6afb129ba957e8c
Reviewed-on: https://chromium-review.googlesource.com/646390
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501077}
[modify] https://crrev.com/39fb7edf3172e4b30555709c9a03177e1aca734d/chrome/browser/apps/app_url_redirector.cc
[modify] https://crrev.com/39fb7edf3172e4b30555709c9a03177e1aca734d/chrome/browser/extensions/bookmark_app_url_redirector_browsertest.cc

Comment 2 by ortuno@chromium.org, Sep 11 2017

Status: Fixed (was: Started)
►

Sign in to add a comment