New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 761243 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 738190



Sign in to add a comment

Refactor ResourceProviderTest to ensure coverage of LayerTree and Display

Project Member Reported by xing...@intel.com, Sep 1 2017

Issue description

Currently the test case for LayerTreeResourceProvider and DisplayResourceProvider are in ResourceProviderTest. 

Some DisplayResourceProvider test case are moved from ResourceProvider, but didn't check if we should provide corresponding LayerTreeResourceProvider test case. The same rules applies to LayerTreeResourceProvider. Such a way will lead to miss test coverage on DisplayResourceProvider or LayerTreeResourceProvider.

For aforementioned DisplayResourceProvider test case (or LayerTreeResourceProvider test case), we should check carefully if we should provide corresponding LayerTreeResourceProvider test case (or DisplayResourceProvider test case).

My idea is, provide three unittest files: ResourceProviderTest: tests for resource shared between LayerTreeResourceProvider and DisplayResourceProvider; LayerTreeResourceProviderTest: tests for LayerTreeResourceProvider; DisplayResourceProviderTest: tests for DisplayResourceProviderTest;
 

Comment 1 by xing...@intel.com, Sep 1 2017

Description: Show this description

Comment 2 by xing...@intel.com, Sep 1 2017

Description: Show this description

Comment 3 by xing...@intel.com, Sep 1 2017

Description: Show this description
Labels: -Type-Bug Type-Feature
Status: Available (was: Untriaged)

Comment 5 by xing...@intel.com, Sep 6 2017

Status: Started (was: Available)

Comment 6 by xing...@intel.com, May 28 2018

Status: Fixed (was: Started)
This is done by 
https://chromium-review.googlesource.com/c/chromium/src/+/1070560
So I will close this.

Sign in to add a comment