New issue
Advanced search Search tips

Issue 761194 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Native/FramesExtensionBindingsApiTest.FramesBeforeNavigation/0 flaky on all platforms

Project Member Reported by wittman@chromium.org, Aug 31 2017

Issue description

See for example, https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FLinux_Tests%2F61603%2F%2B%2Frecipes%2Fsteps%2Fbrowser_side_navigation_browser_tests%2F0%2Flogs%2FNative__x2f_FramesExtensionBindingsApiTest.FramesBeforeNavigation__x2f_0%2F0

[ RUN      ] Native/FramesExtensionBindingsApiTest.FramesBeforeNavigation/0
Xlib:  extension "RANDR" missing on display ":99".
[24761:24761:0831/150153.739140:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[24761:24761:0831/150153.942856:INFO:CONSOLE(0)] "Denying load of chrome-extension://ficgdghpakbhhkmdjamiedmcoobamkoo/nonexistent.html. Resources must be listed in the web_accessible_resources manifest key in order to be loaded by pages outside the extension.", source: about:blank (0)
[24761:24761:0831/150153.953327:INFO:CONSOLE(0)] "Denying load of chrome-extension://ficgdghpakbhhkmdjamiedmcoobamkoo/nonexistent.html. Resources must be listed in the web_accessible_resources manifest key in order to be loaded by pages outside the extension.", source: about:blank (0)
[24761:24761:0831/150154.027021:WARNING:render_frame_host_impl.cc(2624)] OnDidStopLoading was called twice.
[24761:24761:0831/150154.027967:WARNING:render_frame_host_impl.cc(2624)] OnDidStopLoading was called twice.
[1:1:0831/150154.064988:FATAL:render_view_impl.cc(2210)] Check failed: webview()->MainFrame()->IsWebLocalFrame().
#0 0x0000027f4b67 base::debug::StackTrace::StackTrace()
#1 0x000002807cc1 logging::LogMessage::~LogMessage()
#2 0x000005ab6573 content::RenderViewImpl::OnSetFocus()
#3 0x000005b8cd6e content::(anonymous namespace)::QueuedClosure::Dispatch()
#4 0x000005b8c1b6 content::MainThreadEventQueue::DispatchEvents()
#5 0x0000027f52cc base::debug::TaskAnnotator::RunTask()
#6 0x0000026f812c blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue()
#7 0x0000026f6329 blink::scheduler::TaskQueueManager::DoWork()
#8 0x0000027f52cc base::debug::TaskAnnotator::RunTask()
#9 0x00000280c5bb base::MessageLoop::RunTask()
#10 0x00000280cc2b base::MessageLoop::DoWork()
#11 0x00000280de0a base::MessagePumpDefault::Run()
#12 0x00000282bb00 base::RunLoop::Run()
#13 0x000005acbbcc content::RendererMain()
#14 0x0000027deb42 content::RunZygote()
#15 0x0000027dfd4d content::ContentMainRunnerImpl::Run()
#16 0x000003e2f594 service_manager::Main()
#17 0x0000027de892 content::ContentMain()
#18 0x000002cdec91 content::LaunchTests()
#19 0x0000027ea37e LaunchChromeTests()
#20 0x0000027e9f27 main
#21 0x7f979e566f45 __libc_start_main
#22 0x000000574310 <unknown>
Received signal 6
#0 0x0000027f4b67 base::debug::StackTrace::StackTrace()
#1 0x0000027f46df base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7f97a4634330 <unknown>
#3 0x7f979e57bc37 gsignal
#4 0x7f979e57f028 abort
#5 0x0000027f3572 base::debug::BreakDebugger()
#6 0x00000280817c logging::LogMessage::~LogMessage()
#7 0x000005ab6573 content::RenderViewImpl::OnSetFocus()
#8 0x000005b8cd6e content::(anonymous namespace)::QueuedClosure::Dispatch()
#9 0x000005b8c1b6 content::MainThreadEventQueue::DispatchEvents()
#10 0x0000027f52cc base::debug::TaskAnnotator::RunTask()
#11 0x0000026f812c blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue()
#12 0x0000026f6329 blink::scheduler::TaskQueueManager::DoWork()
#13 0x0000027f52cc base::debug::TaskAnnotator::RunTask()
#14 0x00000280c5bb base::MessageLoop::RunTask()
#15 0x00000280cc2b base::MessageLoop::DoWork()
#16 0x00000280de0a base::MessagePumpDefault::Run()
#17 0x00000282bb00 base::RunLoop::Run()
#18 0x000005acbbcc content::RendererMain()
#19 0x0000027deb42 content::RunZygote()
#20 0x0000027dfd4d content::ContentMainRunnerImpl::Run()
#21 0x000003e2f594 service_manager::Main()
#22 0x0000027de892 content::ContentMain()
#23 0x000002cdec91 content::LaunchTests()
#24 0x0000027ea37e LaunchChromeTests()
#25 0x0000027e9f27 main
#26 0x7f979e566f45 __libc_start_main
#27 0x000000574310 <unknown>
  r8: ffff95460735e7b0  r9: ffff95460735e7a0 r10: 0000000000000008 r11: 0000000000000202
 r12: 00007fff9dce9cc0 r13: 0000000000000072 r14: 00007fff9dce9cb8 r15: 00007fff9dce9cb0
  di: 0000000000000001  si: 0000000000000001  bp: 00007fff9dce9870  bx: 00007fff9dce9870
  dx: 0000000000000006  ax: 0000000000000000  cx: ffffffffffffffff  sp: 00007fff9dce96c8
  ip: 00007f979e57bc37 efl: 0000000000000202 cgf: 0000000000000033 erf: 0000000000000000
 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]
Calling _exit(1). Core file will not be generated.
[24761:24761:0831/150154.460525:INFO:browser_test_utils.cc(1632)] DOMMessageQueue::RenderProcessGone 1
../../chrome/browser/extensions/extension_bindings_apitest.cc:269: Failure
Value of: content::ExecuteScriptAndExtractBool( browser()->tab_strip_model()->GetWebContentsAt(0), "getResult()", &page_success)
  Actual: false
Expected: true
[24761:24761:0831/150154.495856:INFO:chrome_cryptauth_service.cc(222)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[  FAILED  ] Native/FramesExtensionBindingsApiTest.FramesBeforeNavigation/0, where GetParam() = 0 (1055 ms)

 
Cc: rdevlin....@chromium.org alex...@chromium.org
 Issue 761368  has been merged into this issue.
Cc: devlin@chromium.org dtapu...@chromium.org dcheng@chromium.org
Owner: dtapu...@chromium.org
FindIt had found my CL enabling the my mojo input message change as a culprit and that might be likely because SetFocus is one of the messages routed.

dcheng@ do you have any idea why a SetFocus is sent to the renderer and it isn't a main frame?

I wonder if we now have a data race between a chrome ipc message and the new mojo channel which we wouldn't have had before.
For my safe keeping. To repro run:

out/Release/browser_tests --enable-browser-side-navigation --gtest_filter=JavaScript/FramesExtensionBindingsApiTest.FramesBeforeNavigation/0

Need to debug what is going on.

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65bb6ee8e835411efd530808243362aea737121d

commit 65bb6ee8e835411efd530808243362aea737121d
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Thu Sep 07 21:23:41 2017

Ensure that InputMsgs that are sent for swapped out widgets aren't handled.

We had a number of crashes when mojo input messages was enabled that were
related to the fact Input messages sent to swapped out RenderViews
are discarded. This change makes this available for the mojo messages.

BUG= 761194 

Change-Id: I66431c4dfb6ea7fb7006db9dd1f53aa7ba538177
Reviewed-on: https://chromium-review.googlesource.com/651547
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500381}
[modify] https://crrev.com/65bb6ee8e835411efd530808243362aea737121d/content/renderer/input/widget_input_handler_impl.cc
[modify] https://crrev.com/65bb6ee8e835411efd530808243362aea737121d/content/renderer/input/widget_input_handler_manager.cc

Status: Fixed (was: Assigned)

Sign in to add a comment