New issue
Advanced search Search tips

Issue 761146 link

Starred by 1 user
Status: Fixed
Owner:
jrumm...@chromium.org
Closed: Sep 2017
Cc:
xhw...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 611224



Sign in to add a comment

Use a type converter for media::CdmConfig

Project Member Reported by jrumm...@chromium.org, Aug 31 2017 
The mojo CDM interface [1] currently defines it's own version of CdmConfig:
struct CdmConfig {
  bool allow_distinctive_identifier;
  bool allow_persistent_state;
  bool use_hw_secure_codecs;
};
This should be replaced with a type converter so that media::CdmConfig can be used directly.

[1] https://cs.chromium.org/chromium/src/media/mojo/interfaces/content_decryption_module.mojom?l=31

Comment 1 by xhw...@chromium.org, Sep 1 2017

Blocking: 611224
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/201c7495f4737e73fb98166120dd13d91862b517

commit 201c7495f4737e73fb98166120dd13d91862b517
Author: John Rummell <jrummell@chromium.org>
Date: Fri Sep 01 22:07:55 2017

Use IPC_STRUCT_TRAITS on CdmConfig for mojo

BUG= 761146 
TEST=media_mojo_unittests pass

Change-Id: Iafce1a51bcf9ce5dbe91c98ef00f5b15c24c7d7d
Reviewed-on: https://chromium-review.googlesource.com/646389
Commit-Queue: John Rummell <jrummell@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499326}
[modify] https://crrev.com/201c7495f4737e73fb98166120dd13d91862b517/media/base/ipc/media_param_traits_macros.h
[modify] https://crrev.com/201c7495f4737e73fb98166120dd13d91862b517/media/mojo/clients/mojo_cdm.cc
[modify] https://crrev.com/201c7495f4737e73fb98166120dd13d91862b517/media/mojo/clients/mojo_renderer_unittest.cc
[modify] https://crrev.com/201c7495f4737e73fb98166120dd13d91862b517/media/mojo/common/media_type_converters.cc
[modify] https://crrev.com/201c7495f4737e73fb98166120dd13d91862b517/media/mojo/common/media_type_converters.h
[modify] https://crrev.com/201c7495f4737e73fb98166120dd13d91862b517/media/mojo/common/media_type_converters_unittest.cc
[modify] https://crrev.com/201c7495f4737e73fb98166120dd13d91862b517/media/mojo/interfaces/content_decryption_module.mojom
[modify] https://crrev.com/201c7495f4737e73fb98166120dd13d91862b517/media/mojo/interfaces/content_decryption_module.typemap
[modify] https://crrev.com/201c7495f4737e73fb98166120dd13d91862b517/media/mojo/services/media_service_unittest.cc
[modify] https://crrev.com/201c7495f4737e73fb98166120dd13d91862b517/media/mojo/services/mojo_cdm_service.cc
[modify] https://crrev.com/201c7495f4737e73fb98166120dd13d91862b517/media/mojo/services/mojo_cdm_service.h

Comment 3 by jrumm...@chromium.org, Sep 5 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment