New issue
Advanced search Search tips

Issue 761121 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 763498



Sign in to add a comment

Run gpu_unittests on the FYI waterfall and ANGLE's trybots

Project Member Reported by geoffl...@chromium.org, Aug 31 2017

Issue description

gpu_unittests has coverage of ANGLE's shader translator but is not run on any ANGLE trybots or FYI bots.  This causes failures in gpu_unittests to not show up until attempted ANGLE rolls.

These tests run very fast (<15s) so it is very easy to add them to more configurations.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/257ebaa28ad5da676c62ea3ea074224555c2a6b9

commit 257ebaa28ad5da676c62ea3ea074224555c2a6b9
Author: Geoff Lang <geofflang@chromium.org>
Date: Thu Sep 07 16:14:09 2017

Run gpu_unittests on the FYI and optional trybots.

These tests do not use GPU hardware but do cover ANGLE's shader
translator so it is important that they are run on both on ANGLE's
tryserver and the GPU FYI waterfall so that issues can be caught before
ANGLE attempts to roll into Chrome.

BUG= 761121 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I181e425f73a1e6915b095d5a20e0d61a650c23d4
Reviewed-on: https://chromium-review.googlesource.com/646759
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500316}
[modify] https://crrev.com/257ebaa28ad5da676c62ea3ea074224555c2a6b9/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/257ebaa28ad5da676c62ea3ea074224555c2a6b9/testing/buildbot/chromium.gpu.fyi.json

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d9915352dc176261d4dc143bc2ba4173dbb7c43

commit 0d9915352dc176261d4dc143bc2ba4173dbb7c43
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Thu Sep 07 21:30:06 2017

Disable gpu_unittests on Linux Ozone (Intel)

Breaks compilation on GPU Linux Ozone Builder

BUG= 761121 
TBR=kbr@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id6c617b6415059146f5a50867c3cf93e491a8912
Reviewed-on: https://chromium-review.googlesource.com/655233
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500392}
[modify] https://crrev.com/0d9915352dc176261d4dc143bc2ba4173dbb7c43/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/0d9915352dc176261d4dc143bc2ba4173dbb7c43/testing/buildbot/chromium.gpu.fyi.json

Comment 3 by kbr@chromium.org, Sep 8 2017

Blockedon: 763498

Comment 4 by kbr@chromium.org, Sep 8 2017

Note: gpu_unittests was also disabled on Linux per Issue 763498 (restricted view, sorry) in https://chromium-review.googlesource.com/657814 .

Status: Fixed (was: Started)
Going to close this, I think it's fine to not have coverage on every OS.

Sign in to add a comment