add better frame metrics |
|||||
Issue descriptionAdd better frame metrics for AVDA to replace FrameSentAsOverlay. we should get results like "overlay for L1", etc.
,
Sep 5 2017
adds metrics only. requesting merge since these will help determine if changes to the video overlay implementation in M62 are working properly. missed M62 by about an hour. i verified that the 63 canary metrics look sane.
,
Sep 6 2017
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d3d503352964ddcf8028fd5e3ebf8f938ee030e commit 0d3d503352964ddcf8028fd5e3ebf8f938ee030e Author: liberato@chromium.org <liberato@chromium.org> Date: Wed Sep 06 15:28:04 2017 Add Media.AVDA.FrameInformation histogram. [Merge from 63] Adds FrameInformation to record whether we're using a SurfaceTexture or overlay for each frame, with some information about why. This will replace Media.AVDA.FrameSentAsOverlay, once we see that it produces similar results in M62. However, since the overlay mechanism that's being measured also changed drastically in M62, I don't want to replace the measurement system at the same time. TBR=liberato@chromium.org (cherry picked from commit 5090affc4c8ae9eb450d4197b2a4af8d9c83b60a) Bug: 761108 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I55999069dc798ca6cf57d0dca38951087361d29c Reviewed-on: https://chromium-review.googlesource.com/646279 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499110} Reviewed-on: https://chromium-review.googlesource.com/652937 Reviewed-by: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#44} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/0d3d503352964ddcf8028fd5e3ebf8f938ee030e/media/gpu/android_video_decode_accelerator.cc [modify] https://crrev.com/0d3d503352964ddcf8028fd5e3ebf8f938ee030e/media/gpu/android_video_decode_accelerator.h [modify] https://crrev.com/0d3d503352964ddcf8028fd5e3ebf8f938ee030e/tools/metrics/histograms/enums.xml [modify] https://crrev.com/0d3d503352964ddcf8028fd5e3ebf8f938ee030e/tools/metrics/histograms/histograms.xml
,
Sep 6 2017
,
Sep 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b34f1d0fc870ca04d98ad21ee9826ad70477aba4 commit b34f1d0fc870ca04d98ad21ee9826ad70477aba4 Author: liberato@chromium.org <liberato@chromium.org> Date: Thu Sep 07 02:12:07 2017 Switch AVDA::FrameInformation to enum class. Bug: 761108 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I202213a2a102865571a0285f4b7435efec7aded2 Reviewed-on: https://chromium-review.googlesource.com/647194 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#500186} [modify] https://crrev.com/b34f1d0fc870ca04d98ad21ee9826ad70477aba4/media/gpu/android_video_decode_accelerator.cc [modify] https://crrev.com/b34f1d0fc870ca04d98ad21ee9826ad70477aba4/media/gpu/android_video_decode_accelerator.h |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Sep 1 2017