New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 761092 link

Starred by 1 user
Status: Fixed
Owner:
█ yzshen@chromium.org
Last visit > 30 days ago
Closed: Aug 2017
Cc:
ntfschr@chromium.org
█ sgu...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Android WebView SafeBrowsing: a more clear way to indicate that error code should be overridden with a SB-speicifc one.

Project Member Reported by yzshen@chromium.org, Aug 31 2017 
Currently, android_webview/browser/aw_safe_browsing_resource_throttle.h exposes a user data key. Code that would like to check whether error code for a URLRequest should be overridden is supposed to check whether this user data key is presented in the user data of the URLRequest.

It would be nice if it could be simpler and more obvious.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bb294762c2aebc7c458fa08821120c4242a03bc

commit 1bb294762c2aebc7c458fa08821120c4242a03bc
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Thu Aug 31 21:41:20 2017

AW SafeBrowsing: use a more clear way to indicate whether a request is cancelled by SafeBrowsing.

Bug:  761092 
Change-Id: I6c67c273de967b7cdfa02ffdfe38766218ba1d2d
Reviewed-on: https://chromium-review.googlesource.com/646747
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Selim Gurun <sgurun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499015}
[modify] https://crrev.com/1bb294762c2aebc7c458fa08821120c4242a03bc/android_webview/browser/aw_safe_browsing_resource_throttle.cc
[modify] https://crrev.com/1bb294762c2aebc7c458fa08821120c4242a03bc/android_webview/browser/aw_safe_browsing_resource_throttle.h
[modify] https://crrev.com/1bb294762c2aebc7c458fa08821120c4242a03bc/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc

Comment 2 by ntfschr@chromium.org, Aug 31 2017 

Thanks! Looks a lot cleaner. And thanks for cleaning up the stale imports!

Comment 3 by yzshen@chromium.org, Aug 31 2017

Status: Fixed (was: Started)
No problem! My pleasure. :)
►

Sign in to add a comment