New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 761090 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Increment client_id for clients in mus-ws by 1

Project Member Reported by riajiang@chromium.org, Aug 31 2017

Issue description

Currently WindowServer has client_id 0, WindowManager 1, other clients 2++. This is confusing when we print out the id. Ids sent by clients in WindowTree also have client_id 0 before we fill in the real one so it's hard to tell if a window with client_id 0 is actually created by WS or just haven't been processed (fill in the real id) by the WindowTree yet.

It would help debugging if we increment all client_id by 1, i.e. WS 1, WM2, other clients 3++. This also requires a lot of id changes in tests.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2e20b8617a15152110d7e49baa003417785b206

commit d2e20b8617a15152110d7e49baa003417785b206
Author: Ria Jiang <riajiang@chromium.org>
Date: Wed Sep 06 19:51:21 2017

mus: Increment client_id for clients by 1.

Currently WindowServer has client_id 0, WindowManager 1, other clients
2++. This is confusing when we print out the id. Ids sent by clients in
WindowTree also have client_id 0 before we fill in the real one so it's
hard to tell if a window with client_id 0 is actually created by WS or
just haven't been processed (filled in the real id) by the WindowTree
yet.

This CL increments all client_id by 1, i.e. WS 1, WM 2, other clients
3++; and fixes related tests.

Bug:  761090 
Test: covered by tests
Change-Id: Ifd62d2c802c8fe99e6cddcda48b571d78924346e
Reviewed-on: https://chromium-review.googlesource.com/648255
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500049}
[modify] https://crrev.com/d2e20b8617a15152110d7e49baa003417785b206/services/ui/ws/ids.h
[modify] https://crrev.com/d2e20b8617a15152110d7e49baa003417785b206/services/ui/ws/test_utils.cc
[modify] https://crrev.com/d2e20b8617a15152110d7e49baa003417785b206/services/ui/ws/test_utils.h
[modify] https://crrev.com/d2e20b8617a15152110d7e49baa003417785b206/services/ui/ws/window_manager_client_unittest.cc
[modify] https://crrev.com/d2e20b8617a15152110d7e49baa003417785b206/services/ui/ws/window_manager_state_unittest.cc
[modify] https://crrev.com/d2e20b8617a15152110d7e49baa003417785b206/services/ui/ws/window_server.cc
[modify] https://crrev.com/d2e20b8617a15152110d7e49baa003417785b206/services/ui/ws/window_tree_client_unittest.cc
[modify] https://crrev.com/d2e20b8617a15152110d7e49baa003417785b206/services/ui/ws/window_tree_unittest.cc

Status: Fixed (was: Assigned)
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment