New issue
Advanced search Search tips

Issue 761085 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug


Show other hotlists

Hotlists containing this issue:
In-Product-Help


Sign in to add a comment

Add pulsing indicator for video download IPH

Project Member Reported by nyquist@chromium.org, Aug 31 2017

Issue description

Chrome Version: M61
OS: Android

The CL https://codereview.chromium.org/2943983003/ added support for video download IPH, but does not show a pulsing indicator of the the video download button.

What steps will reproduce the problem?
(1) Find a video online to download
(2) Ensure that IPH is displayed through demo mode.

What is the expected result?
The download-button is highlighted with a pulsing indicator.

What happens instead?
No pulse.
 
Status: Assigned (was: Untriaged)
Assigning to owner.
Cc: dtrainor@chromium.org
Here is the current state (attached video)

Note : We need to enable the feature from command line as demo mode will not be sufficient for this case.
build/android/adb_chrome_public_command_line "--enable-features=IPH_MediaDownload"

The bubble is misaligned since the media controls move after it starts playing.
Also the bubble doesn't realign or dismiss on orientation change.

Once we have the right coordinates of the download button, we can add a pulse drawable.

xyz.mp4
5.7 MB View Download
Status: Started (was: Assigned)
Labels: -M-62 M-64
Components: UI>Browser>Mobile
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcfd6880c1e15dae6e2870aa2f7307123d48f136

commit fcfd6880c1e15dae6e2870aa2f7307123d48f136
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Thu Oct 05 03:55:34 2017

In-product-help : Various fixes for media download button IPH

1 - This CL tries to fix the coordinates where the media download IPH bubble
should be shown. Currently we show it as soon as it starts playing, but
the controls moves down afterwards and we should probably set it after
it has settled.

2 - Added a y-offset to account for the viewport location offset on screen.

3 - Dismiss the in-product-help message after a orientation change.
This should be unnecessary if blink could send us the correct coordinates
after the rotate.

4 - Added a pulse highlight around the download button.

Bug:  761085 
Change-Id: Id21c67f65f077ac69fd2d8c862433f1e476085d8
Reviewed-on: https://chromium-review.googlesource.com/661051
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506636}
[modify] https://crrev.com/fcfd6880c1e15dae6e2870aa2f7307123d48f136/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/fcfd6880c1e15dae6e2870aa2f7307123d48f136/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[modify] https://crrev.com/fcfd6880c1e15dae6e2870aa2f7307123d48f136/chrome/android/java/src/org/chromium/chrome/browser/widget/textbubble/TextBubble.java
[modify] https://crrev.com/fcfd6880c1e15dae6e2870aa2f7307123d48f136/chrome/browser/android/tab_android.cc
[modify] https://crrev.com/fcfd6880c1e15dae6e2870aa2f7307123d48f136/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/fcfd6880c1e15dae6e2870aa2f7307123d48f136/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp
[modify] https://crrev.com/fcfd6880c1e15dae6e2870aa2f7307123d48f136/third_party/WebKit/Source/modules/media_controls/MediaDownloadInProductHelpManager.cpp
[modify] https://crrev.com/fcfd6880c1e15dae6e2870aa2f7307123d48f136/third_party/WebKit/Source/modules/media_controls/MediaDownloadInProductHelpManager.h

Labels: -M-64 M-63
Status: Fixed (was: Started)

Sign in to add a comment