The photo picker needs to initialize PathUtils |
||||||||||
Issue descriptionTwo bots disagree with the PhotoPickerDialogTest tests, which continue to time out: Android Tests (dbg) and Marshmellow x64 Tester: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FAndroid_Tests__dbg_%2F45254%2F%2B%2Frecipes%2Fsteps%2Fchrome_public_test_apk_on_Android%2F0%2Flogs%2Forg.chromium.chrome.browser.photo_picker.PhotoPickerDialogTest_testSingleSelectionPhoto%2F0 https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.android%2FMarshmallow_64_bit_Tester%2F15164%2F%2B%2Frecipes%2Fsteps%2Fchrome_public_test_apk_on_Android%2F0%2Flogs%2Forg.chromium.chrome.browser.photo_picker.PhotoPickerDialogTest_testSingleSelectionPhoto%2F0 This doesn't reproduce on our devices, but let's make sure we understand what's happening and find a solution, as we do very much want them to be enabled.
,
Aug 31 2017
I'm marking them as @DisabledTest now, but we should really decrease its scope asap. Marking as M-62 too.
,
Sep 12 2017
Fix is up for review: https://chromium-review.googlesource.com/c/chromium/src/+/663219
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b2e0e41009d6602216bca90ca9c4d8ba6c23e28 commit 7b2e0e41009d6602216bca90ca9c4d8ba6c23e28 Author: Peter Beverloo <peter@chromium.org> Date: Tue Sep 12 14:19:32 2017 Initialize PathUtils for the decoder service This should fix the crashes that we've been seeing on the bots, so those have been re-enabled as well. BUG= 761060 Change-Id: I75dfcc04e972e5dd9a0478cc297701603fa71551 Reviewed-on: https://chromium-review.googlesource.com/663219 Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#501265} [modify] https://crrev.com/7b2e0e41009d6602216bca90ca9c4d8ba6c23e28/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/DecoderService.java [modify] https://crrev.com/7b2e0e41009d6602216bca90ca9c4d8ba6c23e28/chrome/android/javatests/src/org/chromium/chrome/browser/photo_picker/PhotoPickerDialogTest.java
,
Sep 12 2017
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22df00fda61bbf6f75a19ecd8b2c7e7a29e12fcd commit 22df00fda61bbf6f75a19ecd8b2c7e7a29e12fcd Author: Theresa <twellington@chromium.org> Date: Tue Sep 12 17:18:57 2017 Revert "Initialize PathUtils for the decoder service" This reverts commit 7b2e0e41009d6602216bca90ca9c4d8ba6c23e28. Reason for revert: Failing on Android Tests (dbg) Original change's description: > Initialize PathUtils for the decoder service > > This should fix the crashes that we've been seeing on the bots, so those > have been re-enabled as well. > > BUG= 761060 > > Change-Id: I75dfcc04e972e5dd9a0478cc297701603fa71551 > Reviewed-on: https://chromium-review.googlesource.com/663219 > Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> > Commit-Queue: Peter Beverloo <peter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#501265} TBR=peter@chromium.org,finnur@chromium.org Change-Id: I2f41b0d15b06f55f978e81e7503e52d9301260c5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 761060 Reviewed-on: https://chromium-review.googlesource.com/663420 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#501323} [modify] https://crrev.com/22df00fda61bbf6f75a19ecd8b2c7e7a29e12fcd/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/DecoderService.java [modify] https://crrev.com/22df00fda61bbf6f75a19ecd8b2c7e7a29e12fcd/chrome/android/javatests/src/org/chromium/chrome/browser/photo_picker/PhotoPickerDialogTest.java
,
Sep 12 2017
The re-enabled tests are failing on Android Tests (dbg) https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/45539 e.g. ava.util.concurrent.TimeoutException: waitForCallback timed out! at org.chromium.base.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:191) at org.chromium.base.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:202) at org.chromium.chrome.browser.photo_picker.PhotoPickerDialogTest.waitForDecoder(PhotoPickerDialogTest.java:148) at org.chromium.chrome.browser.photo_picker.PhotoPickerDialogTest.testSingleSelectionPhoto(PhotoPickerDialogTest.java:217) at java.lang.reflect.Method.invokeNative(Native Method) at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214) at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199) at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192) at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:110) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554) at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
,
Sep 12 2017
This bot runs devices on Android K. The fatal error while running these tests: [0912/161842.182814:FATAL:jni_android.cc(130)] Failed to find class org/chromium/chrome/browser/AfterStartupTaskUtils
,
Sep 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2dc3e7214f2d70c23ece4dd908b48e33bed15a0 commit a2dc3e7214f2d70c23ece4dd908b48e33bed15a0 Author: Peter Beverloo <peter@chromium.org> Date: Wed Sep 13 15:17:48 2017 Initialize PathUtils for the decoder service This fixes a crash that's observed on certain Android M devices. BUG= 761060 Change-Id: Ibef9110eda33238cb2db2f0084320d3ea83fdab8 Reviewed-on: https://chromium-review.googlesource.com/663363 Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#501635} [modify] https://crrev.com/a2dc3e7214f2d70c23ece4dd908b48e33bed15a0/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/DecoderService.java
,
Sep 15 2017
Verified on Chrome:63.0.3215.0 Device:LG G4(LG-H815)/MRA58K
,
Sep 20 2017
Can we get this fix merged to M62 Branch?
,
Sep 21 2017
Thank you so much for verifying! Requesting merge.
,
Sep 21 2017
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 25 2017
Friendly ping on the merge approval request.
,
Sep 27 2017
Is this completely infra related? Can this fix break other stuffs in M62?
,
Sep 28 2017
No, this change is isolated to the photo picker, and the code only runs when the photo picker is launched.
,
Sep 28 2017
Issue 764476 has been merged into this issue.
,
Sep 28 2017
,
Sep 29 2017
Not a release blocker stable but good to have in M62
,
Sep 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb6a1c3d9c54454735219d7dc2f4ddd08849046d commit eb6a1c3d9c54454735219d7dc2f4ddd08849046d Author: Peter Beverloo <peter@chromium.org> Date: Fri Sep 29 15:10:48 2017 Initialize PathUtils for the decoder service This fixes a crash that's observed on certain Android M devices. BUG= 761060 Change-Id: Ibef9110eda33238cb2db2f0084320d3ea83fdab8 Reviewed-on: https://chromium-review.googlesource.com/663363 Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#501635}(cherry picked from commit a2dc3e7214f2d70c23ece4dd908b48e33bed15a0) Reviewed-on: https://chromium-review.googlesource.com/692038 Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#505} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/eb6a1c3d9c54454735219d7dc2f4ddd08849046d/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/DecoderService.java
,
Jan 9 2018
This is done. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by bugdroid1@chromium.org
, Aug 31 2017