New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 761060 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

The photo picker needs to initialize PathUtils

Project Member Reported by peter@chromium.org, Aug 31 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d39be029ff226c64e306d102d1503d466865cbaf

commit d39be029ff226c64e306d102d1503d466865cbaf
Author: Peter Beverloo <peter@chromium.org>
Date: Thu Aug 31 18:17:25 2017

Disable the photo picker tests as we investigate

These tests are failing on two bots, but fine everywhere else including
on local devices. We're continuing to investigate (and already requested
devices) in the issue to narrow this down.

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  761060 
Change-Id: I43c1e26c35fc8ae03cd44f010fd2368ad9cf4a13
Reviewed-on: https://chromium-review.googlesource.com/645950
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498921}
[modify] https://crrev.com/d39be029ff226c64e306d102d1503d466865cbaf/chrome/android/javatests/src/org/chromium/chrome/browser/photo_picker/PhotoPickerDialogTest.java

Comment 2 by peter@chromium.org, Aug 31 2017

Labels: M-62
I'm marking them as @DisabledTest now, but we should really decrease its scope asap. Marking as M-62 too.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b2e0e41009d6602216bca90ca9c4d8ba6c23e28

commit 7b2e0e41009d6602216bca90ca9c4d8ba6c23e28
Author: Peter Beverloo <peter@chromium.org>
Date: Tue Sep 12 14:19:32 2017

Initialize PathUtils for the decoder service

This should fix the crashes that we've been seeing on the bots, so those
have been re-enabled as well.

BUG= 761060 

Change-Id: I75dfcc04e972e5dd9a0478cc297701603fa71551
Reviewed-on: https://chromium-review.googlesource.com/663219
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501265}
[modify] https://crrev.com/7b2e0e41009d6602216bca90ca9c4d8ba6c23e28/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/DecoderService.java
[modify] https://crrev.com/7b2e0e41009d6602216bca90ca9c4d8ba6c23e28/chrome/android/javatests/src/org/chromium/chrome/browser/photo_picker/PhotoPickerDialogTest.java

Comment 5 by peter@chromium.org, Sep 12 2017

Summary: The photo picker needs to initialize PathUtils (was: Fix PhotoPickerDialogTest failures on the bots)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22df00fda61bbf6f75a19ecd8b2c7e7a29e12fcd

commit 22df00fda61bbf6f75a19ecd8b2c7e7a29e12fcd
Author: Theresa <twellington@chromium.org>
Date: Tue Sep 12 17:18:57 2017

Revert "Initialize PathUtils for the decoder service"

This reverts commit 7b2e0e41009d6602216bca90ca9c4d8ba6c23e28.

Reason for revert: Failing on Android Tests (dbg)

Original change's description:
> Initialize PathUtils for the decoder service
> 
> This should fix the crashes that we've been seeing on the bots, so those
> have been re-enabled as well.
> 
> BUG= 761060 
> 
> Change-Id: I75dfcc04e972e5dd9a0478cc297701603fa71551
> Reviewed-on: https://chromium-review.googlesource.com/663219
> Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
> Commit-Queue: Peter Beverloo <peter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#501265}

TBR=peter@chromium.org,finnur@chromium.org

Change-Id: I2f41b0d15b06f55f978e81e7503e52d9301260c5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  761060 
Reviewed-on: https://chromium-review.googlesource.com/663420
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501323}
[modify] https://crrev.com/22df00fda61bbf6f75a19ecd8b2c7e7a29e12fcd/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/DecoderService.java
[modify] https://crrev.com/22df00fda61bbf6f75a19ecd8b2c7e7a29e12fcd/chrome/android/javatests/src/org/chromium/chrome/browser/photo_picker/PhotoPickerDialogTest.java

The re-enabled tests are failing on Android Tests (dbg)

https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/45539

e.g.

ava.util.concurrent.TimeoutException: waitForCallback timed out!
	at org.chromium.base.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:191)
	at org.chromium.base.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:202)
	at org.chromium.chrome.browser.photo_picker.PhotoPickerDialogTest.waitForDecoder(PhotoPickerDialogTest.java:148)
	at org.chromium.chrome.browser.photo_picker.PhotoPickerDialogTest.testSingleSelectionPhoto(PhotoPickerDialogTest.java:217)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:110)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)

Comment 8 by peter@chromium.org, Sep 12 2017

This bot runs devices on Android K. The fatal error while running these tests:

[0912/161842.182814:FATAL:jni_android.cc(130)] Failed to find class org/chromium/chrome/browser/AfterStartupTaskUtils


Project Member

Comment 9 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2dc3e7214f2d70c23ece4dd908b48e33bed15a0

commit a2dc3e7214f2d70c23ece4dd908b48e33bed15a0
Author: Peter Beverloo <peter@chromium.org>
Date: Wed Sep 13 15:17:48 2017

Initialize PathUtils for the decoder service

This fixes a crash that's observed on certain Android M devices.

BUG= 761060 

Change-Id: Ibef9110eda33238cb2db2f0084320d3ea83fdab8
Reviewed-on: https://chromium-review.googlesource.com/663363
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501635}
[modify] https://crrev.com/a2dc3e7214f2d70c23ece4dd908b48e33bed15a0/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/DecoderService.java

Verified on Chrome:63.0.3215.0 Device:LG G4(LG-H815)/MRA58K
Can we get this fix merged to M62 Branch?

Comment 12 by peter@chromium.org, Sep 21 2017

Labels: Merge-Request-62
Thank you so much for verifying! Requesting merge.
Project Member

Comment 13 by sheriffbot@chromium.org, Sep 21 2017

Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 14 by peter@chromium.org, Sep 25 2017

Friendly ping on the merge approval request.
Is this completely infra related? Can this fix break other stuffs in M62?

Comment 16 by peter@chromium.org, Sep 28 2017

Cc: cma...@chromium.org
No, this change is isolated to the photo picker, and the code only runs when the photo picker is launched.

Comment 17 by peter@chromium.org, Sep 28 2017

Issue 764476 has been merged into this issue.

Comment 18 by peter@chromium.org, Sep 28 2017

Labels: ReleaseBlock-Stable
Labels: -Hotlist-Merge-Review -ReleaseBlock-Stable -Merge-Review-62 Merge-Approved-62
Not a release blocker stable but good to have in M62
Project Member

Comment 20 by bugdroid1@chromium.org, Sep 29 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb6a1c3d9c54454735219d7dc2f4ddd08849046d

commit eb6a1c3d9c54454735219d7dc2f4ddd08849046d
Author: Peter Beverloo <peter@chromium.org>
Date: Fri Sep 29 15:10:48 2017

Initialize PathUtils for the decoder service

This fixes a crash that's observed on certain Android M devices.

BUG= 761060 

Change-Id: Ibef9110eda33238cb2db2f0084320d3ea83fdab8
Reviewed-on: https://chromium-review.googlesource.com/663363
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#501635}(cherry picked from commit a2dc3e7214f2d70c23ece4dd908b48e33bed15a0)
Reviewed-on: https://chromium-review.googlesource.com/692038
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#505}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/eb6a1c3d9c54454735219d7dc2f4ddd08849046d/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/DecoderService.java

Status: Fixed (was: Started)
This is done.

Sign in to add a comment