New issue
Advanced search Search tips

Issue 761056 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

[A11y Assessment - Toolbar] Issues with Chrome overflow menu zoom buttons & zoom icon in omnibox

Project Member Reported by lpalmaro@chromium.org, Aug 31 2017

Issue description

OS: Chrome
Version: 61.0.3163.58

1) Enable ChromeVox - Ctrl Alt Z
2) Press Alt Shift T to place focus on toolbar
3) Press Search + Right to get to the Chrome overflow menu and press Search + Space to open it 

When you reach the zoom portion of the Chrome overflow menu, there are some accessibility issues. \

1) When I use ChromeVox to get to the minus and plus buttons, I hear confusing verbalization. I hear "make text smaller, ctrl plus" and then I hear "make text larger, ctrl two plus signs" for the plus button. We need to change these labels. The minus button should have the label "make text smaller" and this should be implemented as a button so that the full verbalization is "make text smaller, button". The plus sign should be "make text larger, button". There isn't really a need to include the keyboard shortcuts for these since the buttons here in this menu do the exact same thing. 

Note, if you feel strongly that we should follow the same pattern as other items in this menu and include the corresponding keyboard shortcut, then we need to make it more understandable. It should speak "ctrl plus minus" and ctrl plus plus sign" to be more clear, since currently, the minus sign itself isn't spoken by the screen reader, so it just says "ctrl plus " and doesn't tell the user that they need to press the minus sign. And the current verbalization of "ctrl two plus signs" is super confusing... 


2) When you press the button to increase or decrease the size, the change is not dynamically announced. When you press the minus button for example and then the percentage visually shows that it's at 90%, "90%" should be read as a spoken alert. 

3) When I change the size by pressing the minus or plus buttons, then navigate back to the percentage, I always hear "100%" even if it says another percentage. Something is strange there. 

This same issue with speaking the wrong percentage and not speaking the dynamic alert is occurring in the omnibox zoom button. To repro this, press Ctrl + a few times to increase zoom and the little magnifier icon will appear in the omnibox. Then use ChromeVox to navigate there --- press Alt Shift T to put focus on the toolbar, then press Search + Right to get to that magnifier icon and press Search + Space to open it. 

Then use Search + Right to get to the minus or plus button and press Search + Space to activate it and observe. 

 
Cc: abodenha@chromium.org
Albert, any idea who can take a look at this one? 
Owner: zork@chromium.org
zork@ can someone on your team take this on?

Comment 3 by zork@chromium.org, Oct 24 2017

Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2bfdc1913a5d5c508cb9ed509f47fc16ea678ec

commit a2bfdc1913a5d5c508cb9ed509f47fc16ea678ec
Author: zork@chromium.org <zork@google.com>
Date: Thu Oct 26 00:12:14 2017

Change toolbar magnification button roles and accessibility text to
better match usage.

Bug: 761056
Change-Id: I3540738c99c29634a88d01d1cf0d2d6a634d0500
Reviewed-on: https://chromium-review.googlesource.com/730417
Commit-Queue: Zachary Kuznia <zork@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511654}
[modify] https://crrev.com/a2bfdc1913a5d5c508cb9ed509f47fc16ea678ec/chrome/browser/ui/views/toolbar/app_menu.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f003b4618181c549d4735e64acfbf74d3e485e3

commit 3f003b4618181c549d4735e64acfbf74d3e485e3
Author: zork@chromium.org <zork@google.com>
Date: Wed Nov 08 23:10:23 2017

Send an accessibility event when updating zoom text labels.

Bug: 761056
Change-Id: I95fd118f8f9fd1bea77ae88f308fd59eefb6f2b6
Reviewed-on: https://chromium-review.googlesource.com/756783
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Zachary Kuznia <zork@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514990}
[modify] https://crrev.com/3f003b4618181c549d4735e64acfbf74d3e485e3/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc
[modify] https://crrev.com/3f003b4618181c549d4735e64acfbf74d3e485e3/chrome/browser/ui/views/toolbar/app_menu.cc

Labels: MagnifierCrOS

Sign in to add a comment