New issue
Advanced search Search tips

Issue 761047 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

Switch Access accidentally enabled by users who don't want it

Project Member Reported by dmazz...@chromium.org, Aug 31 2017

Issue description

Reports from users:

"got a report from one of our large customers that a few of their users have been running into issues where their number keys would turn into accessibility shortcuts.  I googled around and found it looks related to the "Switch Access" accessibility option."

"After 59 update, we have some users that get a rectangle appear on screen when hitting some number keys.  Looks like it is ChromeVox.  We can’t disable it in settings.  There are no extensions showing in the extensions page.  But whatever it is is synchronizing from the user’s account. Google tech support people noticed an extension (pmehocpgjmkenlokgjfkaichfjdhpeol) loading.  We don’t recognize it.  Not deployed through admin console.  Some Google Documents refer to it as “switchaccessextension”."

We don't know why this is happening yet.

Switch access is an *experimental* feature. It's only supposed to be enabled if you visit chrome://flags and enable experimental accessibility features, then toggle it on in Chrome Settings.

Even though we don't understand it, we can fix it by ensuring that Switch Access is never loaded if the experimental flag is not enabled, regardless of the value of the pref.

 
Components: UI>Accessibility
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c85a5c959f8120eb33f0beaaa0408deb7677789e

commit c85a5c959f8120eb33f0beaaa0408deb7677789e
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Thu Aug 31 18:53:30 2017

Never enable Switch Access unless the experimental flag is enabled.

A few users seem to be getting Switch Access enabled by accident.
Somehow the pref is set, even though they never explicitly enabled it.
This is especially confusing because without the "experimental accessibility
apis" flag set, you can't even see the Setting.

Fix this by checking the flag before loading Switch Access. This should
prevent all accidental or unwanted loading of this feature.

Bug:  761047 
Change-Id: Id24fc8aad8f790b260ac0f1e08c1bc8a04d2562a
Reviewed-on: https://chromium-review.googlesource.com/646078
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498937}
[modify] https://crrev.com/c85a5c959f8120eb33f0beaaa0408deb7677789e/chrome/browser/chromeos/accessibility/accessibility_manager.cc

Labels: Merge-Request-61
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 31 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 4 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by ketakid@google.com, Aug 31 2017

Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 31 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8a323bc4aaefb75a677c878bd53f683c515e6d8

commit c8a323bc4aaefb75a677c878bd53f683c515e6d8
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Thu Aug 31 22:03:24 2017

Merge to M61: Never enable Switch Access unless the experimental flag is enabled.

A few users seem to be getting Switch Access enabled by accident.
Somehow the pref is set, even though they never explicitly enabled it.
This is especially confusing because without the "experimental accessibility
apis" flag set, you can't even see the Setting.

Fix this by checking the flag before loading Switch Access. This should
prevent all accidental or unwanted loading of this feature.

(cherry picked from commit c85a5c959f8120eb33f0beaaa0408deb7677789e)

Bug:  761047 
Change-Id: Id24fc8aad8f790b260ac0f1e08c1bc8a04d2562a
Reviewed-on: https://chromium-review.googlesource.com/646078
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#498937}
Reviewed-on: https://chromium-review.googlesource.com/646849
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#1054}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/c8a323bc4aaefb75a677c878bd53f683c515e6d8/chrome/browser/chromeos/accessibility/accessibility_manager.cc

Status: Fixed (was: Started)

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 9 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment