New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 761037 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Last visit > 30 days ago
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Ignore page load timing updates from extension frames

Project Member Reported by bmcquade@chromium.org, Aug 31 2017

Issue description

As of https://chromium-review.googlesource.com/c/chromium/src/+/641633 we include timing updates from all child frames.

However, this includes injected extension frames, which we don't want to track, as they could skew metrics (consider an extension that injects a frame in every page immediately after commit - this would report very fast times to first paint for every page load, which isn't what we're interested in measuring and would skew results).

For the time being we'll ignore all updates from extension frames.
 
Cc: csharrison@chromium.org
We'll go ahead and land the fix for this for now, but need to add a browsertest in a follow up.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09c4bb9057624d3634ed6645fa2971990a6db53d

commit 09c4bb9057624d3634ed6645fa2971990a6db53d
Author: Bryan McQuade <bmcquade@chromium.org>
Date: Thu Aug 31 18:10:08 2017

Ignore subframe updates from extension frames.

Bug: 761037
Change-Id: Ib1ffbd4d6ff9c674a0e02b710b465e4500a7c828
Reviewed-on: https://chromium-review.googlesource.com/646450
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498920}
[modify] https://crrev.com/09c4bb9057624d3634ed6645fa2971990a6db53d/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.cc

Sign in to add a comment