New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 761036 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

When InternetDetailPage is visible, tether scans get kicked off

Project Member Reported by khorimoto@chromium.org, Aug 31 2017

Issue description

This is only supposed to happen when InternetSubpage is visible.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fda955b0ef891bf1997d550d2e3e22f437a59af

commit 9fda955b0ef891bf1997d550d2e3e22f437a59af
Author: Kyle Horimoto <khorimoto@google.com>
Date: Thu Aug 31 21:23:35 2017

[CrOS Tether] Do not kick off a network scan on network detail page.

The scan should only be kicked off on the Wi-Fi/Mobile networks
subpage.

Bug:  761036 , 672263
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9c6fecfeb6232c6713f2ff442303deed375ada09
Reviewed-on: https://chromium-review.googlesource.com/646628
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499005}
[modify] https://crrev.com/9fda955b0ef891bf1997d550d2e3e22f437a59af/chrome/browser/resources/settings/internet_page/internet_subpage.js

Labels: Merge-Request-61
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 31 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 4 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by ketakid@google.com, Aug 31 2017

Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61.
Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 31 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f2dfb4533b4b369ef78ccfc00adcb95ba9ca554

commit 7f2dfb4533b4b369ef78ccfc00adcb95ba9ca554
Author: Kyle Horimoto <khorimoto@google.com>
Date: Thu Aug 31 21:51:16 2017

[CrOS Tether] Do not kick off a network scan on network detail page.

The scan should only be kicked off on the Wi-Fi/Mobile networks
subpage.

TBR=khorimoto@google.com

(cherry picked from commit 9fda955b0ef891bf1997d550d2e3e22f437a59af)

Bug:  761036 , 672263
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9c6fecfeb6232c6713f2ff442303deed375ada09
Reviewed-on: https://chromium-review.googlesource.com/646628
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499005}
Reviewed-on: https://chromium-review.googlesource.com/646790
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#1053}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/7f2dfb4533b4b369ef78ccfc00adcb95ba9ca554/chrome/browser/resources/settings/internet_page/internet_subpage.js

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 8 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment