New issue
Advanced search Search tips

Issue 761033 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 3
Type: Bug

Blocking:
issue 882906
issue 754861



Sign in to add a comment

NavigationURLLoaderTest.RequestFailedCert* failing with latest Fuchsia SDK

Project Member Reported by scottmg@chromium.org, Aug 31 2017

Issue description

With latest Fuchsia SDK, these tests are failing in content_unittests (tested locally).

[00047.629] 02429.02462> 2 tests crashed:
[00047.629] 02429.02462>     NavigationURLLoaderTest.RequestFailedCertError (../../content/browser/loader/navigation_url_loader_unittest.cc:194)
[00047.629] 02429.02462>     NavigationURLLoaderTest.RequestFailedCertErrorFatal (../../content/browser/loader/navigation_url_loader_unittest.cc:218)


[00047.439] 02429.02462> [ RUN      ] NavigationURLLoaderTest.RequestFailedCertErrorFatal
[00047.439] 02429.02462> [3:1065191641:0831/170612.018879:47430656:ERROR:test_root_certs_fuchsia.cc(15)] Not implemented reached in bool net::TestRootCerts::Add(net::X509Certificate *)
[00047.439] 02429.02462> [3:1065191641:0831/170612.019013:47430791:FATAL:embedded_test_server.cc(80)] Check failed: added_root_certs. Failed to install root cert from EmbeddedTestServer
#00: base::debug::StackTrace::StackTrace(unsigned long) at base/debug/stack_trace_fuchsia.cc:173
#01: base::debug::StackTrace::StackTrace() at base/debug/stack_trace.cc:199
#02: logging::LogMessage::~LogMessage() at base/logging.cc:560
#03: pc 0x3e48e52dd85e (app:content_unittests,0xa3af85e)
#04: pc 0x3e48e52dd719 (app:content_unittests,0xa3af719)
#05: content::NavigationURLLoaderTest_RequestFailedCertErrorFatal_Test::TestBody() at content/browser/loader/navigation_url_loader_unittest.cc:219
#06: void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) at third_party/googletest/src/googletest/src/gtest.cc:2400
#07: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) at third_party/googletest/src/googletest/src/gtest.cc:2453
#08: pc 0x3e48e05b6fd6 (app:content_unittests,0x5688fd6)
#09: pc 0x3e48e05b7b2d (app:content_unittests,0x5689b2d)
#10: testing::TestCase::Run() at third_party/googletest/src/googletest/src/gtest.cc:2771
#11: testing::internal::UnitTestImpl::RunAllTests() at third_party/googletest/src/googletest/src/gtest.cc:4676
#12: bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) at third_party/googletest/src/googletest/src/gtest.cc:2400
#13: bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) at third_party/googletest/src/googletest/src/gtest.cc:2453
#14: testing::UnitTest::Run() at third_party/googletest/src/googletest/src/gtest.cc:4285
#15: RUN_ALL_TESTS() at third_party/googletest/src/googletest/include/gtest/gtest.h:2237
#16: base::TestSuite::Run() at base/test/test_suite.cc:270
#17: content::UnitTestTestSuite::Run() at content/public/test/unittest_test_suite.cc:45
#18: int base::internal::FunctorTraits<int (content::UnitTestTestSuite::*)(), void>::Invoke<content::UnitTestTestSuite*>(int (content::UnitTestTestSuite::*)(), content::UnitTestTestSuite*&&) at base/bind_internal.h:194
#19: int base::internal::InvokeHelper<false, int>::MakeItSo<int (content::UnitTestTestSuite::* const&)(), content::UnitTestTestSuite*>(int (content::UnitTestTestSuite::* const&)(), content::UnitTestTestSuite*&&) at base/bind_internal.h:277
#20: int base::internal::Invoker<base::internal::BindState<int (content::UnitTestTestSuite::*)(), base::internal::UnretainedWrapper<content::UnitTestTestSuite> >, int ()>::RunImpl<int (content::UnitTestTestSuite::* const&)(), std::__1::tuple<base::internal::UnretainedWrapper<content::UnitTestTestSuite> > const&, 0ul>(int (content::UnitTestTestSuite::* const&)(), std::__1::tuple<base::internal::UnretainedWrapper<content::UnitTestTestSuite> > const&, std::__1::integer_sequence<unsigned long, 0ul>) at base/bind_internal.h:349
#21: base::internal::Invoker<base::internal::BindState<int (content::UnitTestTestSuite::*)(), base::internal::UnretainedWrapper<content::UnitTestTestSuite> >, int ()>::Run(base::internal::BindStateBase*) at base/bind_internal.h:331
#22: base::RepeatingCallback<int ()>::Run() const & at base/callback.h:92
#23: base::(anonymous namespace)::LaunchUnitTestsInternal(base::RepeatingCallback<int ()> const&, unsigned long, int, bool, base::RepeatingCallback<void ()> const&) at base/test/launcher/unit_test_launcher.cc:216
#24: base::LaunchUnitTests(int, char**, base::RepeatingCallback<int ()> const&) at base/test/launcher/unit_test_launcher.cc:475
#25: main at content/test/run_all_unittests.cc:20
#26: pc 0x528147066e8e (libc.so,0x1be8e)
[00047.440] 02429.02462>
[00047.440] 02429.02462> [4530/4533] NavigationURLLoaderTest.RequestFailedCertErrorFatal (CRASHED)

 
Blocking: 754861
Owner: scottmg@chromium.org
Status: Started (was: Unconfirmed)
Hmm, net_unittests is OK though. I guess I'll just roll anyway and disable these two tests, and look into them later.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7bb7ea4f91fcc4cd9c140f8b2c092db704e268c

commit f7bb7ea4f91fcc4cd9c140f8b2c092db704e268c
Author: Scott Graham <scottmg@chromium.org>
Date: Thu Aug 31 17:32:46 2017

fuchsia: Update content_unittests filter for recent changes/flakes

- AudioRendererSinkCacheTest.SmokeTest was fixed by making gtest
  threadsafe (rolled already)
- BrowsingDataRemoverImplTest.MultipleTasks is yet-another sqlite one
  that needs locks (just moved in the filter)
- CacheStorageManagerTest.GetAllOriginsUsageWithOldIndex was fixed in
  Fuchsia and by SDK roll elsewhere (mtime fix for parent dirs)
- RendererAudioOutputStreamFactoryIntegrationTest.StreamIntegrationTest
  was (likely) also fixed by the gtest fix. (At least, it uses gmock,
  and I can't reproduce failure any more.
- URLLoaderImplTest.CantSniffEmptyHtml has flaked a few times, disable
  it along with the rest of the URLLoaderImplTest
- NavigationURLLoaderTest.RequestFailedCertError and
  NavigationURLLoaderTest.RequestFailedCertErrorFatal started failing
  after the SDK roll, disable.

Bug: 760687,  759916 ,  754861 ,  761033 
Change-Id: I53baaa13f7526172675f44cba1aee9371b6dfac2
TBR: wez@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/646527
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498909}
[modify] https://crrev.com/f7bb7ea4f91fcc4cd9c140f8b2c092db704e268c/testing/buildbot/filters/fuchsia.content_unittests.filter

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce186b12bc9c664ae8feae3264d65b6249ff5e43

commit ce186b12bc9c664ae8feae3264d65b6249ff5e43
Author: Scott Graham <scottmg@chromium.org>
Date: Thu Aug 31 23:20:25 2017

fuchsia: Update content_unittests filter after cert fixes

Fixed by https://chromium.googlesource.com/chromium/src/+/4039bfa76af61b9ca5ba2f390852b0bf8d36ffd9

TBR: sergeyu@chromium.org
Bug:  761033 ,  754861 
Change-Id: Id42863af3e696bd21267d423204ca530c0016a23
Reviewed-on: https://chromium-review.googlesource.com/646836
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499067}
[modify] https://crrev.com/ce186b12bc9c664ae8feae3264d65b6249ff5e43/testing/buildbot/filters/fuchsia.content_unittests.filter

Blocking: 882906
Status: Fixed (was: Started)

Sign in to add a comment