New issue
Advanced search Search tips

Issue 761030 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug
Team-Accessibility

Blocked on:
issue 696234



Sign in to add a comment

No visible focus indicator for extension icons in overflow menu

Project Member Reported by sko...@chromium.org, Aug 31 2017

Issue description

Chrome Version: 61.0.3163.49 
OS: OS X

What steps will reproduce the problem?
(1) Ensure one or more extension icons are shown in the overflow (Chrome) menu (e.g. by hiding in Chrome menu explicitly.
(2) Open Chrome menu.
(3) Using keyboard, use arrow key to 'select' an extension icon in the overflow menu. 

What is the expected result?
Extension icon that currently has focus has a visible focus indicator

What happens instead?
No visible focus indicator.  Extension icons can be given focus, as evidenced by the fact that if you happen to have one focused and press the Space key the extensions UI will pop up.  But you have no way to know which extension icon is focused because there is no visible indicator.

Visible indicators are shown when you scroll through all of the extension icons and hit the first menu item (About)

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
Components: UI>Accessibility
Labels: a11y-2017
Also, note that in general, I can't figure out a way to resize the omnibox with keyboard only -- I only see how to do this by dragging the mouse. We should figure out a keyboard-only equivalent. Separate issue, but wanted to at least mention. 

Devlin, any thoughts on who could take this focus indication issue on? 
Cc: tapted@chromium.org ellyjo...@chromium.org karandeepb@chromium.org sdy@chromium.org
Yes, the extension overflow menu on mac is... terrible :(  There is no keyboard highlight indication, and the keyboard navigation is unintuitive, and likely broken.  Unfortunately, this is because of Mac's (lack of) support for custom views in a menu, and we have very little control over this.  I've talked with tapted@ and ellyjones@ about it in the past to see if there's any good way we can do this, and we couldn't come up with any.  +also karandeepb@ and sdy@ in case they have ideas.

There are two possible paths forward, I think:
- Make the entire wrench menu a custom view.  This is what we do for bookmark folders on mac.  Everyone I've talked with about this totally hates this idea, because the bookmark folders break constantly and are crazy-complicated.
- Make the wrench menu use MacViews.  This is the best solution, I think, and would solve all the problems (since none of these issues exist on Views).  Unfortunately, last I heard, menus were slated to be one of the last things converted. :(

> Also, note that in general, I can't figure out a way to resize the omnibox with keyboard only -- I only see how to do this by dragging the mouse. We should figure out a keyboard-only equivalent. Separate issue, but wanted to at least mention.

This is achievable (slowly) by using the context menu to hide/show specific extensions, which is keyboard-accessible.
Owner: tapted@chromium.org
Status: Assigned (was: Untriaged)
Assigning to @tapted assuming that we'll solve this as part of MacViews if not sooner.

Note that the Zoom and Cut/Copy/Paste controls are similarly not keyboard-accessible.

Owner: ----
Status: Available (was: Assigned)
We're not moving away from native menus for MacViews, so this won't come for free with anything that's in my queue. This is incomplete feature work - an Extensions person should own this.

Perhaps BrowserActionCell just needs to draw a focus ring manually using code like what's at https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/ControlCell/Articles/ManipulateCellControl.html#//apple_ref/doc/uid/TP40002338-SW5
Blockedon: 696234
Ah, except, getting the key events needs some tricks too. I started hacking a bit on  Issue 696234  -- seems feasible.
Yes - if we can intercept the key events and receive focus, then drawing the focus ring is totally doable.
Project Member

Comment 7 by sheriffbot@chromium.org, Sep 7

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Untriaged)
MacViews has fixed this (yay!)

Sign in to add a comment