WebView needs to preserve the old behviour of documentElement.scrollHeight |
||||||||||||
Issue descriptionb/64386353 demonstrates that there are applications that rely on the current behaviour, even though that behaviour is wrong. We have to be more conservative with breaking apps than we do websites, because the update process is much more involved, and much slower. For this reason we should retain the original behaviour as a webview quirk, with the intention of turning it off for apps that target a future Android SDK version.
,
Aug 31 2017
The flipkart example isn't a good one because it happens even in Chrome; their webapp they just load to the mobile site.
,
Aug 31 2017
,
Aug 31 2017
Having a target SDK quirk for this makes sense to me, I should have thought to suggest that from the beginning - sorry!
,
Aug 31 2017
issue crbug.com/753757 is a good example though.
,
Aug 31 2017
,
Sep 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/416174f07b4d1d930fee687ddd0eae67fbc24ee1 commit 416174f07b4d1d930fee687ddd0eae67fbc24ee1 Author: Tobias Sargeant <tobiasjs@google.com> Date: Fri Sep 01 01:18:09 2017 Disable ScrollTopLeftInterop in WebView. Applications depend on the current behaviour for layout, and may not be able to update in time to avoid regressions for users. BUG= 761016 Change-Id: Id7153a62fe1e3a550a049e4b2a6b9a57e6f7891d Reviewed-on: https://chromium-review.googlesource.com/645980 Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by: Alexandre Elias <aelias@chromium.org> Reviewed-by: Rick Byers <rbyers@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#499101} [modify] https://crrev.com/416174f07b4d1d930fee687ddd0eae67fbc24ee1/android_webview/browser/aw_settings.cc [modify] https://crrev.com/416174f07b4d1d930fee687ddd0eae67fbc24ee1/android_webview/java/src/org/chromium/android_webview/AwSettings.java [modify] https://crrev.com/416174f07b4d1d930fee687ddd0eae67fbc24ee1/content/public/common/common_param_traits_macros.h [modify] https://crrev.com/416174f07b4d1d930fee687ddd0eae67fbc24ee1/content/public/common/web_preferences.cc [modify] https://crrev.com/416174f07b4d1d930fee687ddd0eae67fbc24ee1/content/public/common/web_preferences.h [modify] https://crrev.com/416174f07b4d1d930fee687ddd0eae67fbc24ee1/content/renderer/render_view_impl.cc [modify] https://crrev.com/416174f07b4d1d930fee687ddd0eae67fbc24ee1/third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp [modify] https://crrev.com/416174f07b4d1d930fee687ddd0eae67fbc24ee1/third_party/WebKit/public/platform/WebRuntimeFeatures.h
,
Sep 1 2017
,
Sep 1 2017
This bug requires manual review: We are only 3 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 1 2017
Please merge this today.
,
Sep 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0035b95ac00370e93be9d1c5933d321f74251ba1 commit 0035b95ac00370e93be9d1c5933d321f74251ba1 Author: Tobias Sargeant <tobiasjs@google.com> Date: Fri Sep 01 20:05:46 2017 Disable ScrollTopLeftInterop in WebView. Applications depend on the current behaviour for layout, and may not be able to update in time to avoid regressions for users. BUG= 761016 TBR=tobiasjs@google.com (cherry picked from commit 416174f07b4d1d930fee687ddd0eae67fbc24ee1) Change-Id: Id7153a62fe1e3a550a049e4b2a6b9a57e6f7891d Reviewed-on: https://chromium-review.googlesource.com/645980 Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by: Alexandre Elias <aelias@chromium.org> Reviewed-by: Rick Byers <rbyers@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499101} Reviewed-on: https://chromium-review.googlesource.com/648406 Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#1075} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/0035b95ac00370e93be9d1c5933d321f74251ba1/android_webview/browser/aw_settings.cc [modify] https://crrev.com/0035b95ac00370e93be9d1c5933d321f74251ba1/android_webview/java/src/org/chromium/android_webview/AwSettings.java [modify] https://crrev.com/0035b95ac00370e93be9d1c5933d321f74251ba1/content/public/common/common_param_traits_macros.h [modify] https://crrev.com/0035b95ac00370e93be9d1c5933d321f74251ba1/content/public/common/web_preferences.cc [modify] https://crrev.com/0035b95ac00370e93be9d1c5933d321f74251ba1/content/public/common/web_preferences.h [modify] https://crrev.com/0035b95ac00370e93be9d1c5933d321f74251ba1/content/renderer/render_view_impl.cc [modify] https://crrev.com/0035b95ac00370e93be9d1c5933d321f74251ba1/third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp [modify] https://crrev.com/0035b95ac00370e93be9d1c5933d321f74251ba1/third_party/WebKit/public/platform/WebRuntimeFeatures.h
,
Sep 1 2017
battun@, Could someone verify this M61 merge with the steps in crbug.com/753757 , update? Thanks!
,
Sep 5 2017
Fix merged to M61, verified on latest M61- 61.0.3163.79 as per the steps mentioned in comment#12. Tested device:Samsung Galaxy J5 6.0.1/(MMB29M),Nexus 5X 7.1.2/(N2G47O) Thanks!
,
Sep 5 2017
,
Sep 5 2017
This just missed m62 branch point, and needs to be merged there too.
,
Sep 6 2017
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4fee1fa5787866bcb420cf1270965cfe5adc4aad commit 4fee1fa5787866bcb420cf1270965cfe5adc4aad Author: Tobias Sargeant <tobiasjs@google.com> Date: Wed Sep 06 12:13:06 2017 Disable ScrollTopLeftInterop in WebView. Applications depend on the current behaviour for layout, and may not be able to update in time to avoid regressions for users. BUG= 761016 TBR=tobiasjs@google.com (cherry picked from commit 416174f07b4d1d930fee687ddd0eae67fbc24ee1) Change-Id: Id7153a62fe1e3a550a049e4b2a6b9a57e6f7891d Reviewed-on: https://chromium-review.googlesource.com/645980 Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by: Alexandre Elias <aelias@chromium.org> Reviewed-by: Rick Byers <rbyers@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499101} Reviewed-on: https://chromium-review.googlesource.com/652546 Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#41} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/4fee1fa5787866bcb420cf1270965cfe5adc4aad/android_webview/browser/aw_settings.cc [modify] https://crrev.com/4fee1fa5787866bcb420cf1270965cfe5adc4aad/android_webview/java/src/org/chromium/android_webview/AwSettings.java [modify] https://crrev.com/4fee1fa5787866bcb420cf1270965cfe5adc4aad/content/public/common/common_param_traits_macros.h [modify] https://crrev.com/4fee1fa5787866bcb420cf1270965cfe5adc4aad/content/public/common/web_preferences.cc [modify] https://crrev.com/4fee1fa5787866bcb420cf1270965cfe5adc4aad/content/public/common/web_preferences.h [modify] https://crrev.com/4fee1fa5787866bcb420cf1270965cfe5adc4aad/content/renderer/render_view_impl.cc [modify] https://crrev.com/4fee1fa5787866bcb420cf1270965cfe5adc4aad/third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp [modify] https://crrev.com/4fee1fa5787866bcb420cf1270965cfe5adc4aad/third_party/WebKit/public/platform/WebRuntimeFeatures.h
,
Sep 7 2017
verified on latest M62- 62.0.3202.12 as per the steps mentioned in comment#12. Tested device:Pixel XL / OPM1.170907.001 Thanks!
,
Sep 7 2017
Also verified on Samsung S8/NRD90M,Nexus9/N2G47S,Sony xperia Z5+(32.3.A.2.33) ,issue mentioned in crbug/753757 no longer reproducible with Monochrome Dev 62.0.3202.12 with Guardian App 4.33.1289 |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by tobiasjs@chromium.org
, Aug 31 2017