New issue
Advanced search Search tips

Issue 761015 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Make SMIL timing state revalidation more explicit

Project Member Reported by f...@opera.com, Aug 31 2017

Issue description

(Based on "findings" from  issue 760057 )

It's difficult to keep of SMIL timing/interval state consistent due to how the value are "cached" and those caches invalidated. It should be easier for interval code to make sure timing state is consistent (and react to changes in it by recomputing derived state.)

A rough plan for this work could look like:

1. Make state-revalidation for each "cached" field explicit.
   This will essentially mean an audit of the users of Dur(), RepeatDur() et.c and hoisting the "cache valid" checks into the methods that call them, yielding a "validation prologue" for each user. (Methods are preferably renamed here to indicate the behavioral difference.) Methods then use the member variables directly.

2. The "validation prologue" is hoisted out of the methods where it's present.
   This can be iterated upon until suitable entry-points are reached. At this point in time, cache validation can probably also move into a new method.

3. (here be handwaving) Trigger general interval (re)computation when state-changes are detected.

4. (future) Subject other timing state (not just currently "cached" state) to a similar treatment.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Sep 3

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)

Sign in to add a comment