Deprecate memory.top_10_mobile |
||||||||
Issue descriptionFor a while we have wished to remove memory.top_10_mobile, but we have been blocked since it is still used to fill in the Android System Health Plan (SHP) on each Chrome release. We want to switch to using system_health.memory_mobile for that purpose, but _that_ itself has been blocked on getting ready the Speed Releasing dashboard on chromeperf. Since we want to prioritize the deprecation of old benchmarks, I propose instead to finish any work needed (if any) to extract the necessary information for SHP out of the older Chrome Health Dashboard [1] until Speed Releasing becomes a thing. I don't see any obvious blockers at the moment, so, if there are no strong objections, I propose to file this upcoming SHP (branch point in a day or so) already using data from the new system_health.memory_mobile benchmark. If no issues arise, we may then remove memory.top_10_mobile soon after that (or maybe after one more milestone if we want to be extra careful). [1]: https://chrome-health.googleplex.com/system-health/
,
Sep 4 2017
I think I might have been overly optimistic when thinking we could already produce an Android System Health Plan out of system_health.memory_mobile. It's not straightforward to get the numbers from the current dashboards. But even if you get them, which I did, it's still pretty difficult to diagnose any apparent "regressions". The main reason being that we don't have on chromeperf summary charts for "foreground" and "background" story groups. I'll try to write a doc detailing what the difficulties were, and where we might need to work if we really want to get rid of memory.top_10_mobile at some point, eventually. Meanwhile, lowering Pri here. This is not happening for the current milestone. :(
,
Sep 5 2017
,
Sep 7 2017
,
Nov 3 2017
,
Feb 20 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/39dbf090351feadfb5cef8428cdf1612fdff9bea commit 39dbf090351feadfb5cef8428cdf1612fdff9bea Author: Juan Antonio Navarro Perez <perezju@chromium.org> Date: Tue Feb 20 12:31:13 2018
,
Aug 2
,
Dec 21
+Ben, any chance you could help Juan with getting summary charts for "foreground" and "background" story groups on chromeperf dashboard or v2spa?
,
Dec 22
It looks like the stories in memory.top_10_mobile are not in system_health.memory_mobile. If you add the stories with tags, then you can select the tags in the Test cases menu to let v2spa merge the selected per-story timeseries. https://v2spa-dot-chromeperf.appspot.com/#session=c1d8d2ef9a4e5d6e44fab2d60d5882c5f4de9ee823445c17497d36dee3891a10
,
Jan 2
The foreground/background split is already implemented for system_health.memory_mobile in v2spa [1]: https://v2spa-dot-chromeperf.appspot.com/#report=Health%253AChrome%253ANexus+5+%2528Internal%2529&minRev=612437&maxRev=latest Except it doesn't appear to be working right at the moment? I get a bunch of NaNs. Assigning to +ushesh since the only blocker for this is to make sure that the v2spa reports are good to go for releasing purposes. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by primiano@chromium.org
, Sep 1 2017