New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 761013 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Use computed_opacity when rendering element

Project Member Reported by bshe@chromium.org, Aug 31 2017

Issue description

computed_opacity has opacity which inherited from parent. We should use it when drawing element instead of element's opacity.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d8b6a1cf50e7eab06ba7d47125b2b4041ea1fdc

commit 8d8b6a1cf50e7eab06ba7d47125b2b4041ea1fdc
Author: Biao She <bshe@chromium.org>
Date: Fri Sep 01 13:07:14 2017

Use computed_opacity to render ui elements

computed_opacity has opacity inheriated from parent. We should use it instead
of the element's opacity.

Bug:  761013 
Change-Id: I24ed910f82d53a41d9b184a453a0d60d6d5ccb08
Reviewed-on: https://chromium-review.googlesource.com/646506
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499176}
[modify] https://crrev.com/8d8b6a1cf50e7eab06ba7d47125b2b4041ea1fdc/chrome/browser/vr/BUILD.gn
[modify] https://crrev.com/8d8b6a1cf50e7eab06ba7d47125b2b4041ea1fdc/chrome/browser/vr/elements/content_element.cc
[modify] https://crrev.com/8d8b6a1cf50e7eab06ba7d47125b2b4041ea1fdc/chrome/browser/vr/elements/grid.cc
[modify] https://crrev.com/8d8b6a1cf50e7eab06ba7d47125b2b4041ea1fdc/chrome/browser/vr/elements/rect.cc
[modify] https://crrev.com/8d8b6a1cf50e7eab06ba7d47125b2b4041ea1fdc/chrome/browser/vr/elements/textured_element.cc
[modify] https://crrev.com/8d8b6a1cf50e7eab06ba7d47125b2b4041ea1fdc/chrome/browser/vr/elements/textured_element.h
[modify] https://crrev.com/8d8b6a1cf50e7eab06ba7d47125b2b4041ea1fdc/chrome/browser/vr/elements/ui_texture.h
[add] https://crrev.com/8d8b6a1cf50e7eab06ba7d47125b2b4041ea1fdc/chrome/browser/vr/test/fake_ui_element_renderer.cc
[add] https://crrev.com/8d8b6a1cf50e7eab06ba7d47125b2b4041ea1fdc/chrome/browser/vr/test/fake_ui_element_renderer.h
[modify] https://crrev.com/8d8b6a1cf50e7eab06ba7d47125b2b4041ea1fdc/chrome/browser/vr/ui_scene_manager_unittest.cc

Comment 2 by bshe@chromium.org, Sep 1 2017

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20d2f4c87361d57332158f3da8ad141e8d5cbb19

commit 20d2f4c87361d57332158f3da8ad141e8d5cbb19
Author: Biao She <bshe@chromium.org>
Date: Fri Sep 08 22:32:58 2017

Recursively check if elements are rendered with correct opacity


Bug:  761013 
Change-Id: Ife4a8cef1c088a9e2ec445ca2a4588de13524577
Reviewed-on: https://chromium-review.googlesource.com/656041
Commit-Queue: Biao She <bshe@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500713}
[modify] https://crrev.com/20d2f4c87361d57332158f3da8ad141e8d5cbb19/chrome/browser/vr/elements/textured_element.cc
[modify] https://crrev.com/20d2f4c87361d57332158f3da8ad141e8d5cbb19/chrome/browser/vr/elements/textured_element.h
[modify] https://crrev.com/20d2f4c87361d57332158f3da8ad141e8d5cbb19/chrome/browser/vr/elements/ui_texture.h
[modify] https://crrev.com/20d2f4c87361d57332158f3da8ad141e8d5cbb19/chrome/browser/vr/test/fake_ui_element_renderer.cc
[modify] https://crrev.com/20d2f4c87361d57332158f3da8ad141e8d5cbb19/chrome/browser/vr/test/fake_ui_element_renderer.h
[modify] https://crrev.com/20d2f4c87361d57332158f3da8ad141e8d5cbb19/chrome/browser/vr/test/ui_scene_manager_test.cc
[modify] https://crrev.com/20d2f4c87361d57332158f3da8ad141e8d5cbb19/chrome/browser/vr/test/ui_scene_manager_test.h
[modify] https://crrev.com/20d2f4c87361d57332158f3da8ad141e8d5cbb19/chrome/browser/vr/ui_scene_manager_unittest.cc

Sign in to add a comment