New issue
Advanced search Search tips

Issue 761009 link

Starred by 2 users
Status: Fixed
Owner:
iclell...@chromium.org
Closed: Apr 2018
Cc:
loonyb...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Remove support for space-separated feature list in Feature Policy Allow attribute

Project Member Reported by iclell...@chromium.org, Aug 31 2017 
Change description:
The syntax for enabling multiple features in a frame using feature policy has changed from allow="feature1 feature2 feature3" to allow="feature1; feature2; feature3". This is to support listing origins for each feature. The old syntax is currently handled through a special case in the parser, but that code should be removed.

Changes to API surface:
- Remove support for "feature1 feature2 feature3" syntax in <iframe allow>.

Links:
Public standards discussion: https://github.com/WICG/feature-policy/issues/78

Support in other browsers:
This feature is not yet supported in any other browsers.

Comment 1 by loonyb...@chromium.org, Aug 31 2017

Cc: loonyb...@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a74fa697e4fd38c64c05491f809d012d42eccb53

commit a74fa697e4fd38c64c05491f809d012d42eccb53
Author: Luna Lu <loonybear@chromium.org>
Date: Fri Sep 01 12:34:45 2017

Add UseCounter for old allow attribute syntax

Bug:  726739 ,  761009 
Change-Id: Ifd0a8e7a020e20b86fe218b607ac69a041b73ce3
Reviewed-on: https://chromium-review.googlesource.com/643759
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499172}
[modify] https://crrev.com/a74fa697e4fd38c64c05491f809d012d42eccb53/third_party/WebKit/Source/core/html/HTMLFrameElement.cpp
[modify] https://crrev.com/a74fa697e4fd38c64c05491f809d012d42eccb53/third_party/WebKit/Source/core/html/HTMLFrameElement.h
[modify] https://crrev.com/a74fa697e4fd38c64c05491f809d012d42eccb53/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp
[modify] https://crrev.com/a74fa697e4fd38c64c05491f809d012d42eccb53/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h
[modify] https://crrev.com/a74fa697e4fd38c64c05491f809d012d42eccb53/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp
[modify] https://crrev.com/a74fa697e4fd38c64c05491f809d012d42eccb53/third_party/WebKit/Source/core/html/HTMLIFrameElement.h
[modify] https://crrev.com/a74fa697e4fd38c64c05491f809d012d42eccb53/third_party/WebKit/Source/core/html/HTMLIFrameElementTest.cpp
[modify] https://crrev.com/a74fa697e4fd38c64c05491f809d012d42eccb53/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp
[modify] https://crrev.com/a74fa697e4fd38c64c05491f809d012d42eccb53/third_party/WebKit/Source/core/html/HTMLPlugInElement.h
[modify] https://crrev.com/a74fa697e4fd38c64c05491f809d012d42eccb53/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp
[modify] https://crrev.com/a74fa697e4fd38c64c05491f809d012d42eccb53/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.h
[modify] https://crrev.com/a74fa697e4fd38c64c05491f809d012d42eccb53/third_party/WebKit/public/platform/web_feature.mojom
[modify] https://crrev.com/a74fa697e4fd38c64c05491f809d012d42eccb53/tools/metrics/histograms/enums.xml

Comment 3 by iclell...@chromium.org, Sep 6 2017

Labels: Merge-Request-62
I'd like to merge this usecounter into M62 so that we can accurately track the usage of the deprecated syntax, to know the potential effect of removing it.

Requesting merge of https://crrev.com/a74fa697e4fd38c64c05491f809d012d42eccb53 to M62 branch.
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 7 2017

Labels: -Merge-Request-62 Hotlist-Merge-Approved Merge-Approved-62
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 7 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fef18aadef8165283e773ccab3b5886653b4a46

commit 3fef18aadef8165283e773ccab3b5886653b4a46
Author: Ian Clelland <iclelland@google.com>
Date: Thu Sep 07 16:59:41 2017

Add UseCounter for old allow attribute syntax

TBR=loonybear@chromium.org

(cherry picked from commit a74fa697e4fd38c64c05491f809d012d42eccb53)

Bug:  726739 ,  761009 
Change-Id: Ifd0a8e7a020e20b86fe218b607ac69a041b73ce3
Reviewed-on: https://chromium-review.googlesource.com/643759
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499172}
Reviewed-on: https://chromium-review.googlesource.com/655226
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#65}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/3fef18aadef8165283e773ccab3b5886653b4a46/third_party/WebKit/Source/core/html/HTMLFrameElement.cpp
[modify] https://crrev.com/3fef18aadef8165283e773ccab3b5886653b4a46/third_party/WebKit/Source/core/html/HTMLFrameElement.h
[modify] https://crrev.com/3fef18aadef8165283e773ccab3b5886653b4a46/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp
[modify] https://crrev.com/3fef18aadef8165283e773ccab3b5886653b4a46/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h
[modify] https://crrev.com/3fef18aadef8165283e773ccab3b5886653b4a46/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp
[modify] https://crrev.com/3fef18aadef8165283e773ccab3b5886653b4a46/third_party/WebKit/Source/core/html/HTMLIFrameElement.h
[modify] https://crrev.com/3fef18aadef8165283e773ccab3b5886653b4a46/third_party/WebKit/Source/core/html/HTMLIFrameElementTest.cpp
[modify] https://crrev.com/3fef18aadef8165283e773ccab3b5886653b4a46/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp
[modify] https://crrev.com/3fef18aadef8165283e773ccab3b5886653b4a46/third_party/WebKit/Source/core/html/HTMLPlugInElement.h
[modify] https://crrev.com/3fef18aadef8165283e773ccab3b5886653b4a46/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp
[modify] https://crrev.com/3fef18aadef8165283e773ccab3b5886653b4a46/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.h
[modify] https://crrev.com/3fef18aadef8165283e773ccab3b5886653b4a46/third_party/WebKit/public/platform/web_feature.mojom
[modify] https://crrev.com/3fef18aadef8165283e773ccab3b5886653b4a46/tools/metrics/histograms/enums.xml

Comment 6 by owe...@chromium.org, Sep 12 2017

Labels: migrated-launch-owp Type-Task
This issue has been automatically relabelled type=task because type=launch-owp issues are now officially deprecated. The deprecation is because they were creating confusion about how to get launch approvals, which should be instead done via type=launch issues.

We recommend this issue be used for implementation tracking (for public visibility), but if you already have an issue for that, you may mark this as duplicate.

For more details see here: https://docs.google.com/document/d/1JA6RohjtZQc26bTrGoIE_bSXGXUDQz8vc6G0n_sZJ2o/edit

For any questions, please contact owencm, sshruthi, larforge

Comment 7 by phistuck@chromium.org, Mar 3 2018

Labels: Hotlist-Interop
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f11defc0ca57000a4214804e38b169659b7da16a

commit f11defc0ca57000a4214804e38b169659b7da16a
Author: Ian Clelland <iclelland@chromium.org>
Date: Wed Apr 18 20:42:03 2018

Remove deprecated feature policy syntax

Bug:  761009 
Change-Id: I07844c77a73b0be1605b9970af1249ea7f189fe3
Reviewed-on: https://chromium-review.googlesource.com/949050
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Luna Lu <loonybear@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551812}
[modify] https://crrev.com/f11defc0ca57000a4214804e38b169659b7da16a/third_party/blink/renderer/core/html/html_frame_element.cc
[modify] https://crrev.com/f11defc0ca57000a4214804e38b169659b7da16a/third_party/blink/renderer/core/html/html_frame_element.h
[modify] https://crrev.com/f11defc0ca57000a4214804e38b169659b7da16a/third_party/blink/renderer/core/html/html_frame_owner_element.cc
[modify] https://crrev.com/f11defc0ca57000a4214804e38b169659b7da16a/third_party/blink/renderer/core/html/html_frame_owner_element.h
[modify] https://crrev.com/f11defc0ca57000a4214804e38b169659b7da16a/third_party/blink/renderer/core/html/html_iframe_element.cc
[modify] https://crrev.com/f11defc0ca57000a4214804e38b169659b7da16a/third_party/blink/renderer/core/html/html_iframe_element.h
[modify] https://crrev.com/f11defc0ca57000a4214804e38b169659b7da16a/third_party/blink/renderer/core/html/html_iframe_element_test.cc
[modify] https://crrev.com/f11defc0ca57000a4214804e38b169659b7da16a/third_party/blink/renderer/core/html/html_plugin_element.cc
[modify] https://crrev.com/f11defc0ca57000a4214804e38b169659b7da16a/third_party/blink/renderer/core/html/html_plugin_element.h
[modify] https://crrev.com/f11defc0ca57000a4214804e38b169659b7da16a/third_party/blink/renderer/core/policy/policy_test.cc
[modify] https://crrev.com/f11defc0ca57000a4214804e38b169659b7da16a/third_party/blink/renderer/platform/feature_policy/feature_policy.cc
[modify] https://crrev.com/f11defc0ca57000a4214804e38b169659b7da16a/third_party/blink/renderer/platform/feature_policy/feature_policy.h
[modify] https://crrev.com/f11defc0ca57000a4214804e38b169659b7da16a/third_party/blink/renderer/platform/feature_policy/feature_policy_test.cc

Comment 9 by iclell...@chromium.org, Apr 18 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment