New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 761000 link

Starred by 1 user
Status: Fixed
Owner:
█ galinap@google.com
Email to this user bounced
Closed: Sep 2017
Cc:
█ gaschler@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Task



Sign in to add a comment

[Contextual Suggestions] Show toast when backend responds with suggestions

Project Member Reported by galinap@google.com, Aug 31 2017 
Currently we have a toast showing when the frontend requests suggestions. However, it would be useful to know when the backend responds and display how many suggestions it provided. 

This makes it easier to tell when the caousel is not shown because there are no suggestions or because there is a problem with the UI.

These toasts will be removed once the UI is stable and shows suggestions consistently.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b21466f333bcf456e1d30887b9754064f89b486

commit 9b21466f333bcf456e1d30887b9754064f89b486
Author: galinap <galinap@google.com>
Date: Fri Sep 01 11:24:48 2017

[Contextual Suggestions] Add toast to show when suggestions were fetched

This CL adds a toast at the bottom of the screen, which shows up when
the backend responds with a list of contextual suggestions.

This makes it easier to see when the carousel is not shown because
there are no suggestions or because the UI doesn't work.

Bug:  761000 
Change-Id: Iea54fb6a53529a67efdfc994fa00d5d636471093
Reviewed-on: https://chromium-review.googlesource.com/645979
Commit-Queue: Galia Peycheva <galinap@google.com>
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499168}
[modify] https://crrev.com/9b21466f333bcf456e1d30887b9754064f89b486/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java

Comment 2 by galinap@google.com, Sep 1 2017

Status: Fixed (was: Started)
►

Sign in to add a comment