New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 760989 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Chrome_Mac: Crash Report - base::mac::`anonymous namespace'::GetLoginItemForApp

Project Member Reported by cr...@system.gserviceaccount.com, Aug 31 2017

Issue description

reporter:rbasuvula@google.com

crash_analysis_section:start
crash_analysis_section:end

Magic Signature: base::mac::`anonymous namespace'::GetLoginItemForApp

Crash link: https://crash.corp.google.com/browse?q=product.name%3D'Chrome_Mac'%20AND%20product.version%3D'61.0.3163.71'%20AND%20custom_data.ChromeCrashProto.channel%3D'beta'%20AND%20custom_data.ChromeCrashProto.ptype%3D'browser'%20AND%20ReportID%3D'b5bdc1af973cf52a'%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D'base%3A%3Amac%3A%3A%60anonymous%20namespace%5C'%3A%3AGetLoginItemForApp'&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D&unnest=#3

-------------------------------------------------------------------------------
Sample Report
-------------------------------------------------------------------------------
Product name: Chrome_Mac
Magic Signature : base::mac::`anonymous namespace'::GetLoginItemForApp
Product Version: 61.0.3163.71
Report ID: b5bdc1af973cf52a
Report Url: https://crash.corp.google.com/b5bdc1af973cf52a
Report Time: 2017-08-31T04:46:17-07:00
Upload Time: 2017-08-31T04:46:20.268-07:00
Uptime: 2000 ms
CumulativeProductUptime: 0 ms
OS Name: Mac OS X
OS Version: 10.13.0 17A358a
CPU Architecture: amd64
CPU Info: family 6 model 58 stepping 9

-------------------------------------------------------------------------------
Crashing thread: Thread index: 0. Stack Quality: 76%. Thread id: 3002.
-------------------------------------------------------------------------------
0x00007fff3d2ca54f (CoreFoundation + 0x0001b54f)	CFEqual
0x00000001078d6a91 (Google Chrome Framework - mac_util.mm: 105)	base::mac::(anonymous namespace)::GetLoginItemForApp()
0x00000001078d7102 (Google Chrome Framework - mac_util.mm: 346)	base::mac::WasLaunchedAsHiddenLoginItem()
0x00000001074d0d91 (Google Chrome Framework - chrome_browser_main_mac.mm: 79)	ChromeBrowserMainPartsMac::PreEarlyInitialization()
0x0000000106408484 (Google Chrome Framework - browser_main_loop.cc: 580)	content::BrowserMainLoop::EarlyInitialization()
0x000000010640e161 (Google Chrome Framework - browser_main_runner.cc: 108)	content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&)
0x0000000106407cf3 (Google Chrome Framework - browser_main.cc: 42)	content::BrowserMain(content::MainFunctionParams const&)
0x0000000107486e7f (Google Chrome Framework - content_main_runner.cc: 686)	content::ContentMainRunnerImpl::Run()
0x0000000108da7d03 (Google Chrome Framework - main.cc: 469)	service_manager::Main(service_manager::MainParams const&)
0x0000000107486463 (Google Chrome Framework - content_main.cc: 19)	content::ContentMain(content::ContentMainParams const&)
0x0000000105e23bb7 (Google Chrome Framework - chrome_main.cc: 139)	ChromeMain
0x0000000105dcedd3 (Google Chrome - chrome_exe_main_mac.cc: 170)	main
0x00007fff648f2144 (libdyld.dylib + 0x00001144)	start
0x00007fff648f2144 (libdyld.dylib + 0x00001144)	start

 
Cc: mark@chromium.org rbasuvula@chromium.org thakis@chromium.org
Labels: TE-CrashTriage M-61
1)This crash is first started on 49.0.2623.112 and on latest Beta 61.0.3163.71 seeing 2 from 2 different clients.
2)This crash seen on Mac>Browser and it is in 5th rank position.
3)This crash is not seen in latest Canary(62.0.3201.0)& Dev(62.0.3198.0).

61.0.3163.71	1.85%	2	-Beta
60.0.3112.113	9.26%	10	-Stable

Link to the list of builds:
---------------------------
https://crash.corp.google.com/browse?q=custom_data.ChromeCrashProto.ptype%3D%27browser%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D%27base%3A%3Amac%3A%3A%60anonymous%20namespace%5C%27%3A%3AGetLoginItemForApp%27&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D&unnest=#-property-selector,samplereports:5,+productversion:1000

Unable to find the suspect. Hence untriaging the issue so that issue would get addressed.

Thank You!

Comment 2 by shrike@chromium.org, Sep 15 2017

Owner: shrike@chromium.org
Status: Started (was: Untriaged)
The summary page for this crasher shows the following message:

*** CFEqual() called with NULL first argument ***

The implication is that LSSharedFileListItemResolve() can return with a NULL CFURLRef even if the function returns noErr.
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2821e85855fb4336a21635553b7d72baaf6e2c4d

commit 2821e85855fb4336a21635553b7d72baaf6e2c4d
Author: Jayson Adams <shrike@chromium.org>
Date: Mon Sep 18 23:29:38 2017

[Mac] Guard against LSSharedFileListItemResolve() crasher.

In GetLoginItemForApp() we call LSSharedFileListItemResolve(). There
are crashers because the function apparently can return a NULL CFURLRef
even when the function itself returns noErr. This cl checks that the
returned CFURLRef is non-NULL before proceeding.

R=mark@chromium.org

Bug:  760989 
Change-Id: Ibb37ceae4b7ccb6765d10392fa786d3fea05eded
Reviewed-on: https://chromium-review.googlesource.com/669879
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Jayson Adams <shrike@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502711}
[modify] https://crrev.com/2821e85855fb4336a21635553b7d72baaf6e2c4d/base/mac/mac_util.mm

Comment 4 by shrike@chromium.org, Sep 18 2017

Status: Fixed (was: Started)

Comment 6 by rsesek@chromium.org, Oct 30 2017

Labels: -Restrict-View-EditIssue -M-61 M-63

Comment 7 by rsesek@chromium.org, Oct 30 2017

Cc: rsesek@chromium.org shrike@chromium.org
 Issue 779362  has been merged into this issue.
 Issue 791504  has been merged into this issue.

Sign in to add a comment