Regression: None of the browser shortcut keys work when blocked interstitial page is refreshed. |
|||
Issue descriptionChrome Version: 61.0.3163.71 & OS: Windows-10, Mac OS 10.12.6, Linux Ubuntu 14.04 & Chrome OS Peppy What steps will reproduce the problem? (1) In supervised user, Go to any of the webpage which is blocked. (2) When on the blocked page, refresh the page via Cmd/Ctrl+R/F5 or using omnibox refresh button. (3) Once the page is refreshed, try to open new tab Ctrl+T or use any other browser keyboard shortcut. What is the expected result? > Browser keyboard shortcuts should work. What happens instead? > None of the browser keyboard shortcuts are working.
,
Aug 31 2017
This is a regression issue broken in M-60. Last good build: 60.0.3087.0 First bad build: 60.0.3088.0 Changelog: ========== https://chromium.googlesource.com/chromium/src/+/3483d15c1e3cec604c66663f19654a271bfe77ec Looks to be related to https://codereview.chromium.org/2845053002 from the above regression range.
,
Nov 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd56d3ad0528a6c472fd8da6704e0715340cbf82 commit fd56d3ad0528a6c472fd8da6704e0715340cbf82 Author: Bernhard Bauer <bauerb@chromium.org> Date: Wed Nov 22 12:31:24 2017 Keep existing supervised interstitial around only for committed navigations. https://crrev.com/468591 avoided showing a supervised user interstitial over an existing one, but that only applies to committed navigations (where spurious callbacks can happen, and where canceling the existing interstitial might close the tab), and actually causes weird issues for non-committed navigations. Additional cleanup: Move from RepeatingCallback to OnceCallback for asynchronous checks, to make sure we run them once and only once. Bug: 760986 ,760540,b/69306583 Change-Id: I1da6447c47855d5dbc94c09151408f1d049399c6 Reviewed-on: https://chromium-review.googlesource.com/781768 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#518614} [modify] https://crrev.com/fd56d3ad0528a6c472fd8da6704e0715340cbf82/chrome/browser/safe_search_api/safe_search_url_checker.cc [modify] https://crrev.com/fd56d3ad0528a6c472fd8da6704e0715340cbf82/chrome/browser/safe_search_api/safe_search_url_checker.h [modify] https://crrev.com/fd56d3ad0528a6c472fd8da6704e0715340cbf82/chrome/browser/supervised_user/supervised_user_browsertest.cc [modify] https://crrev.com/fd56d3ad0528a6c472fd8da6704e0715340cbf82/chrome/browser/supervised_user/supervised_user_navigation_observer.cc [modify] https://crrev.com/fd56d3ad0528a6c472fd8da6704e0715340cbf82/chrome/browser/supervised_user/supervised_user_url_filter.cc [modify] https://crrev.com/fd56d3ad0528a6c472fd8da6704e0715340cbf82/chrome/browser/supervised_user/supervised_user_url_filter.h
,
Nov 22 2017
Should be fixed now. |
|||
►
Sign in to add a comment |
|||
Comment 1 by bauerb@chromium.org
, Aug 31 2017