New issue
Advanced search Search tips

Issue 760969 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

ClearBrowsingData_TimePeriodChanged_* action logged incorrectly on first visit to CBD dialog

Project Member Reported by dullweber@chromium.org, Aug 31 2017

Issue description

Chrome Version: HEAD

What steps will reproduce the problem?
(1) Restart Chrome
(2) Visit Clear Browsing Data

What is the expected result?
No TimePeriodChanged action logged until the timeperiod is actually changed.

What happens instead?
The action is logged with the initial time period value
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bffaff96a165b6d7fe21e91e7e43a1db02eab56

commit 9bffaff96a165b6d7fe21e91e7e43a1db02eab56
Author: Christian Dullweber <dullweber@chromium.org>
Date: Fri Sep 01 08:49:24 2017

Fix incorrect logging of CBD_TimePeriodChanged

When the Clear Browsing Data dialog is created, the timeperiod selector
is set to the last used value. Afterwards a listener is registered to
update a preference when this value changes and log a UserAction.
Due to an asynchronous event from setting the initial value, this action
is logged incorrectly when the dialog is created.
This CL fixes the issue by only logging if the value actually changes.

Bug:  760969 
Change-Id: I8c9fe05873b15af59906c26caf75124701ac1708
Reviewed-on: https://chromium-review.googlesource.com/645850
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499153}
[modify] https://crrev.com/9bffaff96a165b6d7fe21e91e7e43a1db02eab56/chrome/browser/android/preferences/pref_service_bridge.cc

Labels: Merge-Request-62
This fixes a metric that is currently logged incorrectly. The CL missed the branch point by a few hours
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 5 2017

Labels: -Merge-Request-62 Hotlist-Merge-Approved Merge-Approved-62
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 5 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84b06bc860bfb91b76363d226db3a6735f6b11a2

commit 84b06bc860bfb91b76363d226db3a6735f6b11a2
Author: Christian Dullweber <dullweber@chromium.org>
Date: Tue Sep 05 08:43:57 2017

Fix incorrect logging of CBD_TimePeriodChanged

When the Clear Browsing Data dialog is created, the timeperiod selector
is set to the last used value. Afterwards a listener is registered to
update a preference when this value changes and log a UserAction.
Due to an asynchronous event from setting the initial value, this action
is logged incorrectly when the dialog is created.
This CL fixes the issue by only logging if the value actually changes.

TBR=dullweber@chromium.org

(cherry picked from commit 9bffaff96a165b6d7fe21e91e7e43a1db02eab56)

Bug:  760969 
Change-Id: I8c9fe05873b15af59906c26caf75124701ac1708
Reviewed-on: https://chromium-review.googlesource.com/645850
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499153}
Reviewed-on: https://chromium-review.googlesource.com/649649
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#20}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/84b06bc860bfb91b76363d226db3a6735f6b11a2/chrome/browser/android/preferences/pref_service_bridge.cc

Status: Fixed (was: Started)

Sign in to add a comment