New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 760967 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
OoO until Feb 4th
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

external/wpt/payment-request/payment-request-... failures on WebKit Mac bots

Project Member Reported by hbos@chromium.org, Aug 31 2017

Issue description

WebKit Mac10.11
WebKit Mac10.10
WebKit Mac10.9

Unexpected Failures:
* external/wpt/payment-request/payment-request-constructor.https.html
* external/wpt/payment-request/payment-request-ctor-pmi-handling.https.html

Probably introduced by
https://chromium-review.googlesource.com/c/chromium/src/+/644534
at
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11/builds/23056

I was unable to repro on my Macbook
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39173724dd5af4c3ba00c04617da073e27dac6ba

commit 39173724dd5af4c3ba00c04617da073e27dac6ba
Author: Henrik Boström <hbos@chromium.org>
Date: Thu Aug 31 13:56:02 2017

Disabled payment-request web platform tests on Mac

TBR=qyearsley@chromium.org
NOTRY=True

Bug:  760967 
Change-Id: I7543f7df1c049aca53a53cc26ab8fd7066158c56
Reviewed-on: https://chromium-review.googlesource.com/645971
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498850}
[modify] https://crrev.com/39173724dd5af4c3ba00c04617da073e27dac6ba/third_party/WebKit/LayoutTests/TestExpectations

Comment 2 by hbos@chromium.org, Aug 31 2017

Labels: -Sheriff-Chromium
Removing sheriff label now that the test has been disabled.
Cc: robertma@chromium.org foolip@chromium.org
Components: Blink>Infra>Ecosystem
+robertma and foolip, who's on rotation today and tomorrow.

I'm about to call it a day, but from what I see it's possible that the WPT CL just added the wrong expectations to the platform/mac* directories due to flaky/bad results from the trybots. Instead of skipping the tests like the CL in comment #1 did one should remove the wrong expectations that the original WPT CL added for the macs.
... that explains the mac10.11 entries (https://luci-milo.appspot.com/buildbot/tryserver.blink/mac10.11_blink_rel/3814 ->  bug 756421 ).

It's unclear why wpt-importer added an expectations file for mac10.10 that is identical to the generic one. Maybe there's an expectation chain that includes 10.11 and 10.10 that I haven't checked, which would also explain the 10.9 failures mentioned in this bug report.
https://chromium-review.googlesource.com/c/chromium/src/+/648852 has taken care of fixing external/wpt/payment-request/payment-request-constructor.https.html's expectation files and entry in TestExpectations.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab777fb19f5c939ac66568ddf656916c56c8827a

commit ab777fb19f5c939ac66568ddf656916c56c8827a
Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Date: Tue Sep 05 14:20:59 2017

Drop some mac10.11- and mac10.10-specific expectations.

https://chromium-review.googlesource.com/c/chromium/src/+/644534 added some
platform-specific expectations for the following two tests:
* external/wpt/payment-request/payment-request-constructor.https.html
* external/wpt/payment-request/payment-request-ctor-pmi-handling.https.html

The expectations came from flaky trybots and were thus wrong. They were
later skipped in https://chromium-review.googlesource.com/645971, and then
https://chromium-review.googlesource.com/c/chromium/src/+/648852 adjusted
the expectations for
external/wpt/payment-request/payment-request-constructor.https.html.

This CL finishes the job by unskipping
payment-request-ctor-pmi-handling.https.html and dropping the
platform-specific expectations for the test. The mac10.10 one was identical
to the generic expectation file, while the 10.11 was just clearly wrong.

TBR=qyearsley@chromium.org

Bug:  760967 
Change-Id: If7009f357f38786620b572077672c898e5597a5d
Reviewed-on: https://chromium-review.googlesource.com/649794
Reviewed-by: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com>
Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#499623}
[modify] https://crrev.com/ab777fb19f5c939ac66568ddf656916c56c8827a/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/8fc2680b3f5a55910c378b4534d349381e1b1be4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/external/wpt/payment-request/payment-request-ctor-pmi-handling.https-expected.txt
[delete] https://crrev.com/8fc2680b3f5a55910c378b4534d349381e1b1be4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/external/wpt/payment-request/payment-request-ctor-pmi-handling.https-expected.txt

Cc: qyears...@chromium.org
Owner: raphael....@intel.com
Status: Fixed (was: Assigned)

Sign in to add a comment