Media Engagement: Issues with syncing |
|||||
Issue descriptionWhat steps will reproduce the problem? (1) Open two browsers with the same synced profile (2) Open the same origin on the two browsers at the same time (3) Wait for the data to sync (4) Observe in chrome://media-engagement that only one visit was recorded (5) Have significant playback on both sites at different times (i.e. let it sync) (6) Observe the scores in chrome://media-engagement What is the expected result? There should be 2 visits and 2 playbacks What happens instead? There is 1 visit and 2 playbacks. This can result in a MEI score > 1.0.
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6354b6b72b5178a5b20a9b332ad0e4600dcb8520 commit 6354b6b72b5178a5b20a9b332ad0e4600dcb8520 Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Aug 31 22:01:55 2017 Media Engagement: Add schema version pref. Add a preference to have a schema version stored on the profile. If we change how MEI data is stored/collected then we can increment the schema version in MediaEngagementService and this will cause all clients to wipe MEI data on next start. BUG= 760956 Change-Id: I5d6f5e1306211eced98f34c0c39eab2557c51de5 Reviewed-on: https://chromium-review.googlesource.com/645967 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#499030} [modify] https://crrev.com/6354b6b72b5178a5b20a9b332ad0e4600dcb8520/chrome/browser/media/media_engagement_service.cc [modify] https://crrev.com/6354b6b72b5178a5b20a9b332ad0e4600dcb8520/chrome/browser/media/media_engagement_service.h [modify] https://crrev.com/6354b6b72b5178a5b20a9b332ad0e4600dcb8520/chrome/browser/media/media_engagement_service_unittest.cc [modify] https://crrev.com/6354b6b72b5178a5b20a9b332ad0e4600dcb8520/chrome/browser/prefs/browser_prefs.cc [modify] https://crrev.com/6354b6b72b5178a5b20a9b332ad0e4600dcb8520/chrome/common/pref_names.cc [modify] https://crrev.com/6354b6b72b5178a5b20a9b332ad0e4600dcb8520/chrome/common/pref_names.h
,
Sep 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71806d64a7be455280e0b025c5e54d899d908489 commit 71806d64a7be455280e0b025c5e54d899d908489 Author: Becca Hughes <beccahughes@chromium.org> Date: Fri Sep 01 16:21:10 2017 Media Engagement: Disable syncing of MEI data. Disable syncing on MEI data due to the conflicts bug. Also increase the schema version to wipe any corrupt data. BUG= 760956 Change-Id: I6e428c2e07b5448be4656442f4b04563370bd124 Reviewed-on: https://chromium-review.googlesource.com/645977 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#499210} [modify] https://crrev.com/71806d64a7be455280e0b025c5e54d899d908489/chrome/browser/media/media_engagement_service.cc [modify] https://crrev.com/71806d64a7be455280e0b025c5e54d899d908489/components/content_settings/core/browser/website_settings_registry.cc
,
Sep 2 2017
It looks like the first CL made it in M62, but the second didn't.
,
Sep 3 2017
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec23cad765056fe74a64b1c8b6c631083208c178 commit ec23cad765056fe74a64b1c8b6c631083208c178 Author: Becca Hughes <beccahughes@chromium.org> Date: Mon Sep 04 08:37:34 2017 Media Engagement: Disable syncing of MEI data. Disable syncing on MEI data due to the conflicts bug. Also increase the schema version to wipe any corrupt data. BUG= 760956 Change-Id: I6e428c2e07b5448be4656442f4b04563370bd124 Reviewed-on: https://chromium-review.googlesource.com/645977 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499210}(cherry picked from commit 71806d64a7be455280e0b025c5e54d899d908489) Reviewed-on: https://chromium-review.googlesource.com/647449 Reviewed-by: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#17} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/ec23cad765056fe74a64b1c8b6c631083208c178/chrome/browser/media/media_engagement_service.cc [modify] https://crrev.com/ec23cad765056fe74a64b1c8b6c631083208c178/components/content_settings/core/browser/website_settings_registry.cc
,
Sep 4 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by beccahughes@chromium.org
, Aug 31 2017