New issue
Advanced search Search tips

Issue 760940 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Failure in ProfileManagerGuestTest if the wrong tests are run in the same shard

Project Member Reported by atwilson@chromium.org, Aug 31 2017

Issue description

To repro: run unit_tests --gtest_filter=ProfileManager*Test*Policy*

This runs just a subset of the ProfileManagerTests, all in the same shard. Turns out that some tests don't clean up properly after creating users (they leave extensions::FeatureSessionType set) which breaks ProfileManagerGuestTest.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6c2c37e3885cf32cc4bf790b970d55846b8a25f

commit c6c2c37e3885cf32cc4bf790b970d55846b8a25f
Author: Andrew Wilson <atwilson@chromium.org>
Date: Fri Sep 01 14:44:27 2017

Fixed problem with leaving FeatureSessionType set between test invocations.

Bug:  760940 
Change-Id: I73ebaee4a21bcfa745e87b7783349334f48ba144
Reviewed-on: https://chromium-review.googlesource.com/645635
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Drew Wilson <atwilson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499192}
[modify] https://crrev.com/c6c2c37e3885cf32cc4bf790b970d55846b8a25f/chrome/browser/profiles/profile_manager_unittest.cc

Status: Fixed (was: Untriaged)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 4 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment