New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 760932 link

Starred by 2 users
Status: Fixed
Owner:
sammiequon@chromium.org
Closed: Sep 2017
Cc:
█ krajshree@chromium.org
ajha@chromium.org
█ brajkumar@chromium.org
steve...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression : Default focus is on 'PIN or Password' option instead of 'Password only' option in chrome://md-settings/lockScreen page

Project Member Reported by mmanchala@chromium.org, Aug 31 2017 
Chrome Version: 60.0.3112.114/9592.90.0 stable-channel Daisy,Candy and Minnie
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> Go to chrome://md-settings -> Now under 'People' section click on 'Screen lock' option
(2)Now enter User Password in 'Confirm your password' dialog box -> Enable 'Show lock screen when waking from sleep' option
(3)Now at 'screen lock options' section  select 'Password only' option' and now select 'PIN or Password' option but don't click on 'SET UP PIN' and now go back to chrome://md-settings page
(4)Observe 'Password only' option is selected at 'Screen lock' option -> Now again click on 'Screen lock' and enter password -> Now observe default focus is on 'PIN or Password' option (Please refer Video)

Note: Default focus on 'Password only' option is seen when again chrome://md-setings page is opened in New tab

Expected: Default focus should be on 'Password only' option as that option is selected
Actual: Instead default focus is on 'PIN or Password' option 

This is Non-Regression Issue as 'Screen lock' is introduced from M-57

@stevenjb : Please confirm the Issue

Note: Issue is seen on latest M-62 also
Actual.webm
1.3 MB View Download

Comment 1 by steve...@chromium.org, Aug 31 2017

Cc: steve...@chromium.org
Owner: sammiequon@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c886e1823984b87ee4c9bcab0dcc269de277cdc7

commit c886e1823984b87ee4c9bcab0dcc269de277cdc7
Author: Sammie Quon <sammiequon@google.com>
Date: Wed Sep 06 19:06:12 2017

settings: Fix bug with wrong unlock type selected radio button.

If we click the pin radio button but do not select a pin, on re-entering the lock
screen page we should not highlight the pin radio button.

Test: manual
Bug:  760932 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic5a0e00a22cb58fa523c477be4be271a8760bbce
Reviewed-on: https://chromium-review.googlesource.com/646274
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500029}
[modify] https://crrev.com/c886e1823984b87ee4c9bcab0dcc269de277cdc7/chrome/browser/resources/settings/people_page/lock_screen.js
[modify] https://crrev.com/c886e1823984b87ee4c9bcab0dcc269de277cdc7/chrome/browser/resources/settings/people_page/lock_state_behavior.js

Comment 3 by sammiequon@chromium.org, Sep 6 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment