Print using system dialogue button is seen on Print preview page.
Reported by
aiman.an...@etouch.net,
Aug 31 2017
|
||||||||
Issue descriptionChrome Version: 62.0.3201.0 (Official Build) 5d0afdac43361da3ee5cb6f11f756c07423756ba-refs/heads/master@{#498715} (64 Bit). OS: Mac(10.11.6, 10.12.3, 10.12.5). Steps to Reproduce: 1.Launch chrome, go to NTP and give print command. 2.Enter random alphabet in Pages textbox, so that it gives error. 3.Click on 'Open in PDF preview' and observe. Actual Result: Print using system dialogue button is seen on Print preview page(Also the button is unresponsive). Expected Result: Print using system dialogue button should not be seen on Print preview page. This is Non-Regression issue seen from M-45. Note: Issue is MAC specific.
,
Sep 12 2017
,
Sep 12 2017
We should disable both this link and the "Print using system dialog..." link on Windows whenever there is an error and the "Print" or "Save" button is disabled. Both these buttons initiate a print request, which will fail if the print ticket is invalid.
,
Sep 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91afdb650d86071b79d384d03ceef7e0d3dab358 commit 91afdb650d86071b79d384d03ceef7e0d3dab358 Author: rbpotter <rbpotter@chromium.org> Date: Sat Sep 16 01:08:09 2017 Print Preview: Disable links that allow printing when ticket is invalid Also remove an event that is never dispatched. Bug: 760927 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7bcc0028899f824e4fbc1e75b778add327f5ebd5 Reviewed-on: https://chromium-review.googlesource.com/664420 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#502459} [modify] https://crrev.com/91afdb650d86071b79d384d03ceef7e0d3dab358/chrome/browser/resources/print_preview/data/print_ticket_store.js [modify] https://crrev.com/91afdb650d86071b79d384d03ceef7e0d3dab358/chrome/browser/resources/print_preview/previewarea/preview_area.js [modify] https://crrev.com/91afdb650d86071b79d384d03ceef7e0d3dab358/chrome/browser/resources/print_preview/print_header.js [modify] https://crrev.com/91afdb650d86071b79d384d03ceef7e0d3dab358/chrome/browser/resources/print_preview/print_preview.css [modify] https://crrev.com/91afdb650d86071b79d384d03ceef7e0d3dab358/chrome/browser/resources/print_preview/print_preview.js [modify] https://crrev.com/91afdb650d86071b79d384d03ceef7e0d3dab358/chrome/test/data/webui/print_preview/print_preview_tests.js [modify] https://crrev.com/91afdb650d86071b79d384d03ceef7e0d3dab358/chrome/test/data/webui/print_preview/print_preview_ui_browsertest.js
,
Sep 29 2017
,
Sep 29 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by rbasuvula@chromium.org
, Aug 31 2017