New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 760926 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::DeferredImageDecoder::CreateGenerator

Project Member Reported by ClusterFuzz, Aug 31 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5276883519537152

Fuzzer: noel-image-surku
Job Type: windows_asan_chrome_no_sandbox
Platform Id: windows

Crash Type: Null-dereference READ
Crash Address: 0x00000004
Crash State:
  blink::DeferredImageDecoder::CreateGenerator
  blink::BitmapImage::CreateAndCacheFrame
  blink::BitmapImage::FrameAtIndex
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=498677:498736

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5276883519537152

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Aug 31 2017

Labels: OS-Mac OS-Linux
Cc: msrchandra@chromium.org
Components: Blink>Paint
Labels: Test-Predator-Wrong-CLs M-62
Owner: khushals...@chromium.org
Status: Assigned (was: Untriaged)
Predator could not provide any possible suspects.
Assigning to the concern owner from CL --
https://chromium.googlesource.com/chromium/src/+log/2653cfab2f72876064cb670f7421c13655bff34e..b41caaafb9b0785845a8fafc141bf54da6fe1875?pretty=fuller&n=10000

Suspecting Commit#
https://chromium.googlesource.com/chromium/src/+/b41caaafb9b0785845a8fafc141bf54da6fe1875

@khushalsagar -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc3b62e68ffca69fa4b78198241ec50a4ce7ec55

commit bc3b62e68ffca69fa4b78198241ec50a4ce7ec55
Author: Khushal <khushalsagar@chromium.org>
Date: Thu Aug 31 22:34:01 2017

blink: Fix ImageFrameGenerator nullptr access in DeferredImageDecoder.

We don't create the ImageFrameGenerator until enough data is available
to read the size of the image.

Bug:  760926 
Change-Id: I19b7cb2c64071eaaf0d318cf2cb5228e174d62d7
Reviewed-on: https://chromium-review.googlesource.com/646569
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499053}
[modify] https://crrev.com/bc3b62e68ffca69fa4b78198241ec50a4ce7ec55/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp

Status: Fixed (was: Assigned)
Project Member

Comment 5 by ClusterFuzz, Sep 1 2017

ClusterFuzz has detected this issue as fixed in range 499009:499055.

Detailed report: https://clusterfuzz.com/testcase?key=5276883519537152

Fuzzer: noel-image-surku
Job Type: windows_asan_chrome_no_sandbox
Platform Id: windows

Crash Type: Null-dereference READ
Crash Address: 0x00000004
Crash State:
  blink::DeferredImageDecoder::CreateGenerator
  blink::BitmapImage::CreateAndCacheFrame
  blink::BitmapImage::FrameAtIndex
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=498677:498736
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=499009:499055

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5276883519537152

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Sep 1 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5276883519537152 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment